You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "TyrantLucifer (via GitHub)" <gi...@apache.org> on 2023/03/19 07:24:39 UTC
[GitHub] [incubator-seatunnel] TyrantLucifer opened a new pull request, #4369: feat(CI): Add commit message check action
TyrantLucifer opened a new pull request, #4369:
URL: https://github.com/apache/incubator-seatunnel/pull/4369
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer closed pull request #4369: ci(backend): add commit message check step
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer closed pull request #4369: ci(backend): add commit message check step
URL: https://github.com/apache/incubator-seatunnel/pull/4369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer closed pull request #4369: ci(backend): add commit message check step
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer closed pull request #4369: ci(backend): add commit message check step
URL: https://github.com/apache/incubator-seatunnel/pull/4369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #4369: ci(backend): add commit message check step
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #4369:
URL: https://github.com/apache/incubator-seatunnel/pull/4369#issuecomment-1475183890
>
You are correct. However, currently, some committers may not modify the final message when merging code, which means that the information merged into the main branch is the last submission message of the contributor. If standardizing committers' merging behavior is important and needs to be addressed, do you have any suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer closed pull request #4369: ci(backend): add commit message check step
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer closed pull request #4369: ci(backend): add commit message check step
URL: https://github.com/apache/incubator-seatunnel/pull/4369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer closed pull request #4369: ci(backend): add commit message check step
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer closed pull request #4369: ci(backend): add commit message check step
URL: https://github.com/apache/incubator-seatunnel/pull/4369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kezhenxu94 commented on pull request #4369: ci(backend): add commit message check step
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #4369:
URL: https://github.com/apache/incubator-seatunnel/pull/4369#issuecomment-1475182955
Hi. Checking the commit message doesn’t make any sense to me because we are using “Squash and merge”, all the commit messages will be rewrote to the pull request title when merging, checking the unused commit messages increase the contributors’ burden while bring nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kezhenxu94 commented on pull request #4369: ci(backend): add commit message check step
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #4369:
URL: https://github.com/apache/incubator-seatunnel/pull/4369#issuecomment-1475189946
> > Hi. Checking the commit message doesn’t make any sense to me because we are using “Squash and merge”, all the commit messages will be rewrote to the pull request title when merging, checking the unused commit messages increase the contributors’ burden while bring nothing.
>
> You are correct. However, currently, some committers may not modify the final message when merging code, which means that the information merged into the main branch is the last submission message of the contributor. If standardizing committers' merging behavior is important and needs to be addressed, do you have any suggestions?
The default commit message when merging is the pull request title, so you might want to check PR title instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #4369: ci(backend): add commit message check step
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #4369:
URL: https://github.com/apache/incubator-seatunnel/pull/4369#issuecomment-1476254910
> > > Hi. Checking the commit message doesn’t make any sense to me because we are using “Squash and merge”, all the commit messages will be rewrote to the pull request title when merging, checking the unused commit messages increase the contributors’ burden while bring nothing.
> >
> >
> > You are correct. However, currently, some committers may not modify the final message when merging code, which means that the information merged into the main branch is the last submission message of the contributor. If standardizing committers' merging behavior is important and needs to be addressed, do you have any suggestions?
>
> The default commit message when merging is the pull request title, so you might want to check PR title instead
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #4369: ci(backend): add commit message check step
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #4369:
URL: https://github.com/apache/incubator-seatunnel/pull/4369#issuecomment-1475183942
> Hi. Checking the commit message doesn’t make any sense to me because we are using “Squash and merge”, all the commit messages will be rewrote to the pull request title when merging, checking the unused commit messages increase the contributors’ burden while bring nothing.
You are correct. However, currently, some committers may not modify the final message when merging code, which means that the information merged into the main branch is the last submission message of the contributor. If standardizing committers' merging behavior is important and needs to be addressed, do you have any suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org