You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/11/04 11:35:26 UTC

[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2515: Setting the icon, categories, and renaming debug configuration for VSCode extension.

JaroslavTulach commented on a change in pull request #2515:
URL: https://github.com/apache/netbeans/pull/2515#discussion_r517281093



##########
File path: java/java.lsp.server/vscode/package.json
##########
@@ -65,8 +65,8 @@
 		],
 		"debuggers": [
 			{
-				"type": "java-polyglot",
-				"label": "Java (Polyglot)",
+				"type": "java8+",
+				"label": "Java 8+",

Review comment:
       The "Java 8+" name seems to nicely stress the core functionality of Apache NetBeans Language Server VSCode extension - e.g. the ability to run on JDK8 (other extensions require JDK11). I think it is a good name.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists