[GitHub] [spark] srowen commented on a diff in pull request #37404: [SPARK-39866][SQL] Memory leak when closing a session of Spark ThriftServer

[GitBox <gi...@apache.org>]

srowen commented on code in PR #37404:
URL: https://github.com/apache/spark/pull/37404#discussion_r942659571


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileStatusCache.scala:
##########
@@ -36,6 +37,8 @@ import org.apache.spark.util.SizeEstimator
 object FileStatusCache {
   private var sharedCache: SharedInMemoryCache = _
 
+  private[spark] val sessionToCache = new mutable.HashMap[String, FileStatusCache]

Review Comment:
   Can this itself grow large? I'm also wary of maps that track stuff over long periods as a potential memory problem



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org