[jira] [Commented] (SPARK-31456) If shutdownhook is added with priority Integer.MIN_VALUE, it's supposed to be called the last, but it gets called before other positive priority shutdownhook

["Oleg Kuznetsov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-31456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103962#comment-17103962 ] 

Oleg Kuznetsov commented on SPARK-31456:
----------------------------------------

I will work on that.

> If shutdownhook is added with priority Integer.MIN_VALUE, it's supposed to be called the last, but it gets called before other positive priority shutdownhook
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SPARK-31456
>                 URL: https://issues.apache.org/jira/browse/SPARK-31456
>             Project: Spark
>          Issue Type: Bug
>          Components: Spark Core
>    Affects Versions: 2.4.5
>         Environment: macOS Mojave 10.14.6
>            Reporter: Xiaolei Liu
>            Priority: Major
>
> https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/util/ShutdownHookManager.scala
> Since shutdownHookManager use below method to do the comparison. 
> override def compareTo(other: SparkShutdownHook): Int = {
>     other.priority - priority
>   }
> Which will cause :
> (Int)(25 - Integer.MIN_VALUE) < 0
> Then the shutdownhook with Integer.Min_VALUE would not be called the last. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org