You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Dmitriy Shirchenko <ca...@gmail.com> on 2017/02/14 23:56:12 UTC
Review Request 56690: [Patch 1/2] RFC for first patch implementing
scheduling changes for Dynamic Reservations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/
-----------------------------------------------------------
Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
Bugs: AURORA-1819
https://issues.apache.org/jira/browse/AURORA-1819
Repository: aurora
Description
-------
This is an RFC (without tests) for dynamic reservations proposal. If there is consensus on the approach, I will add tests. This patch was also tested locally and works as expected.
Diffs
-----
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f
src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java fbd24ea4a58e28c14a343170de137c0e0ae437a2
src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb
src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa
src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca
src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 0136afb8f6049a6d88cd42b5e3f17d61fcd629d5
src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java aba73005019c13ac943be9c53ac58c8ce5bfba94
src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 3d5c3bd139206e970811aa95bd74b78987bb9cfe
src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 2b12696d0218a48d71e89df4d3a38c6bf84c74c7
src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce
src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf
src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java d751d017522c682a1373932e286ee7b4c447e2aa
src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java a030cebea13d92766584643ddda33c50dec7bdbf
src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8
src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840
src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java fb8bd85be93280a9b8366b1398a1fa0a5817bb55
src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java 2777d7276d55cc0fe75e7470d0dc8182796d67f4
src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java 133cd23427485ea329ef10489e5d4a0029cb54cd
src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 7dc8c179736fab93ca03e174b16e104ba0118127
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java f8bb25b612ae42748205901dd4b8cfcdedf5b136
Diff: https://reviews.apache.org/r/56690/diff/
Testing
-------
Thanks,
Dmitriy Shirchenko
Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing
scheduling changes for Dynamic Reservations
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/#review165623
-----------------------------------------------------------
Master (9ea8979) is red with this patch.
./build-support/jenkins/build.sh
Note: Recompile with -Xlint:unchecked for details.
:commons:generateThriftResources
:commons:processResources
:commons:classes
:commons:jar
:compileJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:74: Note: Wrote forwarder org.apache.aurora.scheduler.storage.log.WriteAheadStorageForwarder
@Forward({
^
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor
:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java:38: Line is longer than 100 characters (found 112). [LineLength]
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleJmh'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/jmh.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 9.388 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 15, 2017, 1:44 a.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56690/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 1:44 a.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
>
>
> Bugs: AURORA-1819
> https://issues.apache.org/jira/browse/AURORA-1819
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an RFC (without tests) for dynamic reservations proposal. If there is consensus on the approach, I will add tests. This patch was also tested locally and works as expected.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f
> src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 6f2ca35c5d83dde29c24865b4826d4932e96da80
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb
> src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa
> src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca
> src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
> src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 0136afb8f6049a6d88cd42b5e3f17d61fcd629d5
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35
> src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf
> src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 9aa263a9cfae03a9a0c5bc7fe3a1405397d3009c
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java da378e84ee65a658ff2382489d3ab6d5f6451b5f
> src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8
> src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840
> src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f
> src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java dded9c34749cf599d197ed312ffb6bf63b6033f1
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java b8b8edb1a21ba89b8b60f8f8451c8c776fc23ae8
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java e04f6113c43eca4555ee0719f8208d7c4ebb8d61
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777
>
> Diff: https://reviews.apache.org/r/56690/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing
scheduling changes for Dynamic Reservations
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/#review166620
-----------------------------------------------------------
Master (98eb99a) is red with this patch.
./build-support/jenkins/build.sh
:commons:generateThriftResources
:commons:processResources
:commons:classes
:commons:jar
:compileJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:74: Note: Wrote forwarder org.apache.aurora.scheduler.storage.log.WriteAheadStorageForwarder
@Forward({
^
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor
:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java:165:50: Unnecessary parentheses around expression. [UnnecessaryParentheses]
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 14.215 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 24, 2017, 12:28 a.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56690/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 12:28 a.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
>
>
> Bugs: AURORA-1819
> https://issues.apache.org/jira/browse/AURORA-1819
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an RFC (without tests) for dynamic reservations proposal. If there is consensus on the approach, I will add tests. This patch was also tested locally and works as expected.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f
> src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 6f2ca35c5d83dde29c24865b4826d4932e96da80
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb
> src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa
> src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca
> src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
> src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 0136afb8f6049a6d88cd42b5e3f17d61fcd629d5
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35
> src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf
> src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 9aa263a9cfae03a9a0c5bc7fe3a1405397d3009c
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java da378e84ee65a658ff2382489d3ab6d5f6451b5f
> src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8
> src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840
> src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f
> src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java dded9c34749cf599d197ed312ffb6bf63b6033f1
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java b8b8edb1a21ba89b8b60f8f8451c8c776fc23ae8
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java e04f6113c43eca4555ee0719f8208d7c4ebb8d61
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777
>
> Diff: https://reviews.apache.org/r/56690/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing
scheduling changes for Dynamic Reservations
Posted by Dmitriy Shirchenko <ca...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/
-----------------------------------------------------------
(Updated March 2, 2017, 1:12 p.m.)
Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
Bugs: AURORA-1819
https://issues.apache.org/jira/browse/AURORA-1819
Repository: aurora
Description (updated)
-------
This is an RFC (without tests) for dynamic reservations proposal. If there is consensus on the approach, I will add tests. This patch was also tested locally and works as expected.
RFC document: https://docs.google.com/document/d/15n29HSQPXuFrnxZAgfVINTRP1Iv47_jfcstJNuMwr5A
Design Doc: https://docs.google.com/document/d/1L2EKEcKKBPmuxRviSUebyuqiNwaO-2hsITBjt3SgWvE
Diffs
-----
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f
src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 6f2ca35c5d83dde29c24865b4826d4932e96da80
src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb
src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa
src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca
src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35
src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce
src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf
src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 9aa263a9cfae03a9a0c5bc7fe3a1405397d3009c
src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java da378e84ee65a658ff2382489d3ab6d5f6451b5f
src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8
src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840
src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f
src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java dded9c34749cf599d197ed312ffb6bf63b6033f1
src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java b8b8edb1a21ba89b8b60f8f8451c8c776fc23ae8
src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java e04f6113c43eca4555ee0719f8208d7c4ebb8d61
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777
Diff: https://reviews.apache.org/r/56690/diff/5/
Testing
-------
Thanks,
Dmitriy Shirchenko
Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing
scheduling changes for Dynamic Reservations
Posted by Stephan Erb <se...@apache.org>.
> On March 1, 2017, 11:50 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java
> > Lines 179-192 (original), 196-209 (patched)
> > <https://reviews.apache.org/r/56690/diff/5/?file=1652041#file1652041line198>
> >
> > This compaction reads like it will cause trouble for us. Mesos will not merge reserved and un-unreserved offers.
Scrape that. Mesos will not merge resources (as they are different) but offers should be merged fine.
- Stephan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/#review167565
-----------------------------------------------------------
On Feb. 28, 2017, 10:25 p.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56690/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 10:25 p.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
>
>
> Bugs: AURORA-1819
> https://issues.apache.org/jira/browse/AURORA-1819
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an RFC (without tests) for dynamic reservations proposal. If there is consensus on the approach, I will add tests. This patch was also tested locally and works as expected.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f
> src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 6f2ca35c5d83dde29c24865b4826d4932e96da80
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb
> src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa
> src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca
> src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35
> src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf
> src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 9aa263a9cfae03a9a0c5bc7fe3a1405397d3009c
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java da378e84ee65a658ff2382489d3ab6d5f6451b5f
> src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8
> src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840
> src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f
> src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java dded9c34749cf599d197ed312ffb6bf63b6033f1
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java b8b8edb1a21ba89b8b60f8f8451c8c776fc23ae8
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java e04f6113c43eca4555ee0719f8208d7c4ebb8d61
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777
>
>
> Diff: https://reviews.apache.org/r/56690/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing
scheduling changes for Dynamic Reservations
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/#review167565
-----------------------------------------------------------
Some further thoughts (not completed)
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java
Lines 94 (patched)
<https://reviews.apache.org/r/56690/#comment239450>
Why have you chosen this particular score?
In addition, shouldn't this be DYNAMIC to account for the fact that we might want to use a seen offer in the future? This would allow you to drop the additional `if` you have introduced in `maybeAssign`.
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java
Lines 245-250 (original), 263-269 (patched)
<https://reviews.apache.org/r/56690/#comment239455>
The resourceList was added because we want to know if this UnusedResource is reserved or not, right?
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java
Line 124 (original)
<https://reviews.apache.org/r/56690/#comment239456>
Nitpick: Please keep the newline
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java
Line 147 (original)
<https://reviews.apache.org/r/56690/#comment239457>
Nitpick: Please keep the newline
src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java
Lines 179-192 (original), 196-209 (patched)
<https://reviews.apache.org/r/56690/#comment239481>
This compaction reads like it will cause trouble for us. Mesos will not merge reserved and un-unreserved offers.
src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java
Lines 196-198 (patched)
<https://reviews.apache.org/r/56690/#comment239476>
I believe there should be another place where we can put it. There has to be a place where we decide to start preempting for the `preferred` tier. There we could add this guard as a refinement.
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java
Lines 177-178 (original), 206-252 (patched)
<https://reviews.apache.org/r/56690/#comment239486>
For me this larg change in TaskAssigner feels like something is wrong. There must be a better way/place how to do this.
The TaskAssigner used to be oblivious to scheduling implementation details and was only caring about the high-level Veto concepts. Now it has to deal with details.
I don't have a better solution yet, but I will think about it.
- Stephan Erb
On Feb. 28, 2017, 10:25 p.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56690/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 10:25 p.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
>
>
> Bugs: AURORA-1819
> https://issues.apache.org/jira/browse/AURORA-1819
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an RFC (without tests) for dynamic reservations proposal. If there is consensus on the approach, I will add tests. This patch was also tested locally and works as expected.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f
> src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 6f2ca35c5d83dde29c24865b4826d4932e96da80
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb
> src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa
> src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca
> src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35
> src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf
> src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 9aa263a9cfae03a9a0c5bc7fe3a1405397d3009c
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java da378e84ee65a658ff2382489d3ab6d5f6451b5f
> src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8
> src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840
> src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f
> src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java dded9c34749cf599d197ed312ffb6bf63b6033f1
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java b8b8edb1a21ba89b8b60f8f8451c8c776fc23ae8
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java e04f6113c43eca4555ee0719f8208d7c4ebb8d61
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777
>
>
> Diff: https://reviews.apache.org/r/56690/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing
scheduling changes for Dynamic Reservations
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/#review167149
-----------------------------------------------------------
Master (2652fe0) is red with this patch.
./build-support/jenkins/build.sh
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java:332: error: incompatible types: inferred type does not conform to upper bound(s)
eq(SINGLE_TASK),
^
inferred: ImmutableSet<String>
upper bound(s): Map<String,IAssignedTask>,Object
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java:178: error: incompatible types: IAssignedTask cannot be converted to TaskInfo
offerManager.launchTask(OFFER_B.getOffer(), ASSIGNED_TASK, false);
^
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java:334: error: incompatible types: IAssignedTask cannot be converted to TaskInfo
offerManager.launchTask(OFFER_A.getOffer(), ASSIGNED_TASK, false);
^
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java:346: error: incompatible types: IAssignedTask cannot be converted to TaskInfo
offerManager.launchTask(OFFER_A.getOffer(), ASSIGNED_TASK, false);
^
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java:419: error: incompatible types: IAssignedTask cannot be converted to TaskInfo
offerManager.launchTask(OFFER_D.getOffer(), ASSIGNED_TASK, true);
^
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java:461: error: cannot find symbol
offerManager.reserveAndLaunchTask(OFFER_D.getOffer(), ASSIGNED_TASK, TASK_INFO);
^
symbol: method reserveAndLaunchTask(Offer,IAssignedTask,TaskInfo)
location: variable offerManager of type OfferManagerImpl
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some messages have been simplified; recompile with -Xdiags:verbose to get full output
36 errors
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileTestJava'.
> Compilation failed; see the compiler error output for details.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 2 mins 14.792 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 28, 2017, 9:25 p.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56690/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 9:25 p.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
>
>
> Bugs: AURORA-1819
> https://issues.apache.org/jira/browse/AURORA-1819
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an RFC (without tests) for dynamic reservations proposal. If there is consensus on the approach, I will add tests. This patch was also tested locally and works as expected.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f
> src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 6f2ca35c5d83dde29c24865b4826d4932e96da80
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb
> src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa
> src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca
> src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35
> src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf
> src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 9aa263a9cfae03a9a0c5bc7fe3a1405397d3009c
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java da378e84ee65a658ff2382489d3ab6d5f6451b5f
> src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8
> src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840
> src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f
> src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java dded9c34749cf599d197ed312ffb6bf63b6033f1
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java b8b8edb1a21ba89b8b60f8f8451c8c776fc23ae8
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java e04f6113c43eca4555ee0719f8208d7c4ebb8d61
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777
>
> Diff: https://reviews.apache.org/r/56690/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing
scheduling changes for Dynamic Reservations
Posted by Dmitriy Shirchenko <ca...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 9:25 p.m.)
Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
Changes
-------
Fixing checkstyle.
Bugs: AURORA-1819
https://issues.apache.org/jira/browse/AURORA-1819
Repository: aurora
Description
-------
This is an RFC (without tests) for dynamic reservations proposal. If there is consensus on the approach, I will add tests. This patch was also tested locally and works as expected.
Diffs (updated)
-----
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f
src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 6f2ca35c5d83dde29c24865b4826d4932e96da80
src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb
src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa
src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca
src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35
src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce
src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf
src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 9aa263a9cfae03a9a0c5bc7fe3a1405397d3009c
src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java da378e84ee65a658ff2382489d3ab6d5f6451b5f
src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8
src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840
src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f
src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java dded9c34749cf599d197ed312ffb6bf63b6033f1
src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java b8b8edb1a21ba89b8b60f8f8451c8c776fc23ae8
src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java e04f6113c43eca4555ee0719f8208d7c4ebb8d61
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777
Diff: https://reviews.apache.org/r/56690/diff/
Testing
-------
Thanks,
Dmitriy Shirchenko
Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing
scheduling changes for Dynamic Reservations
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/#review166769
-----------------------------------------------------------
Master (98eb99a) is red with this patch.
./build-support/jenkins/build.sh
:distZip
:assemble
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java:22:8: Unused import - com.google.common.base.Optional. [UnusedImports]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java:85: 'method def' child have incorrect indentation level 6, expected level should be 4. [Indentation]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java:88: 'method def' child have incorrect indentation level 6, expected level should be 4. [Indentation]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java:89: 'for' have incorrect indentation level 6, expected level should be 4. [Indentation]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java:90: 'for' child have incorrect indentation level 8, expected level should be 6. [Indentation]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java:91: 'for' child have incorrect indentation level 8, expected level should be 6. [Indentation]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java:92: 'for' child have incorrect indentation level 8, expected level should be 6. [Indentation]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java:93: 'for' have incorrect indentation level 8, expected level should be 6. [Indentation]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java:94: 'for' child have incorrect indentation level 10, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java:95: 'if' have incorrect indentation level 10, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java:96: 'if' child have incorrect indentation level 12, expected level should be 10. [Indentation]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java:97: 'if' child have incorrect indentation level 12, expected level should be 10. [Indentation]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java:98: 'if rcurly' have incorrect indentation level 10, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java:99: 'for rcurly' have incorrect indentation level 8, expected level should be 6. [Indentation]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java:100: 'for rcurly' have incorrect indentation level 6, expected level should be 4. [Indentation]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java:416:91: ',' is not followed by whitespace. [WhitespaceAfter]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java:47:94: '+' should be on a new line. [OperatorWrap]
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 21.533 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 24, 2017, 10:47 p.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56690/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 10:47 p.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
>
>
> Bugs: AURORA-1819
> https://issues.apache.org/jira/browse/AURORA-1819
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an RFC (without tests) for dynamic reservations proposal. If there is consensus on the approach, I will add tests. This patch was also tested locally and works as expected.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f
> src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 6f2ca35c5d83dde29c24865b4826d4932e96da80
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb
> src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa
> src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca
> src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35
> src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf
> src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 9aa263a9cfae03a9a0c5bc7fe3a1405397d3009c
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java da378e84ee65a658ff2382489d3ab6d5f6451b5f
> src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8
> src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840
> src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f
> src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java dded9c34749cf599d197ed312ffb6bf63b6033f1
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java b8b8edb1a21ba89b8b60f8f8451c8c776fc23ae8
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java e04f6113c43eca4555ee0719f8208d7c4ebb8d61
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777
>
> Diff: https://reviews.apache.org/r/56690/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing
scheduling changes for Dynamic Reservations
Posted by Dmitriy Shirchenko <ca...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/
-----------------------------------------------------------
(Updated Feb. 24, 2017, 10:47 p.m.)
Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
Bugs: AURORA-1819
https://issues.apache.org/jira/browse/AURORA-1819
Repository: aurora
Description
-------
This is an RFC (without tests) for dynamic reservations proposal. If there is consensus on the approach, I will add tests. This patch was also tested locally and works as expected.
Diffs (updated)
-----
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f
src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 6f2ca35c5d83dde29c24865b4826d4932e96da80
src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb
src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa
src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca
src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35
src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce
src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf
src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 9aa263a9cfae03a9a0c5bc7fe3a1405397d3009c
src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java da378e84ee65a658ff2382489d3ab6d5f6451b5f
src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8
src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840
src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f
src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java dded9c34749cf599d197ed312ffb6bf63b6033f1
src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java b8b8edb1a21ba89b8b60f8f8451c8c776fc23ae8
src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java e04f6113c43eca4555ee0719f8208d7c4ebb8d61
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777
Diff: https://reviews.apache.org/r/56690/diff/
Testing
-------
Thanks,
Dmitriy Shirchenko
Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing
scheduling changes for Dynamic Reservations
Posted by Dmitriy Shirchenko <ca...@gmail.com>.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > How does this work with preemption? Should we reject a configuration where tasks can be preempted and reserve resources?
First pass is not to preempt at all for tasks needing a dynamic reservation. Will do a followup patch for that.
And yeah, I will add a config validation to reject a task if TierInfo is both reserved and preemptible.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/test/java/org/apache/aurora/scheduler/TierManagerTest.java, line 27
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646612#file1646612line27>
> >
> > Can you revert the import glob here?
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java, line 295
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646610#file1646610line295>
> >
> > I think a comment here explaining that we do not want to veto offers for reservation reasons because after we reach the timeout we can reserve it.
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java, line 158
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646610#file1646610line158>
> >
> > It sems we are only doing read only operations here, so lets change the sigature to only accept the `StoreProvider` interface for safety.
> >
> > Also, maybe we should rename this to "hasReachedReservationTimeout"?
> >
> > It's not clear what we are "waiting" for in the name.
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java, line 141
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646608#file1646608line141>
> >
> > Lets remove the commented out code here?
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java, line 47
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646607#file1646607line47>
> >
> > I think replacing "reserved task" with "task with resoruced resources" is clearer.
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java, line 34
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646606#file1646606line34>
> >
> > Indentation is off here, I think we want one argument per line (as it was before).
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java, line 420
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646605#file1646605line420>
> >
> > I think we can make this .info and list the task id, offer and operations.
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java, line 418
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646605#file1646605line418>
> >
> > Is there a reason why we need the reserve op to be at index 0?
> >
> > Could we instead just do `.add()`?
> >
> > `List<T>#add(int i, T)` is a smell to me.
I learned that reserve op had to come before launch operation, otherwise Mesos master would not be happy and fail to launch the task.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java, line 407
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646605#file1646605line407>
> >
> > I think we can remove this line here.
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java, line 187
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646605#file1646605line187>
> >
> > This seems like a formatting error. Please revert it.
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java, line 136
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646605#file1646605line136>
> >
> > The comment here and the type don't match.
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line 365
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646604#file1646604line365>
> >
> > You need to log the task id for this line to provide enough information for someone debugging a live cluster.
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/base/JobKeys.java, line 114
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646599#file1646599line114>
> >
> > Whats the reason for the `components.size() == 4` here?
Leftover code. Vanished.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line 122
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646604#file1646604line122>
> >
> > You need to do `this.driverSettings = requireNonNull(driverSettings)` here to guard against null pointers.
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line 358
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646604#file1646604line358>
> >
> > A comment here explaining that we want to label all resources would make this bit clearer.
> >
> > I don't think we do `clearXXX().addAllXXX()` anywhere else in the code.
> >
> > Also does protobuf not provide a `setXXX` for collections?
Yeah, this is the only place where we used to clear resources and readd them. Nothing changes.
There is a setResources method but I believe you end up doing the same thing by just looping over the list and placing them into the correct index [1]
http://mesos.apache.org/api/latest/java/org/apache/mesos/Protos.ExecutorInfo.Builder.html#setResources(int,%20org.apache.mesos.Protos.Resource.Builder)
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, line 201
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646602#file1646602line201>
> >
> > Could you elaborate on what you mean by "cluster maintenance" here? Seems like a copy and paste error from above.
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, line 315
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646602#file1646602line315>
> >
> > This needs javadoc.
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, line 332
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646602#file1646602line332>
> >
> > This equals is not the same as the other POJOs. Look at `UnusedResource` for inspiration.
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, line 270
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646602#file1646602line270>
> >
> > `Optional<List<T>>` is a smell to me.
> >
> > Is it possible to model this just as `List<T>` where the empty list is equal to `Optional.absent()`?
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/TierInfo.java, line 74
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646596#file1646596line74>
> >
> > I noticed from the code below that the mutator methods only act on copies of the teir info.
> >
> > Have you considered having the mutator methods only return copies?
> >
> > This means that the impementations of `unReserve` `reReserve` only return copies.
> >
> > This would be good for performance because we no longer need to return a copy of tier info for every access, and we only do the copying when necessary.
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/TierInfo.java, line 77
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646596#file1646596line77>
> >
> > Could we condense `unReserve()` and `reReserve` to just be `setReservation(bool b)`?
> >
> > I think it is more inline with our style elsewhere for mutators.getTier
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/TierInfo.java, line 109
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646596#file1646596line109>
> >
> > If you accept my suggestion above about making copying implicit in the mutators, this would need to become private.
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/TierManager.java, line 105
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646597#file1646597line105>
> >
> > In line with my comments above, it is important to note this returns a copy for every access which is sort of undesriable considering how frequently we do this in the scheduling loop.
Done.
> On Feb. 24, 2017, 9 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java, line 85
> > <https://reviews.apache.org/r/56690/diff/3/?file=1646603#file1646603line85>
> >
> > If you take my suggestion above to model `resourceList` as `List<T>` I think this code would be cleaned up and be easier to read.
Done.
- Dmitriy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/#review166752
-----------------------------------------------------------
On Feb. 24, 2017, 12:28 a.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56690/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 12:28 a.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
>
>
> Bugs: AURORA-1819
> https://issues.apache.org/jira/browse/AURORA-1819
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an RFC (without tests) for dynamic reservations proposal. If there is consensus on the approach, I will add tests. This patch was also tested locally and works as expected.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f
> src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 6f2ca35c5d83dde29c24865b4826d4932e96da80
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb
> src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa
> src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca
> src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
> src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 0136afb8f6049a6d88cd42b5e3f17d61fcd629d5
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35
> src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf
> src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 9aa263a9cfae03a9a0c5bc7fe3a1405397d3009c
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java da378e84ee65a658ff2382489d3ab6d5f6451b5f
> src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8
> src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840
> src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f
> src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java dded9c34749cf599d197ed312ffb6bf63b6033f1
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java b8b8edb1a21ba89b8b60f8f8451c8c776fc23ae8
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java e04f6113c43eca4555ee0719f8208d7c4ebb8d61
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777
>
> Diff: https://reviews.apache.org/r/56690/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing
scheduling changes for Dynamic Reservations
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/#review166752
-----------------------------------------------------------
How does this work with preemption? Should we reject a configuration where tasks can be preempted and reserve resources?
src/main/java/org/apache/aurora/scheduler/TierInfo.java (line 73)
<https://reviews.apache.org/r/56690/#comment238788>
I noticed from the code below that the mutator methods only act on copies of the teir info.
Have you considered having the mutator methods only return copies?
This means that the impementations of `unReserve` `reReserve` only return copies.
This would be good for performance because we no longer need to return a copy of tier info for every access, and we only do the copying when necessary.
src/main/java/org/apache/aurora/scheduler/TierInfo.java (line 76)
<https://reviews.apache.org/r/56690/#comment238789>
Could we condense `unReserve()` and `reReserve` to just be `setReservation(bool b)`?
I think it is more inline with our style elsewhere for mutators.getTier
src/main/java/org/apache/aurora/scheduler/TierInfo.java (line 108)
<https://reviews.apache.org/r/56690/#comment238790>
If you accept my suggestion above about making copying implicit in the mutators, this would need to become private.
src/main/java/org/apache/aurora/scheduler/TierManager.java (line 105)
<https://reviews.apache.org/r/56690/#comment238791>
In line with my comments above, it is important to note this returns a copy for every access which is sort of undesriable considering how frequently we do this in the scheduling loop.
src/main/java/org/apache/aurora/scheduler/base/JobKeys.java (line 114)
<https://reviews.apache.org/r/56690/#comment238792>
Whats the reason for the `components.size() == 4` here?
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java (line 201)
<https://reviews.apache.org/r/56690/#comment238795>
Could you elaborate on what you mean by "cluster maintenance" here? Seems like a copy and paste error from above.
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java (line 270)
<https://reviews.apache.org/r/56690/#comment238798>
`Optional<List<T>>` is a smell to me.
Is it possible to model this just as `List<T>` where the empty list is equal to `Optional.absent()`?
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java (line 315)
<https://reviews.apache.org/r/56690/#comment238799>
This needs javadoc.
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java (line 332)
<https://reviews.apache.org/r/56690/#comment238800>
This equals is not the same as the other POJOs. Look at `UnusedResource` for inspiration.
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java (line 85)
<https://reviews.apache.org/r/56690/#comment238801>
If you take my suggestion above to model `resourceList` as `List<T>` I think this code would be cleaned up and be easier to read.
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (line 122)
<https://reviews.apache.org/r/56690/#comment238803>
You need to do `this.driverSettings = requireNonNull(driverSettings)` here to guard against null pointers.
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (line 358)
<https://reviews.apache.org/r/56690/#comment238804>
A comment here explaining that we want to label all resources would make this bit clearer.
I don't think we do `clearXXX().addAllXXX()` anywhere else in the code.
Also does protobuf not provide a `setXXX` for collections?
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (line 365)
<https://reviews.apache.org/r/56690/#comment238805>
You need to log the task id for this line to provide enough information for someone debugging a live cluster.
src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java (line 135)
<https://reviews.apache.org/r/56690/#comment238806>
The comment here and the type don't match.
src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java (line 186)
<https://reviews.apache.org/r/56690/#comment238807>
This seems like a formatting error. Please revert it.
src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java (line 405)
<https://reviews.apache.org/r/56690/#comment238808>
I think we can remove this line here.
src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java (line 416)
<https://reviews.apache.org/r/56690/#comment238809>
Is there a reason why we need the reserve op to be at index 0?
Could we instead just do `.add()`?
`List<T>#add(int i, T)` is a smell to me.
src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java (line 418)
<https://reviews.apache.org/r/56690/#comment238810>
I think we can make this .info and list the task id, offer and operations.
src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java (line 34)
<https://reviews.apache.org/r/56690/#comment238811>
Indentation is off here, I think we want one argument per line (as it was before).
src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java (line 47)
<https://reviews.apache.org/r/56690/#comment238813>
I think replacing "reserved task" with "task with resoruced resources" is clearer.
src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java (line 141)
<https://reviews.apache.org/r/56690/#comment238812>
Lets remove the commented out code here?
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java (line 155)
<https://reviews.apache.org/r/56690/#comment238814>
It sems we are only doing read only operations here, so lets change the sigature to only accept the `StoreProvider` interface for safety.
Also, maybe we should rename this to "hasReachedReservationTimeout"?
It's not clear what we are "waiting" for in the name.
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java (line 292)
<https://reviews.apache.org/r/56690/#comment238815>
I think a comment here explaining that we do not want to veto offers for reservation reasons because after we reach the timeout we can reserve it.
src/test/java/org/apache/aurora/scheduler/TierManagerTest.java (line 27)
<https://reviews.apache.org/r/56690/#comment238816>
Can you revert the import glob here?
- Zameer Manji
On Feb. 23, 2017, 4:28 p.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56690/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 4:28 p.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
>
>
> Bugs: AURORA-1819
> https://issues.apache.org/jira/browse/AURORA-1819
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an RFC (without tests) for dynamic reservations proposal. If there is consensus on the approach, I will add tests. This patch was also tested locally and works as expected.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f
> src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 6f2ca35c5d83dde29c24865b4826d4932e96da80
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb
> src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa
> src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca
> src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
> src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 0136afb8f6049a6d88cd42b5e3f17d61fcd629d5
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35
> src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf
> src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 9aa263a9cfae03a9a0c5bc7fe3a1405397d3009c
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java da378e84ee65a658ff2382489d3ab6d5f6451b5f
> src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8
> src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840
> src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f
> src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java dded9c34749cf599d197ed312ffb6bf63b6033f1
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java b8b8edb1a21ba89b8b60f8f8451c8c776fc23ae8
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java e04f6113c43eca4555ee0719f8208d7c4ebb8d61
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777
>
> Diff: https://reviews.apache.org/r/56690/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing
scheduling changes for Dynamic Reservations
Posted by Dmitriy Shirchenko <ca...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/
-----------------------------------------------------------
(Updated Feb. 24, 2017, 12:28 a.m.)
Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
Bugs: AURORA-1819
https://issues.apache.org/jira/browse/AURORA-1819
Repository: aurora
Description
-------
This is an RFC (without tests) for dynamic reservations proposal. If there is consensus on the approach, I will add tests. This patch was also tested locally and works as expected.
Diffs (updated)
-----
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f
src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 6f2ca35c5d83dde29c24865b4826d4932e96da80
src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb
src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa
src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca
src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 0136afb8f6049a6d88cd42b5e3f17d61fcd629d5
src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35
src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce
src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf
src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 9aa263a9cfae03a9a0c5bc7fe3a1405397d3009c
src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java da378e84ee65a658ff2382489d3ab6d5f6451b5f
src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8
src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840
src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f
src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java dded9c34749cf599d197ed312ffb6bf63b6033f1
src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java b8b8edb1a21ba89b8b60f8f8451c8c776fc23ae8
src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java e04f6113c43eca4555ee0719f8208d7c4ebb8d61
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777
Diff: https://reviews.apache.org/r/56690/diff/
Testing
-------
Thanks,
Dmitriy Shirchenko
Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing
scheduling changes for Dynamic Reservations
Posted by Zameer Manji <zm...@apache.org>.
> On Feb. 22, 2017, 3:31 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java
> > Lines 210-228 (patched)
> > <https://reviews.apache.org/r/56690/diff/2/?file=1634094#file1634094line213>
> >
> > This reads like as if there is a more general concept of "soft-constraints" waiting to be discovered. In other words: We want constraints that are lifted once we cannot satisfy them for a certain amount of time. See https://issues.apache.org/jira/browse/AURORA-173 for details.
> >
> > I imagine the TaskAssigner could keep its current behavior and only assign a task if there is no veto for it. It is the responsibility of an out-of-band mechanism to ensure we either don't generate vetos for expired soft-constraints, or we have a way to check if a generated veto is already expired or not.
> >
> > (One very rudimentary implementation could probably look similar to `TaskTimeout.java` but for the `PENDING` state. However there are most likely also other/better ways to do this)
>
> Dmitriy Shirchenko wrote:
> Zameer had thoughts on this.^
>
> Stephan Erb wrote:
> Are those thoughts available in text form somewhere? :-)
From what I understand what you are proposing here, is that we need to generalize our "look for offer until timeout, then take action". We could do that, but I strongly believe there will be cases where some tasks will always "steal" offers from a task that is waiting which will always trigger the action, negating the preference.
I think the problem with AURORA-173 (aka perferences, aka "soft-constraints") is that is incompatible with our current first fit + veto model for matching tasks with offers.
In order to achive this we need some sort of (simple) bin packing algorithm which is a large change and would require some work. The solution could be to use Fenzo (https://github.com/Netflix/Fenzo) or writing our own.
I think it is really out of scope for this task here.
- Zameer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/#review166430
-----------------------------------------------------------
On Feb. 28, 2017, 1:25 p.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56690/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 1:25 p.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
>
>
> Bugs: AURORA-1819
> https://issues.apache.org/jira/browse/AURORA-1819
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an RFC (without tests) for dynamic reservations proposal. If there is consensus on the approach, I will add tests. This patch was also tested locally and works as expected.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f
> src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 6f2ca35c5d83dde29c24865b4826d4932e96da80
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb
> src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa
> src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca
> src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35
> src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf
> src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 9aa263a9cfae03a9a0c5bc7fe3a1405397d3009c
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java da378e84ee65a658ff2382489d3ab6d5f6451b5f
> src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8
> src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840
> src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f
> src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java dded9c34749cf599d197ed312ffb6bf63b6033f1
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java b8b8edb1a21ba89b8b60f8f8451c8c776fc23ae8
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java e04f6113c43eca4555ee0719f8208d7c4ebb8d61
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777
>
>
> Diff: https://reviews.apache.org/r/56690/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing
scheduling changes for Dynamic Reservations
Posted by Stephan Erb <se...@apache.org>.
> On Feb. 23, 2017, 12:31 a.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java
> > Lines 210-228 (patched)
> > <https://reviews.apache.org/r/56690/diff/2/?file=1634094#file1634094line213>
> >
> > This reads like as if there is a more general concept of "soft-constraints" waiting to be discovered. In other words: We want constraints that are lifted once we cannot satisfy them for a certain amount of time. See https://issues.apache.org/jira/browse/AURORA-173 for details.
> >
> > I imagine the TaskAssigner could keep its current behavior and only assign a task if there is no veto for it. It is the responsibility of an out-of-band mechanism to ensure we either don't generate vetos for expired soft-constraints, or we have a way to check if a generated veto is already expired or not.
> >
> > (One very rudimentary implementation could probably look similar to `TaskTimeout.java` but for the `PENDING` state. However there are most likely also other/better ways to do this)
>
> Dmitriy Shirchenko wrote:
> Zameer had thoughts on this.^
Are those thoughts available in text form somewhere? :-)
- Stephan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/#review166430
-----------------------------------------------------------
On Feb. 28, 2017, 10:25 p.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56690/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 10:25 p.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
>
>
> Bugs: AURORA-1819
> https://issues.apache.org/jira/browse/AURORA-1819
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an RFC (without tests) for dynamic reservations proposal. If there is consensus on the approach, I will add tests. This patch was also tested locally and works as expected.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f
> src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 6f2ca35c5d83dde29c24865b4826d4932e96da80
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb
> src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa
> src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca
> src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35
> src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf
> src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 9aa263a9cfae03a9a0c5bc7fe3a1405397d3009c
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java da378e84ee65a658ff2382489d3ab6d5f6451b5f
> src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8
> src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840
> src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f
> src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java dded9c34749cf599d197ed312ffb6bf63b6033f1
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java b8b8edb1a21ba89b8b60f8f8451c8c776fc23ae8
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java e04f6113c43eca4555ee0719f8208d7c4ebb8d61
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777
>
>
> Diff: https://reviews.apache.org/r/56690/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing
scheduling changes for Dynamic Reservations
Posted by Dmitriy Shirchenko <ca...@gmail.com>.
> On Feb. 22, 2017, 11:31 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java, lines 99-100
> > <https://reviews.apache.org/r/56690/diff/2/?file=1634087#file1634087line99>
> >
> > To short-circuit both loops this should probably be a return.
Done.
> On Feb. 22, 2017, 11:31 p.m., Stephan Erb wrote:
> > src/main/resources/org/apache/aurora/scheduler/tiers.json, lines 29-33
> > <https://reviews.apache.org/r/56690/diff/2/?file=1634095#file1634095line29>
> >
> > Shoudn't reservations be always backed by quota to prevent abuse?
we don't use Aurora's built-in quota management, instead, relying on our own so all jobs regardless of tier do not run as production. i can delete this tier as i think these are for reference.
> On Feb. 22, 2017, 11:31 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/TierInfo.java, lines 67-69
> > <https://reviews.apache.org/r/56690/diff/2/?file=1634080#file1634080line67>
> >
> > Copy paste error
Done.
> On Feb. 22, 2017, 11:31 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java, lines 51-63
> > <https://reviews.apache.org/r/56690/diff/2/?file=1634082#file1634082line51>
> >
> > `IAssignedTask` has a `task` which in turn has a jobkey. There should therfore be no need to parse this from the Mesos `TaskInfo`.
Done.
> On Feb. 22, 2017, 11:31 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java, lines 213-231
> > <https://reviews.apache.org/r/56690/diff/2/?file=1634094#file1634094line213>
> >
> > This reads like as if there is a more general concept of "soft-constraints" waiting to be discovered. In other words: We want constraints that are lifted once we cannot satisfy them for a certain amount of time. See https://issues.apache.org/jira/browse/AURORA-173 for details.
> >
> > I imagine the TaskAssigner could keep its current behavior and only assign a task if there is no veto for it. It is the responsibility of an out-of-band mechanism to ensure we either don't generate vetos for expired soft-constraints, or we have a way to check if a generated veto is already expired or not.
> >
> > (One very rudimentary implementation could probably look similar to `TaskTimeout.java` but for the `PENDING` state. However there are most likely also other/better ways to do this)
Zameer had thoughts on this.^
> On Feb. 22, 2017, 11:31 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, lines 405-406
> > <https://reviews.apache.org/r/56690/diff/2/?file=1634086#file1634086line405>
> >
> > Please add a doc string. I may not have completely understood why this is absolutely needed.
> >
> > We should have a very good reason to break the existing interface.
Done.
> On Feb. 22, 2017, 11:31 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java, line 169
> > <https://reviews.apache.org/r/56690/diff/2/?file=1634094#file1634094line169>
> >
> > Please make sure you always use the built-in formatting of the logger methods. Otherwise we will assemble strings in memory, only to be discarded by the logger afterwards :-)
Done.
> On Feb. 22, 2017, 11:31 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java, line 211
> > <https://reviews.apache.org/r/56690/diff/2/?file=1634094#file1634094line211>
> >
> > Same here (and in some other places)
Done. Hopefully I caught all of the places.
> On Feb. 22, 2017, 11:31 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/TierManager.java, lines 100-105
> > <https://reviews.apache.org/r/56690/diff/2/?file=1634081#file1634081line100>
> >
> > In addition to my concerns about the mutable tier config, the `copyOf` might come with a performance tax.
> >
> > `getTier` is on a hot code path and I therefore recently rewrote the `checkArgument` here to only construct the String if the argument is invalid. This yielded a significant perf improvement in our scheduling benchmarks.
Yeah, I could not think of an alternative and am not very happy with this approach myself. Would love to brainstorm if anyone has better ideas.
- Dmitriy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/#review166430
-----------------------------------------------------------
On Feb. 15, 2017, 1:44 a.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56690/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 1:44 a.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
>
>
> Bugs: AURORA-1819
> https://issues.apache.org/jira/browse/AURORA-1819
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an RFC (without tests) for dynamic reservations proposal. If there is consensus on the approach, I will add tests. This patch was also tested locally and works as expected.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f
> src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 6f2ca35c5d83dde29c24865b4826d4932e96da80
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb
> src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa
> src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca
> src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
> src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 0136afb8f6049a6d88cd42b5e3f17d61fcd629d5
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35
> src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf
> src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 9aa263a9cfae03a9a0c5bc7fe3a1405397d3009c
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java da378e84ee65a658ff2382489d3ab6d5f6451b5f
> src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8
> src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840
> src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f
> src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java dded9c34749cf599d197ed312ffb6bf63b6033f1
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java b8b8edb1a21ba89b8b60f8f8451c8c776fc23ae8
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java e04f6113c43eca4555ee0719f8208d7c4ebb8d61
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777
>
> Diff: https://reviews.apache.org/r/56690/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing
scheduling changes for Dynamic Reservations
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/#review166430
-----------------------------------------------------------
This is only a very partial review. My brain was not capable of more today :)
src/main/java/org/apache/aurora/scheduler/TierInfo.java (lines 66 - 68)
<https://reviews.apache.org/r/56690/#comment238363>
Copy paste error
src/main/java/org/apache/aurora/scheduler/TierInfo.java (lines 74 - 81)
<https://reviews.apache.org/r/56690/#comment238365>
A mutable `TierConfig` makes the code very hard to reason about, especially in the context of multi-threading.
Do you see a way to keep the `TierConfig` immutable at runtime?
src/main/java/org/apache/aurora/scheduler/TierManager.java (lines 100 - 105)
<https://reviews.apache.org/r/56690/#comment238367>
In addition to my concerns about the mutable tier config, the `copyOf` might come with a performance tax.
`getTier` is on a hot code path and I therefore recently rewrote the `checkArgument` here to only construct the String if the argument is invalid. This yielded a significant perf improvement in our scheduling benchmarks.
src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java (lines 51 - 63)
<https://reviews.apache.org/r/56690/#comment238369>
`IAssignedTask` has a `task` which in turn has a jobkey. There should therfore be no need to parse this from the Mesos `TaskInfo`.
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java (lines 405 - 406)
<https://reviews.apache.org/r/56690/#comment238370>
Please add a doc string. I may not have completely understood why this is absolutely needed.
We should have a very good reason to break the existing interface.
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java (lines 99 - 100)
<https://reviews.apache.org/r/56690/#comment238371>
To short-circuit both loops this should probably be a return.
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java (line 166)
<https://reviews.apache.org/r/56690/#comment238375>
Please make sure you always use the built-in formatting of the logger methods. Otherwise we will assemble strings in memory, only to be discarded by the logger afterwards :-)
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java (line 208)
<https://reviews.apache.org/r/56690/#comment238376>
Same here (and in some other places)
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java (lines 210 - 228)
<https://reviews.apache.org/r/56690/#comment238384>
This reads like as if there is a more general concept of "soft-constraints" waiting to be discovered. In other words: We want constraints that are lifted once we cannot satisfy them for a certain amount of time. See https://issues.apache.org/jira/browse/AURORA-173 for details.
I imagine the TaskAssigner could keep its current behavior and only assign a task if there is no veto for it. It is the responsibility of an out-of-band mechanism to ensure we either don't generate vetos for expired soft-constraints, or we have a way to check if a generated veto is already expired or not.
(One very rudimentary implementation could probably look similar to `TaskTimeout.java` but for the `PENDING` state. However there are most likely also other/better ways to do this)
src/main/resources/org/apache/aurora/scheduler/tiers.json (lines 29 - 33)
<https://reviews.apache.org/r/56690/#comment238373>
Shoudn't reservations be always backed by quota to prevent abuse?
- Stephan Erb
On Feb. 15, 2017, 2:44 a.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56690/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 2:44 a.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
>
>
> Bugs: AURORA-1819
> https://issues.apache.org/jira/browse/AURORA-1819
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an RFC (without tests) for dynamic reservations proposal. If there is consensus on the approach, I will add tests. This patch was also tested locally and works as expected.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f
> src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 6f2ca35c5d83dde29c24865b4826d4932e96da80
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb
> src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa
> src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca
> src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
> src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 0136afb8f6049a6d88cd42b5e3f17d61fcd629d5
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35
> src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf
> src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 9aa263a9cfae03a9a0c5bc7fe3a1405397d3009c
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java da378e84ee65a658ff2382489d3ab6d5f6451b5f
> src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8
> src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840
> src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f
> src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java dded9c34749cf599d197ed312ffb6bf63b6033f1
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java b8b8edb1a21ba89b8b60f8f8451c8c776fc23ae8
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java e04f6113c43eca4555ee0719f8208d7c4ebb8d61
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777
>
> Diff: https://reviews.apache.org/r/56690/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing
scheduling changes for Dynamic Reservations
Posted by Dmitriy Shirchenko <ca...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 1:44 a.m.)
Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
Bugs: AURORA-1819
https://issues.apache.org/jira/browse/AURORA-1819
Repository: aurora
Description
-------
This is an RFC (without tests) for dynamic reservations proposal. If there is consensus on the approach, I will add tests. This patch was also tested locally and works as expected.
Diffs (updated)
-----
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f
src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 6f2ca35c5d83dde29c24865b4826d4932e96da80
src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb
src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa
src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca
src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 0136afb8f6049a6d88cd42b5e3f17d61fcd629d5
src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35
src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce
src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf
src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 9aa263a9cfae03a9a0c5bc7fe3a1405397d3009c
src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java da378e84ee65a658ff2382489d3ab6d5f6451b5f
src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8
src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840
src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f
src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java dded9c34749cf599d197ed312ffb6bf63b6033f1
src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java b8b8edb1a21ba89b8b60f8f8451c8c776fc23ae8
src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java e04f6113c43eca4555ee0719f8208d7c4ebb8d61
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777
Diff: https://reviews.apache.org/r/56690/diff/
Testing
-------
Thanks,
Dmitriy Shirchenko
Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing
scheduling changes for Dynamic Reservations
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/#review165608
-----------------------------------------------------------
This patch does not apply cleanly against master (0e9c086), do you need to rebase?
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 14, 2017, 11:56 p.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56690/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 11:56 p.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
>
>
> Bugs: AURORA-1819
> https://issues.apache.org/jira/browse/AURORA-1819
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an RFC (without tests) for dynamic reservations proposal. If there is consensus on the approach, I will add tests. This patch was also tested locally and works as expected.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f
> src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java fbd24ea4a58e28c14a343170de137c0e0ae437a2
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb
> src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa
> src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca
> src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
> src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 0136afb8f6049a6d88cd42b5e3f17d61fcd629d5
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java aba73005019c13ac943be9c53ac58c8ce5bfba94
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 3d5c3bd139206e970811aa95bd74b78987bb9cfe
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 2b12696d0218a48d71e89df4d3a38c6bf84c74c7
> src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf
> src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java d751d017522c682a1373932e286ee7b4c447e2aa
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java a030cebea13d92766584643ddda33c50dec7bdbf
> src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8
> src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840
> src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java fb8bd85be93280a9b8366b1398a1fa0a5817bb55
> src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java 2777d7276d55cc0fe75e7470d0dc8182796d67f4
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java 133cd23427485ea329ef10489e5d4a0029cb54cd
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 7dc8c179736fab93ca03e174b16e104ba0118127
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java f8bb25b612ae42748205901dd4b8cfcdedf5b136
>
> Diff: https://reviews.apache.org/r/56690/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>