You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/16 03:40:48 UTC
[GitHub] [incubator-nuttx] a-lunev opened a new pull request #4552: bcm43xxx: abrupt stall of receiving new credits from sdpcm header
a-lunev opened a new pull request #4552:
URL: https://github.com/apache/incubator-nuttx/pull/4552
## Summary
Fixed an issue with abrupt stall of receiving new credits (via sdpcm header) from bcm43362 chip/firmware as soon as a high network traffic started.
## Impact
bcm43xxx driver
Photon board
EMW3162 board
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #4552: bcm43xxx: abrupt stall of receiving new credits from sdpcm header
Posted by GitBox <gi...@apache.org>.
a-lunev commented on a change in pull request #4552:
URL: https://github.com/apache/incubator-nuttx/pull/4552#discussion_r710221145
##########
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdpcm.c
##########
@@ -134,75 +138,133 @@ int bcmf_sdpcm_process_header(FAR struct bcmf_sdio_dev_s *sbus,
int bcmf_sdpcm_readframe(FAR struct bcmf_dev_s *priv)
{
+ struct bcmf_sdpcm_header tmp_hdr;
Review comment:
Hi Alan,
I've moved it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #4552: bcm43xxx: abrupt stall of receiving new credits from sdpcm header
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #4552:
URL: https://github.com/apache/incubator-nuttx/pull/4552#discussion_r710070511
##########
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdpcm.c
##########
@@ -134,75 +138,133 @@ int bcmf_sdpcm_process_header(FAR struct bcmf_sdio_dev_s *sbus,
int bcmf_sdpcm_readframe(FAR struct bcmf_dev_s *priv)
{
+ struct bcmf_sdpcm_header tmp_hdr;
Review comment:
Please move this line to below "struct bcmf_sdpcm_header *header;"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4552: bcm43xxx: abrupt stall of receiving new credits from sdpcm header
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4552:
URL: https://github.com/apache/incubator-nuttx/pull/4552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] a-lunev commented on pull request #4552: bcm43xxx: abrupt stall of receiving new credits from sdpcm header
Posted by GitBox <gi...@apache.org>.
a-lunev commented on pull request #4552:
URL: https://github.com/apache/incubator-nuttx/pull/4552#issuecomment-921044750
MacOS build failed on this step:
`wget --quiet https://dl.espressif.com/dl/xtensa-esp32-elf-gcc8_2_0-esp-2019r2-macos.tar.gz`
I've tested the link locally, it's not broken. It looks like a temporary download error again.
I've force-pushed the PR one more time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org