You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/12 18:43:57 UTC

[GitHub] [arrow] sunchao commented on a change in pull request #8173: ARROW-9980: [Rust] [Parquet] Fix clippy lints

sunchao commented on a change in pull request #8173:
URL: https://github.com/apache/arrow/pull/8173#discussion_r487436938



##########
File path: rust/arrow/src/compute/kernels/aggregate.rs
##########
@@ -121,7 +121,7 @@ mod tests {
     #[test]
     fn test_primitive_array_float_sum() {
         let a = Float64Array::from(vec![1.1, 2.2, 3.3, 4.4, 5.5]);
-        assert_eq!(16.5, sum(&a).unwrap());
+        assert!(16.5 - sum(&a).unwrap() < f64::EPSILON);

Review comment:
       If it is about readability, perhaps we can define a macro like `assert_float_eq` and wrap this logic inside? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org