You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "nadment (via GitHub)" <gi...@apache.org> on 2026/04/27 19:54:43 UTC
[PR] Improvements to Git integration #6914 (hop)
nadment opened a new pull request, #7053:
URL: https://github.com/apache/hop/pull/7053
This PR isn't ready for a merge yet; I'm just looking for feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improvements to Git integration #6914 (hop)
Posted by "nadment (via GitHub)" <gi...@apache.org>.
nadment commented on PR #7053:
URL: https://github.com/apache/hop/pull/7053#issuecomment-4372870676
I need to restore the commit function in GitGuiPlugin which is available in the file explorer for Hop web.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improvements to Git integration #6914 (hop)
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva commented on PR #7053:
URL: https://github.com/apache/hop/pull/7053#issuecomment-4372861747
Yes, if we want to ship this with 2.18 then that will be the best approach, I'd like to start the code freeze and a 2 week hardening/test period as we have done a massive amount of work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improvements to Git integration #6914 (hop)
Posted by "nadment (via GitHub)" <gi...@apache.org>.
nadment commented on PR #7053:
URL: https://github.com/apache/hop/pull/7053#issuecomment-4373850805
If we don't load the two perspectives in web mode (a hard-coded filter in HopGui until the next version) and I restore the menu/toolitem for the commit, it might work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improvements to Git integration #6914 (hop)
Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters commented on PR #7053:
URL: https://github.com/apache/hop/pull/7053#issuecomment-4372461016
It should be easy to disable the 2 new perspectives in Hop Web until we find an alternative. Perhaps we can create a ticket for that separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improvements to Git integration #6914 (hop)
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva merged PR #7053:
URL: https://github.com/apache/hop/pull/7053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improvements to Git integration #6914 (hop)
Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters commented on PR #7053:
URL: https://github.com/apache/hop/pull/7053#issuecomment-4342412602
I really like the 2 new perspectives: commit and git.
Current functionality seems to work.
I like the graph view in the git perspective. I would love to see the "Visual Difference" option as a toolbar button when selecting a commit and a file in the graph tree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improvements to Git integration #6914 (hop)
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva commented on PR #7053:
URL: https://github.com/apache/hop/pull/7053#issuecomment-4373239929
Right it's not as simple as just disabling the new views
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improvements to Git integration #6914 (hop)
Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters commented on PR #7053:
URL: https://github.com/apache/hop/pull/7053#issuecomment-4431436257
I tried to build a local `hop-web` container but it didn't want to work, getting error:
`The origin server did not find a current representation for the target resource or is not willing to disclose that one exists.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improvements to Git integration #6914 (hop)
Posted by "nadment (via GitHub)" <gi...@apache.org>.
nadment commented on PR #7053:
URL: https://github.com/apache/hop/pull/7053#issuecomment-4433950687
I need some help. I have to admit I'm not a big fan of RWT, and it's all a bit over my head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improvements to Git integration #6914 (hop)
Posted by "nadment (via GitHub)" <gi...@apache.org>.
nadment commented on PR #7053:
URL: https://github.com/apache/hop/pull/7053#issuecomment-4345793500
Visual Diff appears as a button in the toolbar
<img width="364" height="223" alt="image" src="https://github.com/user-attachments/assets/f5b760ed-3f72-4a00-9500-a6dbf7c1e395" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improvements to Git integration #6914 (hop)
Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters commented on PR #7053:
URL: https://github.com/apache/hop/pull/7053#issuecomment-4373872694
> If we don't load the two perspectives in web mode (a hard-coded filter in HopGui until the next version) and I restore the menu/toolitem for the commit, it might work
Exactly what I was thinking. Perhaps we can add an option in the annotation driving the perspective plugins for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improvements to Git integration #6914 (hop)
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva commented on PR #7053:
URL: https://github.com/apache/hop/pull/7053#issuecomment-4476715044
Hop web seems to be happy now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improvements to Git integration #6914 (hop)
Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters commented on PR #7053:
URL: https://github.com/apache/hop/pull/7053#issuecomment-4438327481
I have time the coming days to fix Hop Web. I tested the rest of the plugin and it works.
My suggest is to accept this PR and to create tickets to write the docs and fix Hop Web which I'll then pick up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improvements to Git integration #6914 (hop)
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva commented on PR #7053:
URL: https://github.com/apache/hop/pull/7053#issuecomment-4373661809
But is the entire view jface or just specific elements that we could disable for hop web?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org