[jira] Commented: (HBASE-2733) HBASE-2353 broke timestamp replacement on Puts when writeToWAL disabled

["HBase Review Board (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879151#action_12879151 ] 

HBase Review Board commented on HBASE-2733:
-------------------------------------------

Message from: "Todd Lipcon" <to...@cloudera.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/183/
-----------------------------------------------------------

Review request for hbase, stack and Ryan Rawson.


Summary
-------

I broke this in HBASE-2353 so it only worked with writeToWAL==true. This fixes and adds unit test. Also fixes TestGetClosestBefore


This addresses bug HBASE-2733.
    http://issues.apache.org/jira/browse/HBASE-2733


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 06e022c 
  src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 1c1cd4b 

Diff: http://review.hbase.org/r/183/diff


Testing
-------


Thanks,

Todd




> HBASE-2353 broke timestamp replacement on Puts when writeToWAL disabled
> -----------------------------------------------------------------------
>
>                 Key: HBASE-2733
>                 URL: https://issues.apache.org/jira/browse/HBASE-2733
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Blocker
>             Fix For: 0.21.0
>
>
> In refactoring for HBASE-2353, it ended up that updateKeys() was only called on KVs if writeToWAL was set to true. This caused failure of TestGetClosestRowBefore (though the real bug was in put)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.