[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #525: Apply Baseline to iceberg-pig

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #525: Apply Baseline to iceberg-pig
URL: https://github.com/apache/incubator-iceberg/pull/525#discussion_r334289942
 
 

 ##########
 File path: pig/src/main/java/org/apache/iceberg/pig/IcebergStorage.java
 ##########
 @@ -193,80 +166,81 @@ public void setPartitionFilter(Expression partitionFilter) {
 
   @Override
   public List<Expression.OpType> getSupportedExpressionTypes() {
-    LOG.info(format("[%s]: getSupportedExpressionTypes()", signature));
-    return asList(OP_AND, OP_OR, OP_EQ, OP_NE, OP_NOT, OP_GE, OP_GT, OP_LE, OP_LT, OP_BETWEEN, OP_IN, OP_NULL);
+    LOG.info("[{}]: getSupportedExpressionTypes()", signature);
+    return Arrays.asList(OpType.OP_AND, OpType.OP_OR, OpType.OP_EQ, OpType.OP_NE, OpType.OP_NOT, OpType.OP_GE,
+        OpType.OP_GT, OpType.OP_LE, OpType.OP_LT, OpType.OP_BETWEEN, OpType.OP_IN, OpType.OP_NULL);
 
 Review comment:
   Should this be a static `ImmutableList`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org