You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "gus-asf (via GitHub)" <gi...@apache.org> on 2023/05/16 19:49:28 UTC
[GitHub] [lucene] gus-asf opened a new pull request, #12301: Improve error message if codec not found Fixes #12300
gus-asf opened a new pull request, #12301:
URL: https://github.com/apache/lucene/pull/12301
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on a diff in pull request #12301: Improve error message if codec not found Fixes #12300
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on code in PR #12301:
URL: https://github.com/apache/lucene/pull/12301#discussion_r1224919504
##########
lucene/core/src/java/org/apache/lucene/util/NamedSPILoader.java:
##########
@@ -116,9 +116,9 @@ public S lookup(String name) {
+ ((System.getSecurityManager() == null)
Review Comment:
please move this to a separate method `hasSecurityManager() { return System.getSecurityManager() != null; }` with all the `@Suppress*` annotations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Improve error message if codec not found. This fixes #12300 [lucene]
Posted by "gus-asf (via GitHub)" <gi...@apache.org>.
gus-asf commented on PR #12301:
URL: https://github.com/apache/lucene/pull/12301#issuecomment-1791479559
> Thanks @fsparv.
heh whoops wrong browser instance ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Improve error message if codec not found. This fixes #12300 [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12301:
URL: https://github.com/apache/lucene/pull/12301#issuecomment-3413343361
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] fsparv commented on a diff in pull request #12301: Improve error message if codec not found Fixes #12300
Posted by "fsparv (via GitHub)" <gi...@apache.org>.
fsparv commented on code in PR #12301:
URL: https://github.com/apache/lucene/pull/12301#discussion_r1196537557
##########
lucene/core/src/java/org/apache/lucene/util/NamedSPILoader.java:
##########
@@ -110,7 +112,14 @@ public S lookup(String name) {
+ "' does not exist."
+ " You need to add the corresponding JAR file supporting this SPI to your classpath."
+ " The current classpath supports the following names: "
- + availableServices());
+ + availableServices()
+ + ((System.getSecurityManager() == null)
+ ? ""
+ : " We have detected that a security manager is installed so it is also possible "
+ + "that the services file in the jar containing the codec is inaccessible under the current "
+ + "security policy. A FilePermission implying 'read' access to the "
+ + "jar containing the META-INF/services/org.apache.lucene.codec.Codec file is necessary. "
Review Comment:
Ah good point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on a diff in pull request #12301: Improve error message if codec not found Fixes #12300
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on code in PR #12301:
URL: https://github.com/apache/lucene/pull/12301#discussion_r1196017521
##########
lucene/core/src/java/org/apache/lucene/util/NamedSPILoader.java:
##########
@@ -110,7 +112,14 @@ public S lookup(String name) {
+ "' does not exist."
+ " You need to add the corresponding JAR file supporting this SPI to your classpath."
+ " The current classpath supports the following names: "
- + availableServices());
+ + availableServices()
+ + ((System.getSecurityManager() == null)
+ ? ""
+ : " We have detected that a security manager is installed so it is also possible "
+ + "that the services file in the jar containing the codec is inaccessible under the current "
+ + "security policy. A FilePermission implying 'read' access to the "
+ + "jar containing the META-INF/services/org.apache.lucene.codec.Codec file is necessary. "
Review Comment:
Please don't mention "Codec" here, as the NamedSPILoader is used for many more than codecs. Please be generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12301: Improve error message if codec not found Fixes #12300
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12301:
URL: https://github.com/apache/lucene/pull/12301#issuecomment-1585305372
Also note that theres another implementation which should also have a similar message (AnalysisSPILoader).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Improve error message if codec not found. This fixes #12300 [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand commented on PR #12301:
URL: https://github.com/apache/lucene/pull/12301#issuecomment-1790672389
@gus-asf -- looks like this one is close? @uschindler had one more small feeback (isolate the one line that requires suppression to its own method so we don't suppress more than we need to).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Improve error message if codec not found. This fixes #12300 [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand commented on PR #12301:
URL: https://github.com/apache/lucene/pull/12301#issuecomment-1790965114
Thanks @fsparv.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Improve error message if codec not found. This fixes #12300 [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12301:
URL: https://github.com/apache/lucene/pull/12301#issuecomment-1880903041
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Improve error message if codec not found. This fixes #12300 [lucene]
Posted by "fsparv (via GitHub)" <gi...@apache.org>.
fsparv commented on PR #12301:
URL: https://github.com/apache/lucene/pull/12301#issuecomment-1790800773
Hmm, yeah I think I got busy and forgot about this. Will need to review again. Thx for the nudge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org