You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/12/31 11:57:35 UTC
[GitHub] [incubator-iotdb] jixuan1989 opened a new pull request #699:
[IOTDB-397]fix gc log collection in start-server.sh scripts
jixuan1989 opened a new pull request #699: [IOTDB-397]fix gc log collection in start-server.sh scripts
URL: https://github.com/apache/incubator-iotdb/pull/699
Current though we set the printGC parameter, but we forgot to enable it..
i.e., in iotdb-env.sh, though we set:
IOTDB_JMX_OPTS="$IOTDB_JMX_OPTS -Xloggc:${IOTDB_HOME}/gc.log"
, but latter, in line 153 and line 156, we set:
IOTDB_JMX_OPTS="-Diotdb.jmx.local.port=$JMX_PORT"
, which cleans all setting before...
This PR fixes the bug and fix the GC log setting.
using `start-server.sh printgc` to enable the script.
In JDK8, the log looks like:
```
ava HotSpot(TM) 64-Bit Server VM (25.144-b01) for bsd-amd64 JRE (1.8.0_144-b01), built on Jul 21 2017 22:07:42 by "java_re" with gcc 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.11.00)
Memory: 4k page, physical 33554432k(419872k free)
/proc/meminfo:
CommandLine flags: -XX:GCLogFileSize=10485760 -XX:InitialHeapSize=1258291200 -XX:+ManagementServer -XX:MaxHeapSize=8589934592 -XX:NumberOfGCLogFiles=10 -XX:+PrintGC -XX:+PrintGCApplicationStoppedTime -XX:+PrintGCDateStamps -XX:+PrintGCDetails -XX:+PrintGCTimeStamps -XX:+PrintPromotionFailure -XX:+UseCompressedClassPointers -XX:+UseCompressedOops -XX:+UseGCLogFileRotation -XX:+UseParallelGC
2019-12-31T16:51:30.669-0800: 0.135: Total time for which application threads were stopped: 0.0000796 seconds, Stopping threads took: 0.0000073 seconds
2019-12-31T16:51:30.670-0800: 0.135: Total time for which application threads were stopped: 0.0000325 seconds, Stopping threads took: 0.0000049 seconds
2019-12-31T16:51:30.721-0800: 0.187: Total time for which application threads were stopped: 0.0000713 seconds, Stopping threads took: 0.0000064 seconds
2019-12-31T16:51:30.723-0800: 0.189: Total time for which application threads were stopped: 0.0000435 seconds, Stopping threads took: 0.0000046 seconds
2019-12-31T16:51:31.116-0800: 0.582: Total time for which application threads were stopped: 0.0002378 seconds, Stopping threads took: 0.0000095 seconds
2019-12-31T16:51:31.125-0800: 0.591: Total time for which application threads were stopped: 0.0001803 seconds, Stopping threads took: 0.0000126 seconds
2019-12-31T16:51:31.174-0800: 0.640: Total time for which application threads were stopped: 0.0001455 seconds, Stopping threads took: 0.0000089 seconds
2019-12-31T16:51:31.206-0800: 0.672: Total time for which application threads were stopped: 0.0001268 seconds, Stopping threads took: 0.0000094 seconds
2019-12-31T16:51:32.209-0800: 1.675: Total time for which application threads were stopped: 0.0000876 seconds, Stopping threads took: 0.0000262 seconds
2019-12-31T16:51:34.782-0800: 4.248: Total time for which application threads were stopped: 0.0002554 seconds, Stopping threads took: 0.0000235 seconds
2019-12-31T16:53:13.096-0800: 102.562: Total time for which application threads were stopped: 0.0000828 seconds, Stopping threads took: 0.0000195 seconds
2019-12-31T16:53:26.348-0800: 115.813: [GC (Metadata GC Threshold) [PSYoungGen: 172035K->13140K(358400K)] 172035K->13228K(1177600K), 0.0114719 secs] [Times: user=0.03 sys=0.00, real=0.01 secs]
2019-12-31T16:53:26.359-0800: 115.825: [Full GC (Metadata GC Threshold) [PSYoungGen: 13140K->0K(358400K)] [ParOldGen: 88K->12424K(819200K)] 13228K->12424K(1177600K), [Metaspace: 20673K->20673K(1069056K)], 0.0171284 secs] [Times: user=0.06 sys=0.02, real=0.02 secs]
```
In JDK11, the log looks like:
```
[2019-12-31T19:51:23.316-0800][0.694s][11418][13059][info ] GC(0) Pause Young (Concurrent Start) (Metadata GC Threshold) 42M->5M(1200M) 13.686ms
[2019-12-31T19:51:23.316-0800][0.694s][11418][13059][info ] Leaving safepoint region
[2019-12-31T19:51:23.316-0800][0.694s][11418][13059][info ] Total time for which application threads were stopped: 0.0201488 seconds, Stopping threads took: 0.0000139 seconds
[2019-12-31T19:51:23.316-0800][0.695s][11418][19971][info ] GC(1) Concurrent Cycle
[2019-12-31T19:51:23.318-0800][0.696s][11418][13059][info ] Application time: 0.0015954 seconds
[2019-12-31T19:51:23.318-0800][0.696s][11418][13059][info ] Entering safepoint region: CGC_Operation
[2019-12-31T19:51:23.319-0800][0.697s][11418][13059][info ] GC(1) Pause Remark 6M->6M(1200M) 0.835ms
[2019-12-31T19:51:23.319-0800][0.697s][11418][13059][info ] Leaving safepoint region
[2019-12-31T19:51:23.319-0800][0.697s][11418][13059][info ] Total time for which application threads were stopped: 0.0010833 seconds, Stopping threads took: 0.0001294 seconds
[2019-12-31T19:51:23.319-0800][0.697s][11418][13059][info ] Application time: 0.0000895 seconds
[2019-12-31T19:51:23.319-0800][0.697s][11418][13059][info ] Entering safepoint region: CGC_Operation
[2019-12-31T19:51:23.319-0800][0.697s][11418][13059][info ] GC(1) Pause Cleanup 6M->6M(1200M) 0.076ms
[2019-12-31T19:51:23.319-0800][0.698s][11418][13059][info ] Leaving safepoint region
[2019-12-31T19:51:23.319-0800][0.698s][11418][13059][info ] Total time for which application threads were stopped: 0.0001943 seconds, Stopping threads took: 0.0000523 seconds
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 merged pull request #699:
[IOTDB-397]fix gc log collection in start-server.sh scripts
Posted by GitBox <gi...@apache.org>.
jixuan1989 merged pull request #699: [IOTDB-397]fix gc log collection in start-server.sh scripts
URL: https://github.com/apache/incubator-iotdb/pull/699
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services