You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/01/14 11:59:47 UTC
[GitHub] [zookeeper] ztzg commented on a change in pull request #1198: ZOOKEEPER-3670: Clean Up Log Statements for SLF4J
ztzg commented on a change in pull request #1198:
URL: https://github.com/apache/zookeeper/pull/1198#discussion_r557337456
##########
File path: zookeeper-contrib/zookeeper-contrib-loggraph/src/main/java/org/apache/zookeeper/graph/Log4JSource.java
##########
@@ -115,20 +115,16 @@ public Log4JSourceIterator(Log4JSource src, long starttime, long endtime, Filter
}
synchronized public long size() throws IOException {
- if (LOG.isTraceEnabled()) {
- LOG.trace("size() called");
- }
+ LOG.trace("size() called");
Review comment:
Argh! Some of these files are using (8-)tabs for indentation… Still, the indentation of this statement (and a few others) is inconsistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org