You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "ryn5 (via GitHub)" <gi...@apache.org> on 2023/12/18 21:36:33 UTC

[PR] Notice for renaming `none()` to `discard()` [tinkerpop]

ryn5 opened a new pull request, #2408:
URL: https://github.com/apache/tinkerpop/pull/2408

   Provides notice in release notes that none() will be renamed to discard() in 4.0.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Notice for renaming `none()` to `discard()` [tinkerpop]

Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer merged PR #2408:
URL: https://github.com/apache/tinkerpop/pull/2408


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Notice for renaming `none()` to `discard()` [tinkerpop]

Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on code in PR #2408:
URL: https://github.com/apache/tinkerpop/pull/2408#discussion_r1433103260


##########
docs/src/upgrade/release-3.7.x.asciidoc:
##########
@@ -30,9 +30,15 @@ complete list of all the modifications that are part of this release.
 
 === Upgrading for Users
 
+==== Renaming `none()` Step to `discard()`

Review Comment:
   ```suggestion
   ==== Notice: Renaming `none()` step to `discard()` in 4.0.0
   ```



##########
docs/src/upgrade/release-3.7.x.asciidoc:
##########
@@ -30,9 +30,15 @@ complete list of all the modifications that are part of this release.
 
 === Upgrading for Users
 
+==== Renaming `none()` Step to `discard()`
+`none()`, which is primarily used by `iterate()` to discard traversal results in remote contexts, will be renamed to
+`discard()` in release 4.0.0.
 
 === Upgrading for Providers
 
+==== Renaming NoneStep to DiscardStep

Review Comment:
   ```suggestion
   ==== Notice: Renaming NoneStep to DiscardStep in 4.0.0
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Notice for renaming `none()` to `discard()` [tinkerpop]

Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2408:
URL: https://github.com/apache/tinkerpop/pull/2408#issuecomment-1865110862

   VOTE+1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Notice for renaming `none()` to `discard()` [tinkerpop]

Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #2408:
URL: https://github.com/apache/tinkerpop/pull/2408#issuecomment-1863442570

   LGTM VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org