[GitHub] [incubator-dolphinscheduler] chengshiwen commented on a change in pull request #5036: create the interpreter for python command

[GitBox <gi...@apache.org>]

chengshiwen commented on a change in pull request #5036:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/5036#discussion_r592105472



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/PythonCommandExecutor.java
##########
@@ -118,7 +118,7 @@ protected String commandInterpreter() {
         if (StringUtils.isEmpty(pythonHome)){
             return PYTHON;
         }
-        return pythonHome;
+        return pythonHome + "/bin/python";

Review comment:
       By the way, could you modify the incorrect java docs of `private static String getPythonHome(String envPath)` and modify the `$PYTHON_HOME` to `$PYTHON_HOME/bin` in `export PATH`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org