You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/01 01:39:08 UTC
[GitHub] [arrow-datafusion] andygrove opened a new issue, #3317: Remove panics from `datafusion-row` crate
andygrove opened a new issue, #3317:
URL: https://github.com/apache/arrow-datafusion/issues/3317
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
```
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/accessor.rs":234 _ => unreachable!(),
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/jit/reader.rs":139 _ => unimplemented!(),
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/jit/reader.rs":158 _ => unimplemented!(),
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/jit/writer.rs":207 _ => unimplemented!(),
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/layout.rs":160 _ => unreachable!(),
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/reader.rs":71 $NATIVE::from_le_bytes($SELF.data[start..end].try_into().unwrap())
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/reader.rs":84 $NATIVE::from_le_bytes(self.data[start..end].try_into().unwrap())
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/reader.rs":302 .unwrap();
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/reader.rs":310 .unwrap();
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/reader.rs":337 let to = to.as_any_mut().downcast_mut::<BinaryBuilder>().unwrap();
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/reader.rs":350 let to = to.as_any_mut().downcast_mut::<BinaryBuilder>().unwrap();
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/reader.rs":377 _ => unimplemented!(),
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/reader.rs":404 _ => unimplemented!(),
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/writer.rs":304 .unwrap();
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/writer.rs":329 let from = from.as_any().downcast_ref::<Date32Array>().unwrap();
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/writer.rs":339 let from = from.as_any().downcast_ref::<Date64Array>().unwrap();
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/writer.rs":349 let from = from.as_any().downcast_ref::<StringArray>().unwrap();
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/writer.rs":364 let from = from.as_any().downcast_ref::<BinaryArray>().unwrap();
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/writer.rs":397 _ => unimplemented!(),
```
**Describe the solution you'd like**
Use `Result` instead
**Describe alternatives you've considered**
None
**Additional context**
Generated by https://github.com/andygrove/no-need-to-panic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ghubkoa commented on issue #3317: Remove panics from `datafusion-row` crate
Posted by GitBox <gi...@apache.org>.
ghubkoa commented on issue #3317:
URL: https://github.com/apache/arrow-datafusion/issues/3317#issuecomment-1235644189
Can I take a stab at this? Also, is the error type `DataFusionError::Internal` okay to return instead of panic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Review use of panics in `datafusion-row` crate [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #3317: Review use of panics in `datafusion-row` crate
URL: https://github.com/apache/arrow-datafusion/issues/3317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Review use of panics in `datafusion-row` crate [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #3317:
URL: https://github.com/apache/arrow-datafusion/issues/3317#issuecomment-1747666484
Indeed in fact I think datafusion-row was removed a while ago, so this ticket is no longer relevant. Thanks @qrilka
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Review use of panics in `datafusion-row` crate [arrow-datafusion]
Posted by "qrilka (via GitHub)" <gi...@apache.org>.
qrilka commented on issue #3317:
URL: https://github.com/apache/arrow-datafusion/issues/3317#issuecomment-1744642904
In https://github.com/apache/arrow-datafusion/pull/3354#issuecomment-1238662011 it's said that
> `panic` seems acceptable approach for `read_field*` functions.
If that's valid then is this ticket still needed? BTW `no-need-to-panic` seems to be gone...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org