[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3434: VSIX doc changes for 12.6.301 release of NBLS

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #3434:
URL: https://github.com/apache/netbeans/pull/3434#discussion_r780909731



##########
File path: java/java.lsp.server/vscode/README.md
##########
@@ -52,6 +52,11 @@ Apache NetBeans Language Server brings full featured Java development (edit-comp
 * __Test Explorer__ for Java tests results visualization and execution including editor code Lenses.
 * Maven and Gradle support including multi-project projects, subprojects opening and Gradle priming builds.
 
+## Project Explorer
+Project Explorer is introduced, as a counterpart for File Explorer. The Project Explorer follows logical project's structure, groups sources together and in case of Java, simplifies package structure view. In the future, Project Explorer will offer build, execute and build system (gradle/maven) oriented 

Review comment:
       Isn't "counterpart" negative word? "is introduced" belongs to change log, not to readme, I think. The build action & co. have been added meanwhile, haven't they? I am not sure whether people know what _File Explorer_ is? The view is labeled _workspace_ if I have more than one folder open...
   
   _Project Explorer provides an overview of logical project structure, groups sources together and greatly simplifies Java package structure exploration. Project Explorer is an excellent addition to the classical workspace explorer. Use it to build, test, execute and operate your Maven and Gradle Java projects._
   
   ![obrazek](https://user-images.githubusercontent.com/26887752/148724405-cdbff0c7-1040-4305-bf47-8da03ccce2ed.png)
   

##########
File path: java/java.lsp.server/vscode/README.md
##########
@@ -95,13 +111,19 @@ Some refactorings are two steps with like Override method ... where method to be
 * Assign to variable
 * Generate hashCode/equals
 * Generate toString()
-* Change method signature
 * Surround With refactoring
 * For cycle refactoring
 * try-catch refactoring
 * switch() statement
 * while() cycle
 
+## Organize Imports
+It is possible to organize imports in Java classes. There are several settings to help developers to set this feature up to their expectations. Go to VSCode `Preferences | Settings`  and search for _NetBeans_.

Review comment:
       It is _help do something_ - e.g. without _to_. Again what is the message? I'd assume:
   1. organizing imports is possible
   2. it works automatically
   3. it can be configured
   
   right?
   
   _Out of the box support for organizing imports in Java sources is available. It removes unused imports, groups imports by packages and updates your imports whenever a file is saved. In addition to the defaults, there is a rich set of configuration options...._
   
   

##########
File path: java/java.lsp.server/vscode/README.md
##########
@@ -66,6 +71,12 @@ Language Server __Java 8+ ...__ launch configuration supports debugging and runn
     * __Attach to Shared Memory__ is available on Windows in addtion to above mentioned _Attach..._
 
 Default launch configurations provided by Language Server can modified in `launch.json` file using intellisense for available options.
+
+### Run Configurations panel
+Program arguments, VM options, evironment,... can be set in Run Configuration panel, part of Explorer instead of in `launch.json`.

Review comment:
       A (pandemic) typo "e-vironment" ;-)
   
   Overall I am not sure what's the message of this paragraph? Should it be something like:
   
   _Tired of editing `launch.json` configuration file manually? Use Run Configuration Panel instead! It simplifies setting of program arguments, VM options, environment variables & co. The panel is sufficient for all typical use-cases Java programmer faces. Only advanced, expert scenarios may require touching of `launch.json` (which still takes precedence) - stay cool - use Run configuration Panel!_




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists