You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "kosiew (via GitHub)" <gi...@apache.org> on 2026/09/26 09:35:58 UTC
[PR] Keep ClickBench SQL in sync across runners [datafusion]
kosiew opened a new pull request, #25773:
URL: https://github.com/apache/datafusion/pull/25773
## Which issue does this PR close?
- Part of #25031
## Rationale for this change
The extended Q6 benchmark uses different SQL from the other ClickBench runners, while Q15 and Q16 are absent from the SQL-benchmark suite and SQL logic test. These copies can drift again when a query is edited in only one place.
## What changes are included in this PR?
- Remove the URL cast from the extended Q6 benchmark query.
- Add extended Q15 and Q16 SQL benchmarks and corresponding SQL logic test entries.
- Add a parity test for standard and extended ClickBench. It checks that each benchmark query appears in its SQL logic test and that benchmark and legacy query files have matching IDs and normalized SQL.
- Update both SQL logic test headers to identify the mirrored query locations.
## Are these changes tested?
The patch adds `clickbench_parity.rs` and six unit tests covering SQL logic test parsing and SQL normalization. It also adds Q15/Q16 SQL logic test entries with expected value `0`.
The diff does not show test execution, generation of those expected values, or the requested Q6 comparisons in single and partitioned configurations.
## Are there any user-facing changes?
The extended Q6 SQL benchmark now runs without the URL cast. Q15 and Q16 are added to the extended SQL-benchmark suite. The diff does not establish whether removing the cast changes Q6 results. No public API change is shown.
## LLM-generated code disclosure
This PR includes LLM-generated code and comments. All LLM-generated content has been manually reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Keep ClickBench SQL in sync across runners [datafusion]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #25773:
URL: https://github.com/apache/datafusion/pull/25773#issuecomment-5845287948
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/25773?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 82.49%. Comparing base ([`6a792c6`](https://app.codecov.io/gh/apache/datafusion/commit/6a792c671376c6c91f778530220358eb70a91271?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`dfa35f7`](https://app.codecov.io/gh/apache/datafusion/commit/dfa35f7f1ed820e2872d98889767460196f8d204?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #25773 +/- ##
==========================================
- Coverage 82.49% 82.49% -0.01%
==========================================
Files 1140 1140
Lines 438555 438555
Branches 438555 438555
==========================================
- Hits 361803 361793 -10
- Misses 54880 54885 +5
- Partials 21872 21877 +5
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/25773?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Keep ClickBench SQL in sync across runners [datafusion]
Posted by "kosiew (via GitHub)" <gi...@apache.org>.
kosiew commented on PR #25773:
URL: https://github.com/apache/datafusion/pull/25773#issuecomment-6194966321
🚀
@Omega359, @adriangb,
Thank you for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Keep ClickBench SQL in sync across runners [datafusion]
Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on PR #25773:
URL: https://github.com/apache/datafusion/pull/25773#issuecomment-6110763657
I don't know if we need the parity test to be honest - at least for queries vs sql_benchmarks/... At some point this fall I plan on either removing the queries in benchmark/queries or pointing the sql benchmarks at the query files. More likely the latter though I do think there is a few queries where that may be problematic.
Otherwise lgtm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Keep ClickBench SQL in sync across runners [datafusion]
Posted by "kosiew (via GitHub)" <gi...@apache.org>.
kosiew merged PR #25773:
URL: https://github.com/apache/datafusion/pull/25773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org