You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by jc...@apache.org on 2007/10/30 20:17:06 UTC

svn commit: r590278 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/AbstractChoice.java

Author: jcompagner
Date: Tue Oct 30 12:17:06 2007
New Revision: 590278

URL: http://svn.apache.org/viewvc?rev=590278&view=rev
Log:
calling escape markup also for option values (WICKET-642)

Modified:
    wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/AbstractChoice.java

Modified: wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/AbstractChoice.java
URL: http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/AbstractChoice.java?rev=590278&r1=590277&r2=590278&view=diff
==============================================================================
--- wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/AbstractChoice.java (original)
+++ wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/AbstractChoice.java Tue Oct 30 12:17:06 2007
@@ -385,7 +385,7 @@
 			buffer.append("disabled=\"disabled\" ");
 		}
 		buffer.append("value=\"");
-		buffer.append(renderer.getIdValue(choice, index));
+		buffer.append(Strings.escapeMarkup(renderer.getIdValue(choice, index)));
 		buffer.append("\">");
 
 		String display = displayValue;