You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Alex Harui <ah...@adobe.com> on 2013/09/25 17:15:54 UTC
[VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Using VOTE tag to draw attention from PMC'rs with filters on.
Discussion here:
http://mail-archives.apache.org/mod_mbox/flex-dev/201309.mbox/%3c2095F5EBE0
4D59409DFCE91FFCEBF7AF3F526860@EXMBX05.netplexity.local%3e
Voting will be open for 72 hours, but unless some objection comes up in
the next 24, it will probably just happen.
-Alex
RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
Posted by Frédéric THOMAS <we...@hotmail.com>.
Maurice,
Better they ask you, as you fixed it already
RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Maurice Amsellem <ma...@systar.com>.
Following warning from Alex that the code was not "protected", I removed it from the JIRA ticket and sent it privately to Frederic Thomas, who started reviewing it.
You can ask him, or I can send it to you as well to you email address.
Maurice
-----Message d'origine-----
De : Justin Mclean [mailto:justin@classsoftware.com]
Envoyé : jeudi 26 septembre 2013 00:15
À : dev@flex.apache.org
Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
HI,
Can we have access to the source code. I'm not against it's inclusion but it would be nice to have the full picture.
Justin
Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
Posted by Avi Kessner <ak...@gmail.com>.
Very exciting!
brought to you by the letters A, V, and I
and the number 47
On Thu, Sep 26, 2013 at 10:20 PM, Maurice Amsellem <
maurice.amsellem@systar.com> wrote:
> I have sent some comments on the code earlier on this thread (jeu.
> 26/09/2013 02:15 (UTC+1)) , that could be helpful for the review.
>
> Maurice
>
> -----Message d'origine-----
> De : Alex Harui [mailto:aharui@adobe.com]
> Envoyé : jeudi 26 septembre 2013 21:00
> À : dev@flex.apache.org
> Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
> Applications
>
> Hi Maurice,
>
> Thanks! I will review it this evening.
>
> -Alex
>
> On 9/26/13 11:46 AM, "Maurice Amsellem" <ma...@systar.com>
> wrote:
>
> >Hi,
> >
> >I have added the headers, LICENSE and NOTICE and attached the source
> >code attached to the JIRA ticket :
> >https://issues.apache.org/jira/browse/FLEX-33777
> >
> >Regards,
> >
> >Maurice
> >
> >-----Message d'origine-----
> >De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
> >Envoyé : jeudi 26 septembre 2013 19:55
> >À : dev@flex.apache.org
> >Objet : RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
> >Applications
> >
> >Thanks for the clarification.
> >
> >I won't put the @author tag then.
> >
> >Maurice
> >
> >-----Message d'origine-----
> >De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
> >2013 19:45 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
> >donation of Systar DataGrid for Mobile Applications
> >
> >Hi Maurice,
> >
> >Most projects at Apache discourage author tags. There is no official
> >policy prohibiting and Apache Flex has not made any decision.
> >
> >The general reasoning is that there are currently 40+ committers and
> >growing on Apache Flex and if everyone who touched a file added an
> >author tag, eventually, some classes would eventually have a long list of
> tags.
> >Source-control history will always record you as the author, so I'd
> >leave it out if you're ok with that, but either way, it won't affect
> >the donation.
> >
> >-Alex
> >
> >
> >On 9/26/13 10:37 AM, "Maurice Amsellem" <ma...@systar.com>
> >wrote:
> >
> >>I am adding the headers now.
> >>
> >>I noticed some of the components in experimental had mention of the
> >>original author, in addition to Apache Header. (see below).
> >>Should I do the same ?
> >>Eg. @author Maurice Amsellem for SYSTAR (Maurice.amsellem@systar.com).
> >>
> >>
> >>Spark/components/itemRenderers/MenuItemRenderer.mxml
> >>
> >>
> >>//////////////////////////////////////////////////////////////////////
> >>/
> >>//
> >>///////
> >> //
> >> // Licensed to the Apache Software Foundation (ASF) under one or
> more
> >> // contributor license agreements. See the NOTICE file
> distributed
> >>with
> >> // this work for additional information regarding copyright
> ownership.
> >> // The ASF licenses this file to You under the Apache License,
> >>Version
> >>2.0
> >> // (the "License"); you may not use this file except in
> compliance with
> >> // the License. You may obtain a copy of the License at
> >> //
> >> // http://www.apache.org/licenses/LICENSE-2.0
> >> //
> >> // Unless required by applicable law or agreed to in writing,
> software
> >> // distributed under the License is distributed on an "AS IS"
> BASIS,
> >> // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> >>implied.
> >> // See the License for the specific language governing
> permissions and
> >> // limitations under the License.
> >> //
> >>
> >>//////////////////////////////////////////////////////////////////////
> >>/
> >>//
> >>///////
> >> @author Bogdan Dinu (http://www.badu.ro)
> >> -->
> >>
> >>-----Message d'origine-----
> >>De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
> >>Envoyé : jeudi 26 septembre 2013 19:02 À : dev@flex.apache.org Objet :
> >>RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
> >>Applications
> >>
> >>OK, I will add the Apache headers and Notice, and send you the code,
> >>tonight or tomorrow latest...
> >>
> >>Maurice
> >>
> >>-----Message d'origine-----
> >>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
> >>2013 18:43 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
> >>donation of Systar DataGrid for Mobile Applications
> >>
> >>In theory, Systar's legal department should be requiring some form of
> >>header on any code leaving your company. So yes, adding headers is
> >>advised and it would be my preference and probably save time in the
> >>end if you use the Apache headers and NOTICE file.
> >>
> >>IMO, no other changes to the code are required at this time. In fact,
> >>other than the headers, the code should be the same that your officers
> >>signed for in the grant ;-).
> >>
> >>Thanks again for the donation,
> >>-Alex
> >>
> >>On 9/26/13 9:34 AM, "Maurice Amsellem" <ma...@systar.com>
> >>wrote:
> >>
> >>>We also received the acknowledgments. That's good news.
> >>>
> >>>Do I need to make the changes requested before (Apache headers,
> >>>etc..) before sending you the sources ?
> >>>
> >>>Maurice
> >>>
> >>>-----Message d'origine-----
> >>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
> >>>2013 18:31 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
> >>>donation of Systar DataGrid for Mobile Applications
> >>>
> >>>Hi Maurice,
> >>>
> >>>The grant was filed today. Please make a snapshot of the code
> >>>available when you can. You can email the link or source to me
> >>>directly. Any other PMC'rs want to help with the IP review?
> >>>
> >>>-Alex
> >>>
> >>>On 9/25/13 7:56 PM, "Alex Harui" <ah...@adobe.com> wrote:
> >>>
> >>>>Again, none of this is required pre-donation. But if you have the
> >>>>time, that would be great.
> >>>>
> >>>>On 9/25/13 5:32 PM, "Maurice Amsellem" <ma...@systar.com>
> >>>>wrote:
> >>>>
> >>>>>OK.
> >>>>>
> >>>>>-----Message d'origine-----
> >>>>>De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé : jeudi
> >>>>>26 septembre 2013 02:24 À : dev@flex.apache.org Objet : Re:
> >>>>>[VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
> >>>>>Applications
> >>>>>
> >>>>>Hi,
> >>>>>
> >>>>>> 2) 240 and 480 DPI assets are missing. I will add them.
> >>>>>You might need to add 120 and 640 as well as those have been
> >>>>>recently added to the SDK.
> >>>>>
> >>>>>Thanks,
> >>>>>Justin
> >>>>
> >>>
> >>
> >
>
>
RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Maurice Amsellem <ma...@systar.com>.
I have sent some comments on the code earlier on this thread (jeu. 26/09/2013 02:15 (UTC+1)) , that could be helpful for the review.
Maurice
-----Message d'origine-----
De : Alex Harui [mailto:aharui@adobe.com]
Envoyé : jeudi 26 septembre 2013 21:00
À : dev@flex.apache.org
Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
Hi Maurice,
Thanks! I will review it this evening.
-Alex
On 9/26/13 11:46 AM, "Maurice Amsellem" <ma...@systar.com>
wrote:
>Hi,
>
>I have added the headers, LICENSE and NOTICE and attached the source
>code attached to the JIRA ticket :
>https://issues.apache.org/jira/browse/FLEX-33777
>
>Regards,
>
>Maurice
>
>-----Message d'origine-----
>De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
>Envoyé : jeudi 26 septembre 2013 19:55
>À : dev@flex.apache.org
>Objet : RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>Applications
>
>Thanks for the clarification.
>
>I won't put the @author tag then.
>
>Maurice
>
>-----Message d'origine-----
>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
>2013 19:45 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>donation of Systar DataGrid for Mobile Applications
>
>Hi Maurice,
>
>Most projects at Apache discourage author tags. There is no official
>policy prohibiting and Apache Flex has not made any decision.
>
>The general reasoning is that there are currently 40+ committers and
>growing on Apache Flex and if everyone who touched a file added an
>author tag, eventually, some classes would eventually have a long list of tags.
>Source-control history will always record you as the author, so I'd
>leave it out if you're ok with that, but either way, it won't affect
>the donation.
>
>-Alex
>
>
>On 9/26/13 10:37 AM, "Maurice Amsellem" <ma...@systar.com>
>wrote:
>
>>I am adding the headers now.
>>
>>I noticed some of the components in experimental had mention of the
>>original author, in addition to Apache Header. (see below).
>>Should I do the same ?
>>Eg. @author Maurice Amsellem for SYSTAR (Maurice.amsellem@systar.com).
>>
>>
>>Spark/components/itemRenderers/MenuItemRenderer.mxml
>>
>>
>>//////////////////////////////////////////////////////////////////////
>>/
>>//
>>///////
>> //
>> // Licensed to the Apache Software Foundation (ASF) under one or more
>> // contributor license agreements. See the NOTICE file distributed
>>with
>> // this work for additional information regarding copyright ownership.
>> // The ASF licenses this file to You under the Apache License,
>>Version
>>2.0
>> // (the "License"); you may not use this file except in compliance with
>> // the License. You may obtain a copy of the License at
>> //
>> // http://www.apache.org/licenses/LICENSE-2.0
>> //
>> // Unless required by applicable law or agreed to in writing, software
>> // distributed under the License is distributed on an "AS IS" BASIS,
>> // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>>implied.
>> // See the License for the specific language governing permissions and
>> // limitations under the License.
>> //
>>
>>//////////////////////////////////////////////////////////////////////
>>/
>>//
>>///////
>> @author Bogdan Dinu (http://www.badu.ro)
>> -->
>>
>>-----Message d'origine-----
>>De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
>>Envoyé : jeudi 26 septembre 2013 19:02 À : dev@flex.apache.org Objet :
>>RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>>Applications
>>
>>OK, I will add the Apache headers and Notice, and send you the code,
>>tonight or tomorrow latest...
>>
>>Maurice
>>
>>-----Message d'origine-----
>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
>>2013 18:43 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>>donation of Systar DataGrid for Mobile Applications
>>
>>In theory, Systar's legal department should be requiring some form of
>>header on any code leaving your company. So yes, adding headers is
>>advised and it would be my preference and probably save time in the
>>end if you use the Apache headers and NOTICE file.
>>
>>IMO, no other changes to the code are required at this time. In fact,
>>other than the headers, the code should be the same that your officers
>>signed for in the grant ;-).
>>
>>Thanks again for the donation,
>>-Alex
>>
>>On 9/26/13 9:34 AM, "Maurice Amsellem" <ma...@systar.com>
>>wrote:
>>
>>>We also received the acknowledgments. That's good news.
>>>
>>>Do I need to make the changes requested before (Apache headers,
>>>etc..) before sending you the sources ?
>>>
>>>Maurice
>>>
>>>-----Message d'origine-----
>>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
>>>2013 18:31 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>>>donation of Systar DataGrid for Mobile Applications
>>>
>>>Hi Maurice,
>>>
>>>The grant was filed today. Please make a snapshot of the code
>>>available when you can. You can email the link or source to me
>>>directly. Any other PMC'rs want to help with the IP review?
>>>
>>>-Alex
>>>
>>>On 9/25/13 7:56 PM, "Alex Harui" <ah...@adobe.com> wrote:
>>>
>>>>Again, none of this is required pre-donation. But if you have the
>>>>time, that would be great.
>>>>
>>>>On 9/25/13 5:32 PM, "Maurice Amsellem" <ma...@systar.com>
>>>>wrote:
>>>>
>>>>>OK.
>>>>>
>>>>>-----Message d'origine-----
>>>>>De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé : jeudi
>>>>>26 septembre 2013 02:24 À : dev@flex.apache.org Objet : Re:
>>>>>[VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>>>>>Applications
>>>>>
>>>>>Hi,
>>>>>
>>>>>> 2) 240 and 480 DPI assets are missing. I will add them.
>>>>>You might need to add 120 and 640 as well as those have been
>>>>>recently added to the SDK.
>>>>>
>>>>>Thanks,
>>>>>Justin
>>>>
>>>
>>
>
RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Maurice Amsellem <ma...@systar.com>.
Thanks Alex,
I didn't understand what the preferred Apache id was, so I left it blank since it was optional.
"mamsellem" would be fine.
Regarding the pngs, I did them myself.
Maurice
-----Message d'origine-----
De : Alex Harui [mailto:aharui@adobe.com]
Envoyé : vendredi 27 septembre 2013 06:34
À : dev@flex.apache.org
Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
Hi Maurice,
I imported the two files into FB and I ran the Apache file scanner on the folders. Looks good. Here are some things I saw:
1) If you plan to check in the FB project properties like .actionScriptProperties, you will need to insert headers in them as well.
2) Are you planning to check in the sample somewhere? If so, the following files also need headers:
MobileDataGridSample/src/MobileDataGridSample-app.xml
MobileDataGridSample/src/utils/FPSDisplay.as
3) Just want to make sure that the .png files are owned by Systar. If they were created by a third-party, then you may need to verify the agreement with the provider allows donation.
When you check in, the NOTICE and LICENSE files don't get checked in and the portion of the NOTICE file regarding Systar goes in the top-level NOTICE file, where instead of saying "Original Code" you might want to use "com.systar.fx.mobile.components.MobileDataGrid" or whatever you rename it to.
After check-in, please carve out some time for ASDoc and other comments.
I'd also like to see you switch to the {} style used in most of the rest of the framework and fix up some whitespace indentation issues if you have time.
Other than that, I think we're all set. Did you specify an Apache account name on your ICLA? I don't get to see them and I'll need it to finish giving you write-access. It may take the weekend to finish up the write-access process. We'll let you know when your account is ready.
Thanks again for the donation,
-Alex
On 9/26/13 11:59 AM, "Alex Harui" <ah...@adobe.com> wrote:
>Hi Maurice,
>
>Thanks! I will review it this evening.
>
>-Alex
>
>On 9/26/13 11:46 AM, "Maurice Amsellem" <ma...@systar.com>
>wrote:
>
>>Hi,
>>
>>I have added the headers, LICENSE and NOTICE and attached the source
>>code attached to the JIRA ticket :
>>https://issues.apache.org/jira/browse/FLEX-33777
>>
>>Regards,
>>
>>Maurice
>>
>>-----Message d'origine-----
>>De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
>>Envoyé : jeudi 26 septembre 2013 19:55 À : dev@flex.apache.org Objet :
>>RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>>Applications
>>
>>Thanks for the clarification.
>>
>>I won't put the @author tag then.
>>
>>Maurice
>>
>>-----Message d'origine-----
>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
>>2013 19:45 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>>donation of Systar DataGrid for Mobile Applications
>>
>>Hi Maurice,
>>
>>Most projects at Apache discourage author tags. There is no official
>>policy prohibiting and Apache Flex has not made any decision.
>>
>>The general reasoning is that there are currently 40+ committers and
>>growing on Apache Flex and if everyone who touched a file added an
>>author tag, eventually, some classes would eventually have a long list of tags.
>>Source-control history will always record you as the author, so I'd
>>leave it out if you're ok with that, but either way, it won't affect
>>the donation.
>>
>>-Alex
>>
>>
>>On 9/26/13 10:37 AM, "Maurice Amsellem" <ma...@systar.com>
>>wrote:
>>
>>>I am adding the headers now.
>>>
>>>I noticed some of the components in experimental had mention of the
>>>original author, in addition to Apache Header. (see below).
>>>Should I do the same ?
>>>Eg. @author Maurice Amsellem for SYSTAR (Maurice.amsellem@systar.com).
>>>
>>>
>>>Spark/components/itemRenderers/MenuItemRenderer.mxml
>>>
>>>
>>>/////////////////////////////////////////////////////////////////////
>>>//
>>>//
>>>///////
>>> //
>>> // Licensed to the Apache Software Foundation (ASF) under one or more
>>> // contributor license agreements. See the NOTICE file distributed
>>>with
>>> // this work for additional information regarding copyright ownership.
>>> // The ASF licenses this file to You under the Apache License,
>>>Version
>>>2.0
>>> // (the "License"); you may not use this file except in compliance
>>>with
>>> // the License. You may obtain a copy of the License at
>>> //
>>> // http://www.apache.org/licenses/LICENSE-2.0
>>> //
>>> // Unless required by applicable law or agreed to in writing, software
>>> // distributed under the License is distributed on an "AS IS" BASIS,
>>> // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>>>implied.
>>> // See the License for the specific language governing permissions and
>>> // limitations under the License.
>>> //
>>>
>>>/////////////////////////////////////////////////////////////////////
>>>//
>>>//
>>>///////
>>> @author Bogdan Dinu (http://www.badu.ro)
>>> -->
>>>
>>>-----Message d'origine-----
>>>De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
>>>Envoyé : jeudi 26 septembre 2013 19:02 À : dev@flex.apache.org Objet
>>>: RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>>>Applications
>>>
>>>OK, I will add the Apache headers and Notice, and send you the code,
>>>tonight or tomorrow latest...
>>>
>>>Maurice
>>>
>>>-----Message d'origine-----
>>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
>>>2013 18:43 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>>>donation of Systar DataGrid for Mobile Applications
>>>
>>>In theory, Systar's legal department should be requiring some form of
>>>header on any code leaving your company. So yes, adding headers is
>>>advised and it would be my preference and probably save time in the
>>>end if you use the Apache headers and NOTICE file.
>>>
>>>IMO, no other changes to the code are required at this time. In
>>>fact, other than the headers, the code should be the same that your
>>>officers signed for in the grant ;-).
>>>
>>>Thanks again for the donation,
>>>-Alex
>>>
>>>On 9/26/13 9:34 AM, "Maurice Amsellem" <ma...@systar.com>
>>>wrote:
>>>
>>>>We also received the acknowledgments. That's good news.
>>>>
>>>>Do I need to make the changes requested before (Apache headers,
>>>>etc..) before sending you the sources ?
>>>>
>>>>Maurice
>>>>
>>>>-----Message d'origine-----
>>>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26
>>>>septembre
>>>>2013 18:31 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>>>>donation of Systar DataGrid for Mobile Applications
>>>>
>>>>Hi Maurice,
>>>>
>>>>The grant was filed today. Please make a snapshot of the code
>>>>available when you can. You can email the link or source to me
>>>>directly. Any other PMC'rs want to help with the IP review?
>>>>
>>>>-Alex
>>>>
>>>>On 9/25/13 7:56 PM, "Alex Harui" <ah...@adobe.com> wrote:
>>>>
>>>>>Again, none of this is required pre-donation. But if you have the
>>>>>time, that would be great.
>>>>>
>>>>>On 9/25/13 5:32 PM, "Maurice Amsellem"
>>>>><ma...@systar.com>
>>>>>wrote:
>>>>>
>>>>>>OK.
>>>>>>
>>>>>>-----Message d'origine-----
>>>>>>De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé :
>>>>>>jeudi
>>>>>>26 septembre 2013 02:24 À : dev@flex.apache.org Objet : Re:
>>>>>>[VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>>>>>>Applications
>>>>>>
>>>>>>Hi,
>>>>>>
>>>>>>> 2) 240 and 480 DPI assets are missing. I will add them.
>>>>>>You might need to add 120 and 640 as well as those have been
>>>>>>recently added to the SDK.
>>>>>>
>>>>>>Thanks,
>>>>>>Justin
>>>>>
>>>>
>>>
>>
>
RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
Posted by Frédéric THOMAS <we...@hotmail.com>.
There is also the still not renamed but useful SVN-TEST.txt where you can
try your first commit if you want.
-Fred
-----Message d'origine-----
De : Alex Harui [mailto:aharui@adobe.com]
Envoyé : dimanche 29 septembre 2013 16:28
À : dev@flex.apache.org
Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Hi Maurice,
You should have write-access now. Maybe try a practice commit first like a
change to README or NOTICE.
Thanks again for the donation.
-Alex
On 9/27/13 3:24 AM, "Maurice Amsellem" <ma...@systar.com> wrote:
>Cool. I will try to use them.
>
>-----Message d'origine-----
>De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé : vendredi
>27 septembre 2013 11:35 À : dev@flex.apache.org Objet : Re:
>[VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
>
>Hi
>
>> I prefer that the creator of the other project (Justin) does it.
>I'll help out were I can.
>
>> Question: is the ASDOC also published on a web site
>Yes see http://flex.apache.org/asdoc/
>
>> Or is it just for contextual help in FB?
>And that as well.
>
>> I am asking this because the web-based ASDOC could also include full
>>example files, so I could also include the examples there.
>Yes that's possible as well.
>
>Thanks,
>Justin
Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Alex Harui <ah...@adobe.com>.
OK, saw the commit email (hoepfully you did too if you subscribed to
commits@). So feel free to check in the DG
-Alex
On 9/29/13 7:32 AM, "Maurice Amsellem" <ma...@systar.com> wrote:
>Thanks, I will do that.
>
>Maurice
>
>-----Message d'origine-----
>De : Alex Harui [mailto:aharui@adobe.com]
>Envoyé : dimanche 29 septembre 2013 16:28
>À : dev@flex.apache.org
>Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>Applications
>
>Hi Maurice,
>
>You should have write-access now. Maybe try a practice commit first like
>a change to README or NOTICE.
>
>Thanks again for the donation.
>
>-Alex
>
>On 9/27/13 3:24 AM, "Maurice Amsellem" <ma...@systar.com>
>wrote:
>
>>Cool. I will try to use them.
>>
>>-----Message d'origine-----
>>De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé : vendredi
>>27 septembre 2013 11:35 À : dev@flex.apache.org Objet : Re:
>>[VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
>>
>>Hi
>>
>>> I prefer that the creator of the other project (Justin) does it.
>>I'll help out were I can.
>>
>>> Question: is the ASDOC also published on a web site
>>Yes see http://flex.apache.org/asdoc/
>>
>>> Or is it just for contextual help in FB?
>>And that as well.
>>
>>> I am asking this because the web-based ASDOC could also include full
>>>example files, so I could also include the examples there.
>>Yes that's possible as well.
>>
>>Thanks,
>>Justin
>
RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Maurice Amsellem <ma...@systar.com>.
Thanks, I will do that.
Maurice
-----Message d'origine-----
De : Alex Harui [mailto:aharui@adobe.com]
Envoyé : dimanche 29 septembre 2013 16:28
À : dev@flex.apache.org
Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
Hi Maurice,
You should have write-access now. Maybe try a practice commit first like a change to README or NOTICE.
Thanks again for the donation.
-Alex
On 9/27/13 3:24 AM, "Maurice Amsellem" <ma...@systar.com> wrote:
>Cool. I will try to use them.
>
>-----Message d'origine-----
>De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé : vendredi
>27 septembre 2013 11:35 À : dev@flex.apache.org Objet : Re:
>[VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
>
>Hi
>
>> I prefer that the creator of the other project (Justin) does it.
>I'll help out were I can.
>
>> Question: is the ASDOC also published on a web site
>Yes see http://flex.apache.org/asdoc/
>
>> Or is it just for contextual help in FB?
>And that as well.
>
>> I am asking this because the web-based ASDOC could also include full
>>example files, so I could also include the examples there.
>Yes that's possible as well.
>
>Thanks,
>Justin
Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Alex Harui <ah...@adobe.com>.
Hi Maurice,
You should have write-access now. Maybe try a practice commit first like
a change to README or NOTICE.
Thanks again for the donation.
-Alex
On 9/27/13 3:24 AM, "Maurice Amsellem" <ma...@systar.com> wrote:
>Cool. I will try to use them.
>
>-----Message d'origine-----
>De : Justin Mclean [mailto:justin@classsoftware.com]
>Envoyé : vendredi 27 septembre 2013 11:35
>À : dev@flex.apache.org
>Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>Applications
>
>Hi
>
>> I prefer that the creator of the other project (Justin) does it.
>I'll help out were I can.
>
>> Question: is the ASDOC also published on a web site
>Yes see http://flex.apache.org/asdoc/
>
>> Or is it just for contextual help in FB?
>And that as well.
>
>> I am asking this because the web-based ASDOC could also include full
>>example files, so I could also include the examples there.
>Yes that's possible as well.
>
>Thanks,
>Justin
RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Maurice Amsellem <ma...@systar.com>.
Cool. I will try to use them.
-----Message d'origine-----
De : Justin Mclean [mailto:justin@classsoftware.com]
Envoyé : vendredi 27 septembre 2013 11:35
À : dev@flex.apache.org
Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
Hi
> I prefer that the creator of the other project (Justin) does it.
I'll help out were I can.
> Question: is the ASDOC also published on a web site
Yes see http://flex.apache.org/asdoc/
> Or is it just for contextual help in FB?
And that as well.
> I am asking this because the web-based ASDOC could also include full example files, so I could also include the examples there.
Yes that's possible as well.
Thanks,
Justin
Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi
> I prefer that the creator of the other project (Justin) does it.
I'll help out were I can.
> Question: is the ASDOC also published on a web site
Yes see http://flex.apache.org/asdoc/
> Or is it just for contextual help in FB?
And that as well.
> I am asking this because the web-based ASDOC could also include full example files, so I could also include the examples there.
Yes that's possible as well.
Thanks,
Justin
RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Maurice Amsellem <ma...@systar.com>.
Still regarding the examples:
I have seen that classic flex projects have an "asdoc" folder with examples.
In this still supported in new projects, eg. experimental_mobile?
Maurice
-----Message d'origine-----
De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
Envoyé : vendredi 27 septembre 2013 10:17
À : dev@flex.apache.org
Objet : RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
Thanks Om,
I will not check in the FB props, because the code will be integrated to another project (experimentalmobile). I prefer that the creator of the other project (Justin) does it.
Regarding the examples,
I will check them in flex-samples repo.
Question: is the ASDOC also published on a web site (like former http://help.adobe.com/en_US/FlashPlatform/reference/actionscript/3/package-summary.html)
Or is it just for contextual help in FB?
I am asking this because the web-based ASDOC could also include full example files, so I could also include the examples there.
Regards,
Maurice
-----Message d'origine-----
De : omuppi1@gmail.com [mailto:omuppi1@gmail.com] De la part de OmPrakash Muppirala Envoyé : vendredi 27 septembre 2013 06:41 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
On Sep 26, 2013 9:34 PM, "Alex Harui" <ah...@adobe.com> wrote:
>
> Hi Maurice,
>
> I imported the two files into FB and I ran the Apache file scanner on
> the folders. Looks good. Here are some things I saw:
>
> 1) If you plan to check in the FB project properties like
> .actionScriptProperties, you will need to insert headers in them as well.
> 2) Are you planning to check in the sample somewhere? If so, the
> following files also need headers:
> MobileDataGridSample/src/MobileDataGridSample-app.xml
> MobileDataGridSample/src/utils/FPSDisplay.as
The flex-examples repo would be the place for these samples.
Thanks,
Om
> 3) Just want to make sure that the .png files are owned by Systar. If
> they were created by a third-party, then you may need to verify the
> agreement with the provider allows donation.
>
>
> When you check in, the NOTICE and LICENSE files don't get checked in
> and the portion of the NOTICE file regarding Systar goes in the
> top-level NOTICE file, where instead of saying "Original Code" you
> might want to use "com.systar.fx.mobile.components.MobileDataGrid" or
> whatever you rename it to.
>
> After check-in, please carve out some time for ASDoc and other comments.
> I'd also like to see you switch to the {} style used in most of the
> rest of the framework and fix up some whitespace indentation issues if
> you have time.
>
> Other than that, I think we're all set. Did you specify an Apache
> account name on your ICLA? I don't get to see them and I'll need it
> to finish giving you write-access. It may take the weekend to finish
> up the write-access process. We'll let you know when your account is ready.
>
> Thanks again for the donation,
> -Alex
>
> On 9/26/13 11:59 AM, "Alex Harui" <ah...@adobe.com> wrote:
>
> >Hi Maurice,
> >
> >Thanks! I will review it this evening.
> >
> >-Alex
> >
> >On 9/26/13 11:46 AM, "Maurice Amsellem" <ma...@systar.com>
> >wrote:
> >
> >>Hi,
> >>
> >>I have added the headers, LICENSE and NOTICE and attached the source
code
> >>attached to the JIRA ticket :
> >>https://issues.apache.org/jira/browse/FLEX-33777
> >>
> >>Regards,
> >>
> >>Maurice
> >>
> >>-----Message d'origine-----
> >>De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
> >>Envoyé : jeudi 26 septembre 2013 19:55 À : dev@flex.apache.org Objet
> >>: RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
> >>Applications
> >>
> >>Thanks for the clarification.
> >>
> >>I won't put the @author tag then.
> >>
> >>Maurice
> >>
> >>-----Message d'origine-----
> >>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26
> >>septembre
> >>2013 19:45 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
> >>donation of Systar DataGrid for Mobile Applications
> >>
> >>Hi Maurice,
> >>
> >>Most projects at Apache discourage author tags. There is no
> >>official policy prohibiting and Apache Flex has not made any decision.
> >>
> >>The general reasoning is that there are currently 40+ committers and
> >>growing on Apache Flex and if everyone who touched a file added an
author
> >>tag, eventually, some classes would eventually have a long list of tags.
> >>Source-control history will always record you as the author, so I'd
leave
> >>it out if you're ok with that, but either way, it won't affect the
> >>donation.
> >>
> >>-Alex
> >>
> >>
> >>On 9/26/13 10:37 AM, "Maurice Amsellem"
> >><ma...@systar.com>
> >>wrote:
> >>
> >>>I am adding the headers now.
> >>>
> >>>I noticed some of the components in experimental had mention of the
> >>>original author, in addition to Apache Header. (see below).
> >>>Should I do the same ?
> >>>Eg. @author Maurice Amsellem for SYSTAR (Maurice.amsellem@systar.com).
> >>>
> >>>
> >>>Spark/components/itemRenderers/MenuItemRenderer.mxml
> >>>
> >>>
> >>>///////////////////////////////////////////////////////////////////
> >>>////
> >>>//
> >>>///////
> >>> //
> >>> // Licensed to the Apache Software Foundation (ASF) under one
> >>>or
more
> >>> // contributor license agreements. See the NOTICE file
distributed
> >>>with
> >>> // this work for additional information regarding copyright
ownership.
> >>> // The ASF licenses this file to You under the Apache
> >>>License, Version
> >>>2.0
> >>> // (the "License"); you may not use this file except in
compliance
> >>>with
> >>> // the License. You may obtain a copy of the License at
> >>> //
> >>> // http://www.apache.org/licenses/LICENSE-2.0
> >>> //
> >>> // Unless required by applicable law or agreed to in writing,
software
> >>> // distributed under the License is distributed on an "AS IS"
BASIS,
> >>> // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
> >>> express
or
> >>>implied.
> >>> // See the License for the specific language governing
permissions and
> >>> // limitations under the License.
> >>> //
> >>>
> >>>///////////////////////////////////////////////////////////////////
> >>>////
> >>>//
> >>>///////
> >>> @author Bogdan Dinu (http://www.badu.ro)
> >>> -->
> >>>
> >>>-----Message d'origine-----
> >>>De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
> >>>Envoyé : jeudi 26 septembre 2013 19:02 À : dev@flex.apache.org
> >>>Objet : RE: [VOTE][LAZY] Accept donation of Systar DataGrid for
> >>>Mobile Applications
> >>>
> >>>OK, I will add the Apache headers and Notice, and send you the
> >>>code, tonight or tomorrow latest...
> >>>
> >>>Maurice
> >>>
> >>>-----Message d'origine-----
> >>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26
> >>>septembre
> >>>2013 18:43 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
> >>>donation of Systar DataGrid for Mobile Applications
> >>>
> >>>In theory, Systar's legal department should be requiring some form
> >>>of header on any code leaving your company. So yes, adding headers
> >>>is advised and it would be my preference and probably save time in
> >>>the end if you use the Apache headers and NOTICE file.
> >>>
> >>>IMO, no other changes to the code are required at this time. In
> >>>fact, other than the headers, the code should be the same that your
> >>>officers signed for in the grant ;-).
> >>>
> >>>Thanks again for the donation,
> >>>-Alex
> >>>
> >>>On 9/26/13 9:34 AM, "Maurice Amsellem"
> >>><ma...@systar.com>
> >>>wrote:
> >>>
> >>>>We also received the acknowledgments. That's good news.
> >>>>
> >>>>Do I need to make the changes requested before (Apache headers,
> >>>>etc..) before sending you the sources ?
> >>>>
> >>>>Maurice
> >>>>
> >>>>-----Message d'origine-----
> >>>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26
> >>>>septembre
> >>>>2013 18:31 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
> >>>>donation of Systar DataGrid for Mobile Applications
> >>>>
> >>>>Hi Maurice,
> >>>>
> >>>>The grant was filed today. Please make a snapshot of the code
> >>>>available when you can. You can email the link or source to me
> >>>>directly. Any other PMC'rs want to help with the IP review?
> >>>>
> >>>>-Alex
> >>>>
> >>>>On 9/25/13 7:56 PM, "Alex Harui" <ah...@adobe.com> wrote:
> >>>>
> >>>>>Again, none of this is required pre-donation. But if you have
> >>>>>the time, that would be great.
> >>>>>
> >>>>>On 9/25/13 5:32 PM, "Maurice Amsellem"
> >>>>><ma...@systar.com>
> >>>>>wrote:
> >>>>>
> >>>>>>OK.
> >>>>>>
> >>>>>>-----Message d'origine-----
> >>>>>>De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé :
> >>>>>>jeudi
> >>>>>>26 septembre 2013 02:24 À : dev@flex.apache.org Objet : Re:
> >>>>>>[VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
> >>>>>>Applications
> >>>>>>
> >>>>>>Hi,
> >>>>>>
> >>>>>>> 2) 240 and 480 DPI assets are missing. I will add them.
> >>>>>>You might need to add 120 and 640 as well as those have been
> >>>>>>recently added to the SDK.
> >>>>>>
> >>>>>>Thanks,
> >>>>>>Justin
> >>>>>
> >>>>
> >>>
> >>
> >
>
RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Maurice Amsellem <ma...@systar.com>.
Thanks Om,
I will not check in the FB props, because the code will be integrated to another project (experimentalmobile). I prefer that the creator of the other project (Justin) does it.
Regarding the examples,
I will check them in flex-samples repo.
Question: is the ASDOC also published on a web site (like former http://help.adobe.com/en_US/FlashPlatform/reference/actionscript/3/package-summary.html)
Or is it just for contextual help in FB?
I am asking this because the web-based ASDOC could also include full example files, so I could also include the examples there.
Regards,
Maurice
-----Message d'origine-----
De : omuppi1@gmail.com [mailto:omuppi1@gmail.com] De la part de OmPrakash Muppirala
Envoyé : vendredi 27 septembre 2013 06:41
À : dev@flex.apache.org
Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
On Sep 26, 2013 9:34 PM, "Alex Harui" <ah...@adobe.com> wrote:
>
> Hi Maurice,
>
> I imported the two files into FB and I ran the Apache file scanner on
> the folders. Looks good. Here are some things I saw:
>
> 1) If you plan to check in the FB project properties like
> .actionScriptProperties, you will need to insert headers in them as well.
> 2) Are you planning to check in the sample somewhere? If so, the
> following files also need headers:
> MobileDataGridSample/src/MobileDataGridSample-app.xml
> MobileDataGridSample/src/utils/FPSDisplay.as
The flex-examples repo would be the place for these samples.
Thanks,
Om
> 3) Just want to make sure that the .png files are owned by Systar. If
> they were created by a third-party, then you may need to verify the
> agreement with the provider allows donation.
>
>
> When you check in, the NOTICE and LICENSE files don't get checked in
> and the portion of the NOTICE file regarding Systar goes in the
> top-level NOTICE file, where instead of saying "Original Code" you
> might want to use "com.systar.fx.mobile.components.MobileDataGrid" or
> whatever you rename it to.
>
> After check-in, please carve out some time for ASDoc and other comments.
> I'd also like to see you switch to the {} style used in most of the
> rest of the framework and fix up some whitespace indentation issues if
> you have time.
>
> Other than that, I think we're all set. Did you specify an Apache
> account name on your ICLA? I don't get to see them and I'll need it
> to finish giving you write-access. It may take the weekend to finish
> up the write-access process. We'll let you know when your account is ready.
>
> Thanks again for the donation,
> -Alex
>
> On 9/26/13 11:59 AM, "Alex Harui" <ah...@adobe.com> wrote:
>
> >Hi Maurice,
> >
> >Thanks! I will review it this evening.
> >
> >-Alex
> >
> >On 9/26/13 11:46 AM, "Maurice Amsellem" <ma...@systar.com>
> >wrote:
> >
> >>Hi,
> >>
> >>I have added the headers, LICENSE and NOTICE and attached the source
code
> >>attached to the JIRA ticket :
> >>https://issues.apache.org/jira/browse/FLEX-33777
> >>
> >>Regards,
> >>
> >>Maurice
> >>
> >>-----Message d'origine-----
> >>De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
> >>Envoyé : jeudi 26 septembre 2013 19:55 À : dev@flex.apache.org Objet
> >>: RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
> >>Applications
> >>
> >>Thanks for the clarification.
> >>
> >>I won't put the @author tag then.
> >>
> >>Maurice
> >>
> >>-----Message d'origine-----
> >>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26
> >>septembre
> >>2013 19:45 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
> >>donation of Systar DataGrid for Mobile Applications
> >>
> >>Hi Maurice,
> >>
> >>Most projects at Apache discourage author tags. There is no
> >>official policy prohibiting and Apache Flex has not made any decision.
> >>
> >>The general reasoning is that there are currently 40+ committers and
> >>growing on Apache Flex and if everyone who touched a file added an
author
> >>tag, eventually, some classes would eventually have a long list of tags.
> >>Source-control history will always record you as the author, so I'd
leave
> >>it out if you're ok with that, but either way, it won't affect the
> >>donation.
> >>
> >>-Alex
> >>
> >>
> >>On 9/26/13 10:37 AM, "Maurice Amsellem"
> >><ma...@systar.com>
> >>wrote:
> >>
> >>>I am adding the headers now.
> >>>
> >>>I noticed some of the components in experimental had mention of the
> >>>original author, in addition to Apache Header. (see below).
> >>>Should I do the same ?
> >>>Eg. @author Maurice Amsellem for SYSTAR (Maurice.amsellem@systar.com).
> >>>
> >>>
> >>>Spark/components/itemRenderers/MenuItemRenderer.mxml
> >>>
> >>>
> >>>///////////////////////////////////////////////////////////////////
> >>>////
> >>>//
> >>>///////
> >>> //
> >>> // Licensed to the Apache Software Foundation (ASF) under one
> >>>or
more
> >>> // contributor license agreements. See the NOTICE file
distributed
> >>>with
> >>> // this work for additional information regarding copyright
ownership.
> >>> // The ASF licenses this file to You under the Apache
> >>>License, Version
> >>>2.0
> >>> // (the "License"); you may not use this file except in
compliance
> >>>with
> >>> // the License. You may obtain a copy of the License at
> >>> //
> >>> // http://www.apache.org/licenses/LICENSE-2.0
> >>> //
> >>> // Unless required by applicable law or agreed to in writing,
software
> >>> // distributed under the License is distributed on an "AS IS"
BASIS,
> >>> // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
> >>> express
or
> >>>implied.
> >>> // See the License for the specific language governing
permissions and
> >>> // limitations under the License.
> >>> //
> >>>
> >>>///////////////////////////////////////////////////////////////////
> >>>////
> >>>//
> >>>///////
> >>> @author Bogdan Dinu (http://www.badu.ro)
> >>> -->
> >>>
> >>>-----Message d'origine-----
> >>>De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
> >>>Envoyé : jeudi 26 septembre 2013 19:02 À : dev@flex.apache.org
> >>>Objet : RE: [VOTE][LAZY] Accept donation of Systar DataGrid for
> >>>Mobile Applications
> >>>
> >>>OK, I will add the Apache headers and Notice, and send you the
> >>>code, tonight or tomorrow latest...
> >>>
> >>>Maurice
> >>>
> >>>-----Message d'origine-----
> >>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26
> >>>septembre
> >>>2013 18:43 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
> >>>donation of Systar DataGrid for Mobile Applications
> >>>
> >>>In theory, Systar's legal department should be requiring some form
> >>>of header on any code leaving your company. So yes, adding headers
> >>>is advised and it would be my preference and probably save time in
> >>>the end if you use the Apache headers and NOTICE file.
> >>>
> >>>IMO, no other changes to the code are required at this time. In
> >>>fact, other than the headers, the code should be the same that your
> >>>officers signed for in the grant ;-).
> >>>
> >>>Thanks again for the donation,
> >>>-Alex
> >>>
> >>>On 9/26/13 9:34 AM, "Maurice Amsellem"
> >>><ma...@systar.com>
> >>>wrote:
> >>>
> >>>>We also received the acknowledgments. That's good news.
> >>>>
> >>>>Do I need to make the changes requested before (Apache headers,
> >>>>etc..) before sending you the sources ?
> >>>>
> >>>>Maurice
> >>>>
> >>>>-----Message d'origine-----
> >>>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26
> >>>>septembre
> >>>>2013 18:31 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
> >>>>donation of Systar DataGrid for Mobile Applications
> >>>>
> >>>>Hi Maurice,
> >>>>
> >>>>The grant was filed today. Please make a snapshot of the code
> >>>>available when you can. You can email the link or source to me
> >>>>directly. Any other PMC'rs want to help with the IP review?
> >>>>
> >>>>-Alex
> >>>>
> >>>>On 9/25/13 7:56 PM, "Alex Harui" <ah...@adobe.com> wrote:
> >>>>
> >>>>>Again, none of this is required pre-donation. But if you have
> >>>>>the time, that would be great.
> >>>>>
> >>>>>On 9/25/13 5:32 PM, "Maurice Amsellem"
> >>>>><ma...@systar.com>
> >>>>>wrote:
> >>>>>
> >>>>>>OK.
> >>>>>>
> >>>>>>-----Message d'origine-----
> >>>>>>De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé :
> >>>>>>jeudi
> >>>>>>26 septembre 2013 02:24 À : dev@flex.apache.org Objet : Re:
> >>>>>>[VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
> >>>>>>Applications
> >>>>>>
> >>>>>>Hi,
> >>>>>>
> >>>>>>> 2) 240 and 480 DPI assets are missing. I will add them.
> >>>>>>You might need to add 120 and 640 as well as those have been
> >>>>>>recently added to the SDK.
> >>>>>>
> >>>>>>Thanks,
> >>>>>>Justin
> >>>>>
> >>>>
> >>>
> >>
> >
>
Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
Posted by OmPrakash Muppirala <bi...@gmail.com>.
On Sep 26, 2013 9:34 PM, "Alex Harui" <ah...@adobe.com> wrote:
>
> Hi Maurice,
>
> I imported the two files into FB and I ran the Apache file scanner on the
> folders. Looks good. Here are some things I saw:
>
> 1) If you plan to check in the FB project properties like
> .actionScriptProperties, you will need to insert headers in them as well.
> 2) Are you planning to check in the sample somewhere? If so, the
> following files also need headers:
> MobileDataGridSample/src/MobileDataGridSample-app.xml
> MobileDataGridSample/src/utils/FPSDisplay.as
The flex-examples repo would be the place for these samples.
Thanks,
Om
> 3) Just want to make sure that the .png files are owned by Systar. If
> they were created by a third-party, then you may need to verify the
> agreement with the provider allows donation.
>
>
> When you check in, the NOTICE and LICENSE files don't get checked in and
> the portion of the NOTICE file regarding Systar goes in the top-level
> NOTICE file, where instead of saying "Original Code" you might want to use
> "com.systar.fx.mobile.components.MobileDataGrid" or whatever you rename it
> to.
>
> After check-in, please carve out some time for ASDoc and other comments.
> I'd also like to see you switch to the {} style used in most of the rest
> of the framework and fix up some whitespace indentation issues if you have
> time.
>
> Other than that, I think we're all set. Did you specify an Apache account
> name on your ICLA? I don't get to see them and I'll need it to finish
> giving you write-access. It may take the weekend to finish up the
> write-access process. We'll let you know when your account is ready.
>
> Thanks again for the donation,
> -Alex
>
> On 9/26/13 11:59 AM, "Alex Harui" <ah...@adobe.com> wrote:
>
> >Hi Maurice,
> >
> >Thanks! I will review it this evening.
> >
> >-Alex
> >
> >On 9/26/13 11:46 AM, "Maurice Amsellem" <ma...@systar.com>
> >wrote:
> >
> >>Hi,
> >>
> >>I have added the headers, LICENSE and NOTICE and attached the source
code
> >>attached to the JIRA ticket :
> >>https://issues.apache.org/jira/browse/FLEX-33777
> >>
> >>Regards,
> >>
> >>Maurice
> >>
> >>-----Message d'origine-----
> >>De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
> >>Envoyé : jeudi 26 septembre 2013 19:55
> >>À : dev@flex.apache.org
> >>Objet : RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
> >>Applications
> >>
> >>Thanks for the clarification.
> >>
> >>I won't put the @author tag then.
> >>
> >>Maurice
> >>
> >>-----Message d'origine-----
> >>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
> >>2013 19:45 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
> >>donation of Systar DataGrid for Mobile Applications
> >>
> >>Hi Maurice,
> >>
> >>Most projects at Apache discourage author tags. There is no official
> >>policy prohibiting and Apache Flex has not made any decision.
> >>
> >>The general reasoning is that there are currently 40+ committers and
> >>growing on Apache Flex and if everyone who touched a file added an
author
> >>tag, eventually, some classes would eventually have a long list of tags.
> >>Source-control history will always record you as the author, so I'd
leave
> >>it out if you're ok with that, but either way, it won't affect the
> >>donation.
> >>
> >>-Alex
> >>
> >>
> >>On 9/26/13 10:37 AM, "Maurice Amsellem" <ma...@systar.com>
> >>wrote:
> >>
> >>>I am adding the headers now.
> >>>
> >>>I noticed some of the components in experimental had mention of the
> >>>original author, in addition to Apache Header. (see below).
> >>>Should I do the same ?
> >>>Eg. @author Maurice Amsellem for SYSTAR (Maurice.amsellem@systar.com).
> >>>
> >>>
> >>>Spark/components/itemRenderers/MenuItemRenderer.mxml
> >>>
> >>>
> >>>///////////////////////////////////////////////////////////////////////
> >>>//
> >>>///////
> >>> //
> >>> // Licensed to the Apache Software Foundation (ASF) under one or
more
> >>> // contributor license agreements. See the NOTICE file
distributed
> >>>with
> >>> // this work for additional information regarding copyright
ownership.
> >>> // The ASF licenses this file to You under the Apache License,
> >>>Version
> >>>2.0
> >>> // (the "License"); you may not use this file except in
compliance
> >>>with
> >>> // the License. You may obtain a copy of the License at
> >>> //
> >>> // http://www.apache.org/licenses/LICENSE-2.0
> >>> //
> >>> // Unless required by applicable law or agreed to in writing,
software
> >>> // distributed under the License is distributed on an "AS IS"
BASIS,
> >>> // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
or
> >>>implied.
> >>> // See the License for the specific language governing
permissions and
> >>> // limitations under the License.
> >>> //
> >>>
> >>>///////////////////////////////////////////////////////////////////////
> >>>//
> >>>///////
> >>> @author Bogdan Dinu (http://www.badu.ro)
> >>> -->
> >>>
> >>>-----Message d'origine-----
> >>>De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
> >>>Envoyé : jeudi 26 septembre 2013 19:02
> >>>À : dev@flex.apache.org
> >>>Objet : RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
> >>>Applications
> >>>
> >>>OK, I will add the Apache headers and Notice, and send you the code,
> >>>tonight or tomorrow latest...
> >>>
> >>>Maurice
> >>>
> >>>-----Message d'origine-----
> >>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
> >>>2013 18:43 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
> >>>donation of Systar DataGrid for Mobile Applications
> >>>
> >>>In theory, Systar's legal department should be requiring some form of
> >>>header on any code leaving your company. So yes, adding headers is
> >>>advised and it would be my preference and probably save time in the end
> >>>if you use the Apache headers and NOTICE file.
> >>>
> >>>IMO, no other changes to the code are required at this time. In fact,
> >>>other than the headers, the code should be the same that your officers
> >>>signed for in the grant ;-).
> >>>
> >>>Thanks again for the donation,
> >>>-Alex
> >>>
> >>>On 9/26/13 9:34 AM, "Maurice Amsellem" <ma...@systar.com>
> >>>wrote:
> >>>
> >>>>We also received the acknowledgments. That's good news.
> >>>>
> >>>>Do I need to make the changes requested before (Apache headers, etc..)
> >>>>before sending you the sources ?
> >>>>
> >>>>Maurice
> >>>>
> >>>>-----Message d'origine-----
> >>>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
> >>>>2013 18:31 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
> >>>>donation of Systar DataGrid for Mobile Applications
> >>>>
> >>>>Hi Maurice,
> >>>>
> >>>>The grant was filed today. Please make a snapshot of the code
> >>>>available when you can. You can email the link or source to me
> >>>>directly. Any other PMC'rs want to help with the IP review?
> >>>>
> >>>>-Alex
> >>>>
> >>>>On 9/25/13 7:56 PM, "Alex Harui" <ah...@adobe.com> wrote:
> >>>>
> >>>>>Again, none of this is required pre-donation. But if you have the
> >>>>>time, that would be great.
> >>>>>
> >>>>>On 9/25/13 5:32 PM, "Maurice Amsellem" <ma...@systar.com>
> >>>>>wrote:
> >>>>>
> >>>>>>OK.
> >>>>>>
> >>>>>>-----Message d'origine-----
> >>>>>>De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé : jeudi
> >>>>>>26 septembre 2013 02:24 À : dev@flex.apache.org Objet : Re:
> >>>>>>[VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
> >>>>>>Applications
> >>>>>>
> >>>>>>Hi,
> >>>>>>
> >>>>>>> 2) 240 and 480 DPI assets are missing. I will add them.
> >>>>>>You might need to add 120 and 640 as well as those have been
> >>>>>>recently added to the SDK.
> >>>>>>
> >>>>>>Thanks,
> >>>>>>Justin
> >>>>>
> >>>>
> >>>
> >>
> >
>
Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Alex Harui <ah...@adobe.com>.
Hi Maurice,
I imported the two files into FB and I ran the Apache file scanner on the
folders. Looks good. Here are some things I saw:
1) If you plan to check in the FB project properties like
.actionScriptProperties, you will need to insert headers in them as well.
2) Are you planning to check in the sample somewhere? If so, the
following files also need headers:
MobileDataGridSample/src/MobileDataGridSample-app.xml
MobileDataGridSample/src/utils/FPSDisplay.as
3) Just want to make sure that the .png files are owned by Systar. If
they were created by a third-party, then you may need to verify the
agreement with the provider allows donation.
When you check in, the NOTICE and LICENSE files don't get checked in and
the portion of the NOTICE file regarding Systar goes in the top-level
NOTICE file, where instead of saying "Original Code" you might want to use
"com.systar.fx.mobile.components.MobileDataGrid" or whatever you rename it
to.
After check-in, please carve out some time for ASDoc and other comments.
I'd also like to see you switch to the {} style used in most of the rest
of the framework and fix up some whitespace indentation issues if you have
time.
Other than that, I think we're all set. Did you specify an Apache account
name on your ICLA? I don't get to see them and I'll need it to finish
giving you write-access. It may take the weekend to finish up the
write-access process. We'll let you know when your account is ready.
Thanks again for the donation,
-Alex
On 9/26/13 11:59 AM, "Alex Harui" <ah...@adobe.com> wrote:
>Hi Maurice,
>
>Thanks! I will review it this evening.
>
>-Alex
>
>On 9/26/13 11:46 AM, "Maurice Amsellem" <ma...@systar.com>
>wrote:
>
>>Hi,
>>
>>I have added the headers, LICENSE and NOTICE and attached the source code
>>attached to the JIRA ticket :
>>https://issues.apache.org/jira/browse/FLEX-33777
>>
>>Regards,
>>
>>Maurice
>>
>>-----Message d'origine-----
>>De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
>>Envoyé : jeudi 26 septembre 2013 19:55
>>À : dev@flex.apache.org
>>Objet : RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>>Applications
>>
>>Thanks for the clarification.
>>
>>I won't put the @author tag then.
>>
>>Maurice
>>
>>-----Message d'origine-----
>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
>>2013 19:45 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>>donation of Systar DataGrid for Mobile Applications
>>
>>Hi Maurice,
>>
>>Most projects at Apache discourage author tags. There is no official
>>policy prohibiting and Apache Flex has not made any decision.
>>
>>The general reasoning is that there are currently 40+ committers and
>>growing on Apache Flex and if everyone who touched a file added an author
>>tag, eventually, some classes would eventually have a long list of tags.
>>Source-control history will always record you as the author, so I'd leave
>>it out if you're ok with that, but either way, it won't affect the
>>donation.
>>
>>-Alex
>>
>>
>>On 9/26/13 10:37 AM, "Maurice Amsellem" <ma...@systar.com>
>>wrote:
>>
>>>I am adding the headers now.
>>>
>>>I noticed some of the components in experimental had mention of the
>>>original author, in addition to Apache Header. (see below).
>>>Should I do the same ?
>>>Eg. @author Maurice Amsellem for SYSTAR (Maurice.amsellem@systar.com).
>>>
>>>
>>>Spark/components/itemRenderers/MenuItemRenderer.mxml
>>>
>>>
>>>///////////////////////////////////////////////////////////////////////
>>>//
>>>///////
>>> //
>>> // Licensed to the Apache Software Foundation (ASF) under one or more
>>> // contributor license agreements. See the NOTICE file distributed
>>>with
>>> // this work for additional information regarding copyright ownership.
>>> // The ASF licenses this file to You under the Apache License,
>>>Version
>>>2.0
>>> // (the "License"); you may not use this file except in compliance
>>>with
>>> // the License. You may obtain a copy of the License at
>>> //
>>> // http://www.apache.org/licenses/LICENSE-2.0
>>> //
>>> // Unless required by applicable law or agreed to in writing, software
>>> // distributed under the License is distributed on an "AS IS" BASIS,
>>> // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>>>implied.
>>> // See the License for the specific language governing permissions and
>>> // limitations under the License.
>>> //
>>>
>>>///////////////////////////////////////////////////////////////////////
>>>//
>>>///////
>>> @author Bogdan Dinu (http://www.badu.ro)
>>> -->
>>>
>>>-----Message d'origine-----
>>>De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
>>>Envoyé : jeudi 26 septembre 2013 19:02
>>>À : dev@flex.apache.org
>>>Objet : RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>>>Applications
>>>
>>>OK, I will add the Apache headers and Notice, and send you the code,
>>>tonight or tomorrow latest...
>>>
>>>Maurice
>>>
>>>-----Message d'origine-----
>>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
>>>2013 18:43 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>>>donation of Systar DataGrid for Mobile Applications
>>>
>>>In theory, Systar's legal department should be requiring some form of
>>>header on any code leaving your company. So yes, adding headers is
>>>advised and it would be my preference and probably save time in the end
>>>if you use the Apache headers and NOTICE file.
>>>
>>>IMO, no other changes to the code are required at this time. In fact,
>>>other than the headers, the code should be the same that your officers
>>>signed for in the grant ;-).
>>>
>>>Thanks again for the donation,
>>>-Alex
>>>
>>>On 9/26/13 9:34 AM, "Maurice Amsellem" <ma...@systar.com>
>>>wrote:
>>>
>>>>We also received the acknowledgments. That's good news.
>>>>
>>>>Do I need to make the changes requested before (Apache headers, etc..)
>>>>before sending you the sources ?
>>>>
>>>>Maurice
>>>>
>>>>-----Message d'origine-----
>>>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
>>>>2013 18:31 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>>>>donation of Systar DataGrid for Mobile Applications
>>>>
>>>>Hi Maurice,
>>>>
>>>>The grant was filed today. Please make a snapshot of the code
>>>>available when you can. You can email the link or source to me
>>>>directly. Any other PMC'rs want to help with the IP review?
>>>>
>>>>-Alex
>>>>
>>>>On 9/25/13 7:56 PM, "Alex Harui" <ah...@adobe.com> wrote:
>>>>
>>>>>Again, none of this is required pre-donation. But if you have the
>>>>>time, that would be great.
>>>>>
>>>>>On 9/25/13 5:32 PM, "Maurice Amsellem" <ma...@systar.com>
>>>>>wrote:
>>>>>
>>>>>>OK.
>>>>>>
>>>>>>-----Message d'origine-----
>>>>>>De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé : jeudi
>>>>>>26 septembre 2013 02:24 À : dev@flex.apache.org Objet : Re:
>>>>>>[VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>>>>>>Applications
>>>>>>
>>>>>>Hi,
>>>>>>
>>>>>>> 2) 240 and 480 DPI assets are missing. I will add them.
>>>>>>You might need to add 120 and 640 as well as those have been
>>>>>>recently added to the SDK.
>>>>>>
>>>>>>Thanks,
>>>>>>Justin
>>>>>
>>>>
>>>
>>
>
Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Alex Harui <ah...@adobe.com>.
Hi Maurice,
Thanks! I will review it this evening.
-Alex
On 9/26/13 11:46 AM, "Maurice Amsellem" <ma...@systar.com>
wrote:
>Hi,
>
>I have added the headers, LICENSE and NOTICE and attached the source code
>attached to the JIRA ticket :
>https://issues.apache.org/jira/browse/FLEX-33777
>
>Regards,
>
>Maurice
>
>-----Message d'origine-----
>De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
>Envoyé : jeudi 26 septembre 2013 19:55
>À : dev@flex.apache.org
>Objet : RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>Applications
>
>Thanks for the clarification.
>
>I won't put the @author tag then.
>
>Maurice
>
>-----Message d'origine-----
>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
>2013 19:45 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>donation of Systar DataGrid for Mobile Applications
>
>Hi Maurice,
>
>Most projects at Apache discourage author tags. There is no official
>policy prohibiting and Apache Flex has not made any decision.
>
>The general reasoning is that there are currently 40+ committers and
>growing on Apache Flex and if everyone who touched a file added an author
>tag, eventually, some classes would eventually have a long list of tags.
>Source-control history will always record you as the author, so I'd leave
>it out if you're ok with that, but either way, it won't affect the
>donation.
>
>-Alex
>
>
>On 9/26/13 10:37 AM, "Maurice Amsellem" <ma...@systar.com>
>wrote:
>
>>I am adding the headers now.
>>
>>I noticed some of the components in experimental had mention of the
>>original author, in addition to Apache Header. (see below).
>>Should I do the same ?
>>Eg. @author Maurice Amsellem for SYSTAR (Maurice.amsellem@systar.com).
>>
>>
>>Spark/components/itemRenderers/MenuItemRenderer.mxml
>>
>>
>>///////////////////////////////////////////////////////////////////////
>>//
>>///////
>> //
>> // Licensed to the Apache Software Foundation (ASF) under one or more
>> // contributor license agreements. See the NOTICE file distributed
>>with
>> // this work for additional information regarding copyright ownership.
>> // The ASF licenses this file to You under the Apache License,
>>Version
>>2.0
>> // (the "License"); you may not use this file except in compliance with
>> // the License. You may obtain a copy of the License at
>> //
>> // http://www.apache.org/licenses/LICENSE-2.0
>> //
>> // Unless required by applicable law or agreed to in writing, software
>> // distributed under the License is distributed on an "AS IS" BASIS,
>> // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>>implied.
>> // See the License for the specific language governing permissions and
>> // limitations under the License.
>> //
>>
>>///////////////////////////////////////////////////////////////////////
>>//
>>///////
>> @author Bogdan Dinu (http://www.badu.ro)
>> -->
>>
>>-----Message d'origine-----
>>De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
>>Envoyé : jeudi 26 septembre 2013 19:02
>>À : dev@flex.apache.org
>>Objet : RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>>Applications
>>
>>OK, I will add the Apache headers and Notice, and send you the code,
>>tonight or tomorrow latest...
>>
>>Maurice
>>
>>-----Message d'origine-----
>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
>>2013 18:43 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>>donation of Systar DataGrid for Mobile Applications
>>
>>In theory, Systar's legal department should be requiring some form of
>>header on any code leaving your company. So yes, adding headers is
>>advised and it would be my preference and probably save time in the end
>>if you use the Apache headers and NOTICE file.
>>
>>IMO, no other changes to the code are required at this time. In fact,
>>other than the headers, the code should be the same that your officers
>>signed for in the grant ;-).
>>
>>Thanks again for the donation,
>>-Alex
>>
>>On 9/26/13 9:34 AM, "Maurice Amsellem" <ma...@systar.com>
>>wrote:
>>
>>>We also received the acknowledgments. That's good news.
>>>
>>>Do I need to make the changes requested before (Apache headers, etc..)
>>>before sending you the sources ?
>>>
>>>Maurice
>>>
>>>-----Message d'origine-----
>>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
>>>2013 18:31 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>>>donation of Systar DataGrid for Mobile Applications
>>>
>>>Hi Maurice,
>>>
>>>The grant was filed today. Please make a snapshot of the code
>>>available when you can. You can email the link or source to me
>>>directly. Any other PMC'rs want to help with the IP review?
>>>
>>>-Alex
>>>
>>>On 9/25/13 7:56 PM, "Alex Harui" <ah...@adobe.com> wrote:
>>>
>>>>Again, none of this is required pre-donation. But if you have the
>>>>time, that would be great.
>>>>
>>>>On 9/25/13 5:32 PM, "Maurice Amsellem" <ma...@systar.com>
>>>>wrote:
>>>>
>>>>>OK.
>>>>>
>>>>>-----Message d'origine-----
>>>>>De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé : jeudi
>>>>>26 septembre 2013 02:24 À : dev@flex.apache.org Objet : Re:
>>>>>[VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>>>>>Applications
>>>>>
>>>>>Hi,
>>>>>
>>>>>> 2) 240 and 480 DPI assets are missing. I will add them.
>>>>>You might need to add 120 and 640 as well as those have been
>>>>>recently added to the SDK.
>>>>>
>>>>>Thanks,
>>>>>Justin
>>>>
>>>
>>
>
RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Maurice Amsellem <ma...@systar.com>.
Hi,
I have added the headers, LICENSE and NOTICE and attached the source code attached to the JIRA ticket :
https://issues.apache.org/jira/browse/FLEX-33777
Regards,
Maurice
-----Message d'origine-----
De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
Envoyé : jeudi 26 septembre 2013 19:55
À : dev@flex.apache.org
Objet : RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
Thanks for the clarification.
I won't put the @author tag then.
Maurice
-----Message d'origine-----
De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre 2013 19:45 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
Hi Maurice,
Most projects at Apache discourage author tags. There is no official policy prohibiting and Apache Flex has not made any decision.
The general reasoning is that there are currently 40+ committers and growing on Apache Flex and if everyone who touched a file added an author tag, eventually, some classes would eventually have a long list of tags.
Source-control history will always record you as the author, so I'd leave it out if you're ok with that, but either way, it won't affect the donation.
-Alex
On 9/26/13 10:37 AM, "Maurice Amsellem" <ma...@systar.com>
wrote:
>I am adding the headers now.
>
>I noticed some of the components in experimental had mention of the
>original author, in addition to Apache Header. (see below).
>Should I do the same ?
>Eg. @author Maurice Amsellem for SYSTAR (Maurice.amsellem@systar.com).
>
>
>Spark/components/itemRenderers/MenuItemRenderer.mxml
>
>
>///////////////////////////////////////////////////////////////////////
>//
>///////
> //
> // Licensed to the Apache Software Foundation (ASF) under one or more
> // contributor license agreements. See the NOTICE file distributed with
> // this work for additional information regarding copyright ownership.
> // The ASF licenses this file to You under the Apache License,
>Version
>2.0
> // (the "License"); you may not use this file except in compliance with
> // the License. You may obtain a copy of the License at
> //
> // http://www.apache.org/licenses/LICENSE-2.0
> //
> // Unless required by applicable law or agreed to in writing, software
> // distributed under the License is distributed on an "AS IS" BASIS,
> // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>implied.
> // See the License for the specific language governing permissions and
> // limitations under the License.
> //
>
>///////////////////////////////////////////////////////////////////////
>//
>///////
> @author Bogdan Dinu (http://www.badu.ro)
> -->
>
>-----Message d'origine-----
>De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
>Envoyé : jeudi 26 septembre 2013 19:02
>À : dev@flex.apache.org
>Objet : RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>Applications
>
>OK, I will add the Apache headers and Notice, and send you the code,
>tonight or tomorrow latest...
>
>Maurice
>
>-----Message d'origine-----
>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
>2013 18:43 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>donation of Systar DataGrid for Mobile Applications
>
>In theory, Systar's legal department should be requiring some form of
>header on any code leaving your company. So yes, adding headers is
>advised and it would be my preference and probably save time in the end
>if you use the Apache headers and NOTICE file.
>
>IMO, no other changes to the code are required at this time. In fact,
>other than the headers, the code should be the same that your officers
>signed for in the grant ;-).
>
>Thanks again for the donation,
>-Alex
>
>On 9/26/13 9:34 AM, "Maurice Amsellem" <ma...@systar.com>
>wrote:
>
>>We also received the acknowledgments. That's good news.
>>
>>Do I need to make the changes requested before (Apache headers, etc..)
>>before sending you the sources ?
>>
>>Maurice
>>
>>-----Message d'origine-----
>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
>>2013 18:31 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>>donation of Systar DataGrid for Mobile Applications
>>
>>Hi Maurice,
>>
>>The grant was filed today. Please make a snapshot of the code
>>available when you can. You can email the link or source to me
>>directly. Any other PMC'rs want to help with the IP review?
>>
>>-Alex
>>
>>On 9/25/13 7:56 PM, "Alex Harui" <ah...@adobe.com> wrote:
>>
>>>Again, none of this is required pre-donation. But if you have the
>>>time, that would be great.
>>>
>>>On 9/25/13 5:32 PM, "Maurice Amsellem" <ma...@systar.com>
>>>wrote:
>>>
>>>>OK.
>>>>
>>>>-----Message d'origine-----
>>>>De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé : jeudi
>>>>26 septembre 2013 02:24 À : dev@flex.apache.org Objet : Re:
>>>>[VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>>>>Applications
>>>>
>>>>Hi,
>>>>
>>>>> 2) 240 and 480 DPI assets are missing. I will add them.
>>>>You might need to add 120 and 640 as well as those have been
>>>>recently added to the SDK.
>>>>
>>>>Thanks,
>>>>Justin
>>>
>>
>
RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Maurice Amsellem <ma...@systar.com>.
Thanks for the clarification.
I won't put the @author tag then.
Maurice
-----Message d'origine-----
De : Alex Harui [mailto:aharui@adobe.com]
Envoyé : jeudi 26 septembre 2013 19:45
À : dev@flex.apache.org
Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
Hi Maurice,
Most projects at Apache discourage author tags. There is no official policy prohibiting and Apache Flex has not made any decision.
The general reasoning is that there are currently 40+ committers and growing on Apache Flex and if everyone who touched a file added an author tag, eventually, some classes would eventually have a long list of tags.
Source-control history will always record you as the author, so I'd leave it out if you're ok with that, but either way, it won't affect the donation.
-Alex
On 9/26/13 10:37 AM, "Maurice Amsellem" <ma...@systar.com>
wrote:
>I am adding the headers now.
>
>I noticed some of the components in experimental had mention of the
>original author, in addition to Apache Header. (see below).
>Should I do the same ?
>Eg. @author Maurice Amsellem for SYSTAR (Maurice.amsellem@systar.com).
>
>
>Spark/components/itemRenderers/MenuItemRenderer.mxml
>
>
>///////////////////////////////////////////////////////////////////////
>//
>///////
> //
> // Licensed to the Apache Software Foundation (ASF) under one or more
> // contributor license agreements. See the NOTICE file distributed with
> // this work for additional information regarding copyright ownership.
> // The ASF licenses this file to You under the Apache License,
>Version
>2.0
> // (the "License"); you may not use this file except in compliance with
> // the License. You may obtain a copy of the License at
> //
> // http://www.apache.org/licenses/LICENSE-2.0
> //
> // Unless required by applicable law or agreed to in writing, software
> // distributed under the License is distributed on an "AS IS" BASIS,
> // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>implied.
> // See the License for the specific language governing permissions and
> // limitations under the License.
> //
>
>///////////////////////////////////////////////////////////////////////
>//
>///////
> @author Bogdan Dinu (http://www.badu.ro)
> -->
>
>-----Message d'origine-----
>De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
>Envoyé : jeudi 26 septembre 2013 19:02
>À : dev@flex.apache.org
>Objet : RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>Applications
>
>OK, I will add the Apache headers and Notice, and send you the code,
>tonight or tomorrow latest...
>
>Maurice
>
>-----Message d'origine-----
>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
>2013 18:43 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>donation of Systar DataGrid for Mobile Applications
>
>In theory, Systar's legal department should be requiring some form of
>header on any code leaving your company. So yes, adding headers is
>advised and it would be my preference and probably save time in the end
>if you use the Apache headers and NOTICE file.
>
>IMO, no other changes to the code are required at this time. In fact,
>other than the headers, the code should be the same that your officers
>signed for in the grant ;-).
>
>Thanks again for the donation,
>-Alex
>
>On 9/26/13 9:34 AM, "Maurice Amsellem" <ma...@systar.com>
>wrote:
>
>>We also received the acknowledgments. That's good news.
>>
>>Do I need to make the changes requested before (Apache headers, etc..)
>>before sending you the sources ?
>>
>>Maurice
>>
>>-----Message d'origine-----
>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
>>2013 18:31 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>>donation of Systar DataGrid for Mobile Applications
>>
>>Hi Maurice,
>>
>>The grant was filed today. Please make a snapshot of the code
>>available when you can. You can email the link or source to me
>>directly. Any other PMC'rs want to help with the IP review?
>>
>>-Alex
>>
>>On 9/25/13 7:56 PM, "Alex Harui" <ah...@adobe.com> wrote:
>>
>>>Again, none of this is required pre-donation. But if you have the
>>>time, that would be great.
>>>
>>>On 9/25/13 5:32 PM, "Maurice Amsellem" <ma...@systar.com>
>>>wrote:
>>>
>>>>OK.
>>>>
>>>>-----Message d'origine-----
>>>>De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé : jeudi
>>>>26 septembre 2013 02:24 À : dev@flex.apache.org Objet : Re:
>>>>[VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>>>>Applications
>>>>
>>>>Hi,
>>>>
>>>>> 2) 240 and 480 DPI assets are missing. I will add them.
>>>>You might need to add 120 and 640 as well as those have been
>>>>recently added to the SDK.
>>>>
>>>>Thanks,
>>>>Justin
>>>
>>
>
Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Alex Harui <ah...@adobe.com>.
Hi Maurice,
Most projects at Apache discourage author tags. There is no official
policy prohibiting and Apache Flex has not made any decision.
The general reasoning is that there are currently 40+ committers and
growing on Apache Flex and if everyone who touched a file added an author
tag, eventually, some classes would eventually have a long list of tags.
Source-control history will always record you as the author, so I'd leave
it out if you're ok with that, but either way, it won't affect the
donation.
-Alex
On 9/26/13 10:37 AM, "Maurice Amsellem" <ma...@systar.com>
wrote:
>I am adding the headers now.
>
>I noticed some of the components in experimental had mention of the
>original author, in addition to Apache Header. (see below).
>Should I do the same ?
>Eg. @author Maurice Amsellem for SYSTAR (Maurice.amsellem@systar.com).
>
>
>Spark/components/itemRenderers/MenuItemRenderer.mxml
>
> /////////////////////////////////////////////////////////////////////////
>///////
> //
> // Licensed to the Apache Software Foundation (ASF) under one or more
> // contributor license agreements. See the NOTICE file distributed with
> // this work for additional information regarding copyright ownership.
> // The ASF licenses this file to You under the Apache License, Version
>2.0
> // (the "License"); you may not use this file except in compliance with
> // the License. You may obtain a copy of the License at
> //
> // http://www.apache.org/licenses/LICENSE-2.0
> //
> // Unless required by applicable law or agreed to in writing, software
> // distributed under the License is distributed on an "AS IS" BASIS,
> // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>implied.
> // See the License for the specific language governing permissions and
> // limitations under the License.
> //
> /////////////////////////////////////////////////////////////////////////
>///////
> @author Bogdan Dinu (http://www.badu.ro)
> -->
>
>-----Message d'origine-----
>De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
>Envoyé : jeudi 26 septembre 2013 19:02
>À : dev@flex.apache.org
>Objet : RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>Applications
>
>OK, I will add the Apache headers and Notice, and send you the code,
>tonight or tomorrow latest...
>
>Maurice
>
>-----Message d'origine-----
>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
>2013 18:43 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>donation of Systar DataGrid for Mobile Applications
>
>In theory, Systar's legal department should be requiring some form of
>header on any code leaving your company. So yes, adding headers is
>advised and it would be my preference and probably save time in the end
>if you use the Apache headers and NOTICE file.
>
>IMO, no other changes to the code are required at this time. In fact,
>other than the headers, the code should be the same that your officers
>signed for in the grant ;-).
>
>Thanks again for the donation,
>-Alex
>
>On 9/26/13 9:34 AM, "Maurice Amsellem" <ma...@systar.com>
>wrote:
>
>>We also received the acknowledgments. That's good news.
>>
>>Do I need to make the changes requested before (Apache headers, etc..)
>>before sending you the sources ?
>>
>>Maurice
>>
>>-----Message d'origine-----
>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
>>2013 18:31 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>>donation of Systar DataGrid for Mobile Applications
>>
>>Hi Maurice,
>>
>>The grant was filed today. Please make a snapshot of the code
>>available when you can. You can email the link or source to me
>>directly. Any other PMC'rs want to help with the IP review?
>>
>>-Alex
>>
>>On 9/25/13 7:56 PM, "Alex Harui" <ah...@adobe.com> wrote:
>>
>>>Again, none of this is required pre-donation. But if you have the
>>>time, that would be great.
>>>
>>>On 9/25/13 5:32 PM, "Maurice Amsellem" <ma...@systar.com>
>>>wrote:
>>>
>>>>OK.
>>>>
>>>>-----Message d'origine-----
>>>>De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé : jeudi
>>>>26 septembre 2013 02:24 À : dev@flex.apache.org Objet : Re:
>>>>[VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>>>>Applications
>>>>
>>>>Hi,
>>>>
>>>>> 2) 240 and 480 DPI assets are missing. I will add them.
>>>>You might need to add 120 and 640 as well as those have been recently
>>>>added to the SDK.
>>>>
>>>>Thanks,
>>>>Justin
>>>
>>
>
RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Maurice Amsellem <ma...@systar.com>.
I am adding the headers now.
I noticed some of the components in experimental had mention of the original author, in addition to Apache Header. (see below).
Should I do the same ?
Eg. @author Maurice Amsellem for SYSTAR (Maurice.amsellem@systar.com).
Spark/components/itemRenderers/MenuItemRenderer.mxml
////////////////////////////////////////////////////////////////////////////////
//
// Licensed to the Apache Software Foundation (ASF) under one or more
// contributor license agreements. See the NOTICE file distributed with
// this work for additional information regarding copyright ownership.
// The ASF licenses this file to You under the Apache License, Version 2.0
// (the "License"); you may not use this file except in compliance with
// the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
////////////////////////////////////////////////////////////////////////////////
@author Bogdan Dinu (http://www.badu.ro)
-->
-----Message d'origine-----
De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
Envoyé : jeudi 26 septembre 2013 19:02
À : dev@flex.apache.org
Objet : RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
OK, I will add the Apache headers and Notice, and send you the code, tonight or tomorrow latest...
Maurice
-----Message d'origine-----
De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre 2013 18:43 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
In theory, Systar's legal department should be requiring some form of header on any code leaving your company. So yes, adding headers is advised and it would be my preference and probably save time in the end if you use the Apache headers and NOTICE file.
IMO, no other changes to the code are required at this time. In fact, other than the headers, the code should be the same that your officers signed for in the grant ;-).
Thanks again for the donation,
-Alex
On 9/26/13 9:34 AM, "Maurice Amsellem" <ma...@systar.com> wrote:
>We also received the acknowledgments. That's good news.
>
>Do I need to make the changes requested before (Apache headers, etc..)
>before sending you the sources ?
>
>Maurice
>
>-----Message d'origine-----
>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
>2013 18:31 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>donation of Systar DataGrid for Mobile Applications
>
>Hi Maurice,
>
>The grant was filed today. Please make a snapshot of the code
>available when you can. You can email the link or source to me
>directly. Any other PMC'rs want to help with the IP review?
>
>-Alex
>
>On 9/25/13 7:56 PM, "Alex Harui" <ah...@adobe.com> wrote:
>
>>Again, none of this is required pre-donation. But if you have the
>>time, that would be great.
>>
>>On 9/25/13 5:32 PM, "Maurice Amsellem" <ma...@systar.com>
>>wrote:
>>
>>>OK.
>>>
>>>-----Message d'origine-----
>>>De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé : jeudi
>>>26 septembre 2013 02:24 À : dev@flex.apache.org Objet : Re:
>>>[VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>>>Applications
>>>
>>>Hi,
>>>
>>>> 2) 240 and 480 DPI assets are missing. I will add them.
>>>You might need to add 120 and 640 as well as those have been recently
>>>added to the SDK.
>>>
>>>Thanks,
>>>Justin
>>
>
RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Maurice Amsellem <ma...@systar.com>.
OK, I will add the Apache headers and Notice, and send you the code, tonight or tomorrow latest...
Maurice
-----Message d'origine-----
De : Alex Harui [mailto:aharui@adobe.com]
Envoyé : jeudi 26 septembre 2013 18:43
À : dev@flex.apache.org
Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
In theory, Systar's legal department should be requiring some form of header on any code leaving your company. So yes, adding headers is advised and it would be my preference and probably save time in the end if you use the Apache headers and NOTICE file.
IMO, no other changes to the code are required at this time. In fact, other than the headers, the code should be the same that your officers signed for in the grant ;-).
Thanks again for the donation,
-Alex
On 9/26/13 9:34 AM, "Maurice Amsellem" <ma...@systar.com> wrote:
>We also received the acknowledgments. That's good news.
>
>Do I need to make the changes requested before (Apache headers, etc..)
>before sending you the sources ?
>
>Maurice
>
>-----Message d'origine-----
>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : jeudi 26 septembre
>2013 18:31 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
>donation of Systar DataGrid for Mobile Applications
>
>Hi Maurice,
>
>The grant was filed today. Please make a snapshot of the code
>available when you can. You can email the link or source to me
>directly. Any other PMC'rs want to help with the IP review?
>
>-Alex
>
>On 9/25/13 7:56 PM, "Alex Harui" <ah...@adobe.com> wrote:
>
>>Again, none of this is required pre-donation. But if you have the
>>time, that would be great.
>>
>>On 9/25/13 5:32 PM, "Maurice Amsellem" <ma...@systar.com>
>>wrote:
>>
>>>OK.
>>>
>>>-----Message d'origine-----
>>>De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé : jeudi
>>>26 septembre 2013 02:24 À : dev@flex.apache.org Objet : Re:
>>>[VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>>>Applications
>>>
>>>Hi,
>>>
>>>> 2) 240 and 480 DPI assets are missing. I will add them.
>>>You might need to add 120 and 640 as well as those have been recently
>>>added to the SDK.
>>>
>>>Thanks,
>>>Justin
>>
>
Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> In theory, Systar's legal department should be requiring some form of
> header on any code leaving your company.
I'm not a laywer but my understanding was that code (or anyting) doesn't have to have a copyright header in order to give protection to it's owners, that's now automatic.
See http://en.wikipedia.org/wiki/Copyright_notice, looks like that changed in 1989 and there's probably not a lot of code written before that date in the donation :-)
The headers/ copyright notice just make it clearer who the owners actually are.
Thanks,
Justin
Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Alex Harui <ah...@adobe.com>.
In theory, Systar's legal department should be requiring some form of
header on any code leaving your company. So yes, adding headers is
advised and it would be my preference and probably save time in the end if
you use the Apache headers and NOTICE file.
IMO, no other changes to the code are required at this time. In fact,
other than the headers, the code should be the same that your officers
signed for in the grant
;-).
Thanks again for the donation,
-Alex
On 9/26/13 9:34 AM, "Maurice Amsellem" <ma...@systar.com> wrote:
>We also received the acknowledgments. That's good news.
>
>Do I need to make the changes requested before (Apache headers, etc..)
>before sending you the sources ?
>
>Maurice
>
>-----Message d'origine-----
>De : Alex Harui [mailto:aharui@adobe.com]
>Envoyé : jeudi 26 septembre 2013 18:31
>À : dev@flex.apache.org
>Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>Applications
>
>Hi Maurice,
>
>The grant was filed today. Please make a snapshot of the code available
>when you can. You can email the link or source to me directly. Any
>other PMC'rs want to help with the IP review?
>
>-Alex
>
>On 9/25/13 7:56 PM, "Alex Harui" <ah...@adobe.com> wrote:
>
>>Again, none of this is required pre-donation. But if you have the
>>time, that would be great.
>>
>>On 9/25/13 5:32 PM, "Maurice Amsellem" <ma...@systar.com>
>>wrote:
>>
>>>OK.
>>>
>>>-----Message d'origine-----
>>>De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé : jeudi 26
>>>septembre 2013 02:24 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY]
>>>Accept donation of Systar DataGrid for Mobile Applications
>>>
>>>Hi,
>>>
>>>> 2) 240 and 480 DPI assets are missing. I will add them.
>>>You might need to add 120 and 640 as well as those have been recently
>>>added to the SDK.
>>>
>>>Thanks,
>>>Justin
>>
>
RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Maurice Amsellem <ma...@systar.com>.
We also received the acknowledgments. That's good news.
Do I need to make the changes requested before (Apache headers, etc..) before sending you the sources ?
Maurice
-----Message d'origine-----
De : Alex Harui [mailto:aharui@adobe.com]
Envoyé : jeudi 26 septembre 2013 18:31
À : dev@flex.apache.org
Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
Hi Maurice,
The grant was filed today. Please make a snapshot of the code available when you can. You can email the link or source to me directly. Any other PMC'rs want to help with the IP review?
-Alex
On 9/25/13 7:56 PM, "Alex Harui" <ah...@adobe.com> wrote:
>Again, none of this is required pre-donation. But if you have the
>time, that would be great.
>
>On 9/25/13 5:32 PM, "Maurice Amsellem" <ma...@systar.com>
>wrote:
>
>>OK.
>>
>>-----Message d'origine-----
>>De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé : jeudi 26
>>septembre 2013 02:24 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY]
>>Accept donation of Systar DataGrid for Mobile Applications
>>
>>Hi,
>>
>>> 2) 240 and 480 DPI assets are missing. I will add them.
>>You might need to add 120 and 640 as well as those have been recently
>>added to the SDK.
>>
>>Thanks,
>>Justin
>
Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Alex Harui <ah...@adobe.com>.
Hi Maurice,
The grant was filed today. Please make a snapshot of the code available
when you can. You can email the link or source to me directly. Any other
PMC'rs want to help with the IP review?
-Alex
On 9/25/13 7:56 PM, "Alex Harui" <ah...@adobe.com> wrote:
>Again, none of this is required pre-donation. But if you have the time,
>that would be great.
>
>On 9/25/13 5:32 PM, "Maurice Amsellem" <ma...@systar.com>
>wrote:
>
>>OK.
>>
>>-----Message d'origine-----
>>De : Justin Mclean [mailto:justin@classsoftware.com]
>>Envoyé : jeudi 26 septembre 2013 02:24
>>À : dev@flex.apache.org
>>Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>>Applications
>>
>>Hi,
>>
>>> 2) 240 and 480 DPI assets are missing. I will add them.
>>You might need to add 120 and 640 as well as those have been recently
>>added to the SDK.
>>
>>Thanks,
>>Justin
>
Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Alex Harui <ah...@adobe.com>.
Again, none of this is required pre-donation. But if you have the time,
that would be great.
On 9/25/13 5:32 PM, "Maurice Amsellem" <ma...@systar.com> wrote:
>OK.
>
>-----Message d'origine-----
>De : Justin Mclean [mailto:justin@classsoftware.com]
>Envoyé : jeudi 26 septembre 2013 02:24
>À : dev@flex.apache.org
>Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
>Applications
>
>Hi,
>
>> 2) 240 and 480 DPI assets are missing. I will add them.
>You might need to add 120 and 640 as well as those have been recently
>added to the SDK.
>
>Thanks,
>Justin
RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Maurice Amsellem <ma...@systar.com>.
OK.
-----Message d'origine-----
De : Justin Mclean [mailto:justin@classsoftware.com]
Envoyé : jeudi 26 septembre 2013 02:24
À : dev@flex.apache.org
Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
Hi,
> 2) 240 and 480 DPI assets are missing. I will add them.
You might need to add 120 and 640 as well as those have been recently added to the SDK.
Thanks,
Justin
Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> 2) 240 and 480 DPI assets are missing. I will add them.
You might need to add 120 and 640 as well as those have been recently added to the SDK.
Thanks,
Justin
RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
Applications
Posted by Maurice Amsellem <ma...@systar.com>.
If you are going to review the code I sent you, I think some comments could be helpful:
1) I didn't use invalidateProperties() / commitProperties, to set MobileDataGrid properties (too lazy?). I will fix that.
2) 240 and 480 DPI assets are missing. I will add them.
3) the key class is ListMultiPartItemRenderer which is responsible of rendering a single row of the MDG.
it maintains two vectors :
- partRendererDescriptors (actually the datagrid columns)
- partRenderers : vector of "lightweight" sub-renderers, that will render the cells of each row
Typical implementation of these light sub-renderers inherit from low-level mobile-savvy components such as StyleableTextField for text or BitmapAsset for embedded icons.
4) the layout of the components inside the multi-part renderer is delegated to a separate layout class (inspired from spark architecture). Maybe that's overkill.
5) The interface IPartRendererDescriptor could seem like useless. It's because I am using the same mechanim for other mobile components.
Typically Colored Tiles, displaying several lines of text or icons.
In this case, each partRendererDescriptors would describe a line in the tile.
And the layout would be vertical rather than tabbed horizontal.
If that's of no use for Flex, maybe I could remove the interfaces, and get something more straightforward.
WDYT?
Maurice
-----Message d'origine-----
De : Justin Mclean [mailto:justin@classsoftware.com]
Envoyé : jeudi 26 septembre 2013 00:15
À : dev@flex.apache.org
Objet : Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
HI,
Can we have access to the source code. I'm not against it's inclusion but it would be nice to have the full picture.
Justin
Re: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile Applications
Posted by Justin Mclean <ju...@classsoftware.com>.
HI,
Can we have access to the source code. I'm not against it's inclusion but it would be nice to have the full picture.
Justin