You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jimmy Xiang (Created) (JIRA)" <ji...@apache.org> on 2012/04/14 00:09:17 UTC
[jira] [Created] (HBASE-5785) Adding unit tests for protbuf utils
introduced for HRegionInterface pb conversion
Adding unit tests for protbuf utils introduced for HRegionInterface pb conversion
---------------------------------------------------------------------------------
Key: HBASE-5785
URL: https://issues.apache.org/jira/browse/HBASE-5785
Project: HBase
Issue Type: Sub-task
Affects Versions: 0.96.0
Reporter: Jimmy Xiang
Assignee: Jimmy Xiang
Fix For: 0.96.0
We need to add some unit tests for the probuf utilities to catch issues earlier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5785) Adding unit tests for protbuf utils
introduced for HRegionInterface pb conversion
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266371#comment-13266371 ]
Hudson commented on HBASE-5785:
-------------------------------
Integrated in HBase-TRUNK-security #189 (See [https://builds.apache.org/job/HBase-TRUNK-security/189/])
HBASE-5785 Adding unit tests for protbuf utils introduced for HRegionInterface pb conversion (Revision 1332824)
Result = SUCCESS
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/protobuf
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java
> Adding unit tests for protbuf utils introduced for HRegionInterface pb conversion
> ---------------------------------------------------------------------------------
>
> Key: HBASE-5785
> URL: https://issues.apache.org/jira/browse/HBASE-5785
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Affects Versions: 0.96.0
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Critical
> Labels: noob
> Fix For: 0.96.0
>
> Attachments: hbase-5785.patch
>
>
> We need to add some unit tests for the probuf utilities to catch issues earlier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5785) Adding unit tests for protbuf utils
introduced for HRegionInterface pb conversion
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266163#comment-13266163 ]
Hudson commented on HBASE-5785:
-------------------------------
Integrated in HBase-TRUNK #2834 (See [https://builds.apache.org/job/HBase-TRUNK/2834/])
HBASE-5785 Adding unit tests for protbuf utils introduced for HRegionInterface pb conversion (Revision 1332824)
Result = FAILURE
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/protobuf
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java
> Adding unit tests for protbuf utils introduced for HRegionInterface pb conversion
> ---------------------------------------------------------------------------------
>
> Key: HBASE-5785
> URL: https://issues.apache.org/jira/browse/HBASE-5785
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Affects Versions: 0.96.0
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Critical
> Labels: noob
> Fix For: 0.96.0
>
> Attachments: hbase-5785.patch
>
>
> We need to add some unit tests for the probuf utilities to catch issues earlier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5785) Adding unit tests for protbuf utils
introduced for HRegionInterface pb conversion
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263812#comment-13263812 ]
Hadoop QA commented on HBASE-5785:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12524879/hbase-5785.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1669//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1669//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1669//console
This message is automatically generated.
> Adding unit tests for protbuf utils introduced for HRegionInterface pb conversion
> ---------------------------------------------------------------------------------
>
> Key: HBASE-5785
> URL: https://issues.apache.org/jira/browse/HBASE-5785
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Affects Versions: 0.96.0
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Critical
> Labels: noob
> Fix For: 0.96.0
>
> Attachments: hbase-5785.patch
>
>
> We need to add some unit tests for the probuf utilities to catch issues earlier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5785) Adding unit tests for protbuf utils
introduced for HRegionInterface pb conversion
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5785:
-------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Good one Jimmy. Thanks.
> Adding unit tests for protbuf utils introduced for HRegionInterface pb conversion
> ---------------------------------------------------------------------------------
>
> Key: HBASE-5785
> URL: https://issues.apache.org/jira/browse/HBASE-5785
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Affects Versions: 0.96.0
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Critical
> Labels: noob
> Fix For: 0.96.0
>
> Attachments: hbase-5785.patch
>
>
> We need to add some unit tests for the probuf utilities to catch issues earlier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5785) Adding unit tests for protbuf utils
introduced for HRegionInterface pb conversion
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265069#comment-13265069 ]
jiraposter@reviews.apache.org commented on HBASE-5785:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4936/
-----------------------------------------------------------
Review request for hbase and Michael Stack.
Summary
-------
I added some tests for that conversion methods. For those helper utilities, they are tested in other tests implicitly. We can add more later on if needed.
This addresses bug HBASE-5785.
https://issues.apache.org/jira/browse/HBASE-5785
Diffs
-----
src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java 994cb76
src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java 9b594aa
src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java PRE-CREATION
Diff: https://reviews.apache.org/r/4936/diff
Testing
-------
The new tests are green.
Thanks,
Jimmy
> Adding unit tests for protbuf utils introduced for HRegionInterface pb conversion
> ---------------------------------------------------------------------------------
>
> Key: HBASE-5785
> URL: https://issues.apache.org/jira/browse/HBASE-5785
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Affects Versions: 0.96.0
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Critical
> Labels: noob
> Fix For: 0.96.0
>
> Attachments: hbase-5785.patch
>
>
> We need to add some unit tests for the probuf utilities to catch issues earlier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5785) Adding unit tests for protbuf utils
introduced for HRegionInterface pb conversion
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5785:
-------------------------
Priority: Critical (was: Major)
Tags: noob
Labels: noob (was: )
Marking critical and noob (in case anyone out there wants to help our man Jimmy out)
> Adding unit tests for protbuf utils introduced for HRegionInterface pb conversion
> ---------------------------------------------------------------------------------
>
> Key: HBASE-5785
> URL: https://issues.apache.org/jira/browse/HBASE-5785
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Affects Versions: 0.96.0
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Critical
> Labels: noob
> Fix For: 0.96.0
>
>
> We need to add some unit tests for the probuf utilities to catch issues earlier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5785) Adding unit tests for protbuf utils
introduced for HRegionInterface pb conversion
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5785:
-------------------------------
Attachment: hbase-5785.patch
> Adding unit tests for protbuf utils introduced for HRegionInterface pb conversion
> ---------------------------------------------------------------------------------
>
> Key: HBASE-5785
> URL: https://issues.apache.org/jira/browse/HBASE-5785
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Affects Versions: 0.96.0
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Critical
> Labels: noob
> Fix For: 0.96.0
>
> Attachments: hbase-5785.patch
>
>
> We need to add some unit tests for the probuf utilities to catch issues earlier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5785) Adding unit tests for protbuf utils
introduced for HRegionInterface pb conversion
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5785:
-------------------------------
Status: Patch Available (was: Open)
I added some tests. I indeed found an issue. It is helpful.
We can add more later on.
> Adding unit tests for protbuf utils introduced for HRegionInterface pb conversion
> ---------------------------------------------------------------------------------
>
> Key: HBASE-5785
> URL: https://issues.apache.org/jira/browse/HBASE-5785
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Affects Versions: 0.96.0
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Critical
> Labels: noob
> Fix For: 0.96.0
>
> Attachments: hbase-5785.patch
>
>
> We need to add some unit tests for the probuf utilities to catch issues earlier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira