You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Qiao-yq (via GitHub)" <gi...@apache.org> on 2026/10/22 04:24:20 UTC
[PR] fix(ai): harden conversation snapshot access and contracts [dubbo-admin]
Qiao-yq opened a new pull request, #1608:
URL: https://github.com/apache/dubbo-admin/pull/1608
**Please provide a description of this PR:**
Draft. This PR is blocked by and must be merged after [#1596](https://github.com/apache/dubbo-admin/pull/1596).
Recheck Session access before each model iteration while retaining the interaction's stable context snapshot. This prevents an already-loaded snapshot from being used for another model call after the Session becomes inaccessible.
- keep the latest #1596 context-window implementation, message ordering, snapshot transaction, and Agent defaults
- document the shared context-window contract and extend Memory/GORM regression coverage for zero/bounded/oversized windows, inactive or missing Turns, deep copies, and snapshot stability after appends
- narrow the legacy-Session adoption helper to the capability it actually uses
This is the prerequisite fix for the production authentication and usage/audit PR. It adds no JWT adapter or accounting records.
While #1596 is open, GitHub's comparison against `ai` also includes its dependency changes. The changes on top of #1596 can be reviewed [here](https://github.com/Qiao-yq/dubbo-admin/compare/6ada40334596bc938829b349ac075a7a6bcbb480...fix/ai-1539-context-window).
Validation from `ai/`:
- `go test ./... -timeout 120s`
- `go test -race ./component/agent/react ./component/server/... ./store/... -timeout 180s`
- `git diff --check`
GORM tests use SQLite; this does not establish production MySQL/PostgreSQL acceptance.
Part of #1539. Blocked by #1596.
**To help us figure out who should review this PR, please put an X in all the areas that this PR affects.**
- [ ] Docs
- [ ] Installation
- [ ] User Experience
- [ ] Dubboctl
- [ ] Console
- [x] Core Component
**Please check any characteristics that apply to this pull request.**
- [x] Includes tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(ai): harden conversation snapshot access and contracts [dubbo-admin]
Posted by "robocanic (via GitHub) via notifications" <no...@dubbo.apache.org>.
robocanic commented on PR #1608:
URL: https://github.com/apache/dubbo-admin/pull/1608#issuecomment-6566794673
@Qiao-yq please merge the ai branch and resolve the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(ai): harden conversation snapshot access and contracts [dubbo-admin]
Posted by "sonarqubecloud[bot] (via GitHub) via notifications" <no...@dubbo.apache.org>.
sonarqubecloud[bot] commented on PR #1608:
URL: https://github.com/apache/dubbo-admin/pull/1608#issuecomment-6577865832
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-admin&pullRequest=1608) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-admin&pullRequest=1608&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-admin&pullRequest=1608&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-admin&pullRequest=1608&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-admin&pullRequest=1608&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-admin&pullRequest=1608&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-admin&pullRequest=1608)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(ai): harden conversation snapshot access and contracts [dubbo-admin]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #1608:
URL: https://github.com/apache/dubbo-admin/pull/1608#issuecomment-6469955511
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-admin&pullRequest=1608) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-admin&pullRequest=1608&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-admin&pullRequest=1608&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-admin&pullRequest=1608&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-admin&pullRequest=1608&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-admin&pullRequest=1608&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-admin&pullRequest=1608)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(ai): harden conversation snapshot access and contracts [dubbo-admin]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #1608:
URL: https://github.com/apache/dubbo-admin/pull/1608#issuecomment-6393296002
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-admin&pullRequest=1608) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-admin&pullRequest=1608&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-admin&pullRequest=1608&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-admin&pullRequest=1608&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-admin&pullRequest=1608&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-admin&pullRequest=1608&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-admin&pullRequest=1608)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(ai): harden conversation snapshot access and contracts [dubbo-admin]
Posted by "larry-zy (via GitHub)" <gi...@apache.org>.
larry-zy commented on PR #1608:
URL: https://github.com/apache/dubbo-admin/pull/1608#issuecomment-6380402344
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(ai): harden conversation snapshot access and contracts [dubbo-admin]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #1608:
URL: https://github.com/apache/dubbo-admin/pull/1608#issuecomment-6332661000
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-admin&pullRequest=1608) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-admin&pullRequest=1608&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-admin&pullRequest=1608&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-admin&pullRequest=1608&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-admin&pullRequest=1608&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-admin&pullRequest=1608&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-admin&pullRequest=1608)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org