You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2018/07/24 05:54:44 UTC

[GitHub] carbondata pull request #2540: [CARBONDATA-2649] Handled executor min/max pr...

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2540#discussion_r204630970
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/blocklet/BlockletInfo.java ---
    @@ -221,7 +223,30 @@ public void setNumberOfPages(int numberOfPages) {
           output.writeInt(measureChunksLength.get(i));
         }
         writeChunkInfoForOlderVersions(output);
    +    serializeMinMaxValues(output);
    +  }
     
    +  /**
    +   * serialize min max values
    +   *
    +   * @param output
    +   * @throws IOException
    +   */
    +  private void serializeMinMaxValues(DataOutput output) throws IOException {
    --- End diff --
    
    I don't think it is required to serailaize the min/max from driver. if columns are not cached then read footer from executor side.


---