You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/12/28 09:40:29 UTC

[GitHub] [beam] ilya-kozyrev commented on a change in pull request #16147: [BEAM-13359] [Playground] Tag existing examples

ilya-kozyrev commented on a change in pull request #16147:
URL: https://github.com/apache/beam/pull/16147#discussion_r775797271



##########
File path: examples/java/src/main/java/org/apache/beam/examples/DebuggingWordCount.java
##########
@@ -17,6 +17,16 @@
  */
 package org.apache.beam.examples;
 
+// beam-playground:
+//   name: DebuggingWordCount
+//   description: An example that counts words in Shakespeare/kinglear.txt includes regex
+//     filter("Flourish|stomach").
+//   multifile: false
+//   pipeline_options: --output output.txt
+//   categories:
+//     - IO
+//     - Options

Review comment:
       ```suggestion
   //     - Debugging
   //     - Filtering
   ```

##########
File path: sdks/go/examples/contains/contains.go
##########
@@ -15,6 +15,15 @@
 
 package main
 
+// beam-playground:
+//   name: Contains
+//   description: An example counts received substring in Shakespeare's works.
+//   multifile: false
+//   pipeline_options: --search king
+//   categories:
+//     - IO
+//     - Options

Review comment:
       ```suggestion
   //     - Filtering
   //     - Options
   //     - Debugging
   ```

##########
File path: examples/java/src/main/java/org/apache/beam/examples/WordCount.java
##########
@@ -17,6 +17,15 @@
  */
 package org.apache.beam.examples;
 
+// beam-playground:
+//   name: WordCount
+//   description: An example that counts words in Shakespeare's works.
+//   multifile: false
+//   pipeline_options: --output output.txt
+//   categories:
+//     - IO
+//     - Options

Review comment:
       ```suggestion
   //     - Combiners
   //     - Options
   ```

##########
File path: sdks/go/examples/forest/forest.go
##########
@@ -27,6 +27,19 @@
 // orders.
 package main
 
+// beam-playground:
+//   name: Forest
+//   description: An example that shows that pipeline construction is normal Go
+//     code -- the pipeline "forest" is created recursively and uses a global
+//     variable -- and that a pipeline may contain non-connected parts. The pipeline
+//     generated has the shape of a forest where the output of each singleton leaf
+//     is flattened together over several rounds. This is most clearly seen via a
+//     visual representation of the pipeline, such as the one produced by the 'dot' runner.
+//   multifile: false
+//   pipeline_options:
+//   categories:
+//     - Testing

Review comment:
       ```suggestion
   //     - Flatten
   //     - Branching
   ```

##########
File path: sdks/python/apache_beam/examples/wordcount.py
##########
@@ -19,6 +19,15 @@
 
 # pytype: skip-file
 
+# beam-playground:
+#   name: WordCount
+#   description: An example that counts words in Shakespeare's works.
+#   multifile: false
+#   pipeline_options: --output output.txt
+#   categories:
+#     - IO

Review comment:
       ```suggestion
   #     - Combiners
   ```

##########
File path: sdks/go/examples/multiout/multiout.go
##########
@@ -17,6 +17,18 @@
 // and writes 2 output files.
 package main
 
+// beam-playground:
+//   name: MultiOut
+//   description: An example that counts words in Shakespeare's works and writes 2 output files,
+//     -- big - for small words,
+//     -- small - for big words.
+//   multifile: false
+//   pipeline_options: --small sOutput.txt --big bOutput.txt
+//   categories:
+//     - IO
+//     - Options

Review comment:
       ```suggestion
   //     - Options
   //     - Branching
   ```

##########
File path: sdks/go/examples/stringsplit/stringsplit.go
##########
@@ -36,6 +36,14 @@
 // phrase "StringSplit Output".
 package main
 
+// beam-playground:
+//   name: StringSplit
+//   description: An example of using a Splittable DoFn in the Go SDK with a portable runner.
+//   multifile: false
+//   pipeline_options:
+//   categories:
+//     - Testing

Review comment:
       ```suggestion
   //     - Debugging
   //     - Flatten
   ```

##########
File path: examples/java/src/main/java/org/apache/beam/examples/cookbook/DistinctExample.java
##########
@@ -17,6 +17,18 @@
  */
 package org.apache.beam.examples.cookbook;
 
+// beam-playground:
+//   name: DistinctExample
+//   description: An example uses as input text of King Lear,
+//     by William Shakespeare as plain text files and removes
+//     duplicate lines across all the files.
+//   multifile: false
+//   pipeline_options: --output output.txt
+//   categories:
+//     - IO

Review comment:
       ```suggestion
   //     - Filtering
   ```

##########
File path: examples/java/src/main/java/org/apache/beam/examples/MinimalWordCount.java
##########
@@ -17,6 +17,15 @@
  */
 package org.apache.beam.examples;
 
+// beam-playground:
+//   name: MinimalWordCount
+//   description: An example that counts words in Shakespeare's works.
+//   multifile: false
+//   pipeline_options:
+//   categories:
+//     - IO
+//     - Options

Review comment:
       ```suggestion
   //     - Combiners
   //     - Filtering
   //     - IO
   //     - Core Transforms
   ```

##########
File path: sdks/go/examples/windowed_wordcount/windowed_wordcount.go
##########
@@ -34,6 +34,16 @@
 //  5. Accessing the window of an element
 package main
 
+// beam-playground:
+//   name: WindowedWordCount
+//   description: An example that counts words in text, and can run over either unbounded or bounded input collections.
+//   multifile: false
+//   pipeline_options: --output output.txt
+//   categories:
+//     - IO

Review comment:
       ```suggestion
   //     - Windowing
   ```

##########
File path: sdks/go/examples/minimal_wordcount/minimal_wordcount.go
##########
@@ -36,6 +37,15 @@
 // "wordcounts.txt" in your current working directory.
 package main
 
+// beam-playground:
+//   name: MinimalWordCount
+//   description: An example that counts words in King Lear,
+//     by William Shakespeare.
+//   multifile: false
+//   pipeline_options:
+//   categories:
+//     - IO

Review comment:
       ```suggestion
   //     - IO
   //     - Combiners
   //     - Core Transforms
   ```

##########
File path: sdks/python/apache_beam/examples/wordcount_debugging.py
##########
@@ -42,6 +42,16 @@
 
 # pytype: skip-file
 
+# beam-playground:
+#   name: WordCountDebugging
+#   description: An example that counts words in Shakespeare's works.
+#     includes regex filter("Flourish|stomach").
+#   multifile: false
+#   pipeline_options: --output output.txt
+#   categories:
+#     - IO

Review comment:
       ```suggestion
   #     - Flatten
   #     - Debugging
   ```

##########
File path: sdks/go/examples/debugging_wordcount/debugging_wordcount.go
##########
@@ -41,6 +41,15 @@
 // with --input.
 package main
 
+// beam-playground:
+//   name: DebuggingWordCount
+//   description: An example that counts words in Shakespeare's works includes regex filter("Flourish|stomach").
+//   multifile: false
+//   pipeline_options: --output output.txt
+//   categories:
+//     - IO
+//	   - Options

Review comment:
       ```suggestion
   //     - Options
   //     - Filtering
   //     - Debugging
   ```

##########
File path: sdks/go/examples/grades/grades.go
##########
@@ -15,6 +15,15 @@
 
 package main
 
+// beam-playground:
+//   name: Grades
+//   description: An example that combines grades data.
+//   multifile: false
+//   pipeline_options:
+//   categories:
+//     - Testing
+//     - Combiners

Review comment:
       ```suggestion
   //     - Debugging
   //     - Combiners
   //     - Filtering
   ```

##########
File path: sdks/python/apache_beam/examples/wordcount_minimal.py
##########
@@ -46,6 +46,15 @@
 
 # pytype: skip-file
 
+# beam-playground:
+#   name: WordCountMinimal
+#   description: An example that counts words in Shakespeare's works.
+#   multifile: false
+#   pipeline_options: --output output.txt
+#   categories:
+#     - IO

Review comment:
       ```suggestion
   #     - IO
   #     - Core Transforms
   #     - Flatten
   ```

##########
File path: sdks/python/apache_beam/examples/wordcount_debugging.py
##########
@@ -42,6 +42,16 @@
 
 # pytype: skip-file
 
+# beam-playground:
+#   name: WordCountDebugging
+#   description: An example that counts words in Shakespeare's works.
+#     includes regex filter("Flourish|stomach").
+#   multifile: false
+#   pipeline_options: --output output.txt
+#   categories:
+#     - IO
+#     - Options

Review comment:
       ```suggestion
   #     - Options
   #     - Combiners
   #     - Filtering
   ```

##########
File path: playground/categories.yaml
##########
@@ -30,3 +30,4 @@ categories:
   - Options
   - Coders
   - Stateful Processing
+  - Beam SQL

Review comment:
       ```suggestion
     - Beam SQL
     - Debugging
   ```

##########
File path: sdks/go/examples/wordcount/wordcount.go
##########
@@ -55,6 +55,15 @@
 // with --input.
 package main
 
+// beam-playground:
+//   name: WordCount
+//   description: An example that counts words in Shakespeare's works.
+//   multifile: false
+//   pipeline_options: --output output.txt
+//   categories:
+//     - IO

Review comment:
       ```suggestion
   //     - Combiners
   ```

##########
File path: sdks/python/apache_beam/examples/wordcount_with_metrics.py
##########
@@ -19,6 +19,16 @@
 
 # pytype: skip-file
 
+# beam-playground:
+#   name: WordCountWithMetrics
+#   description: A word-counting workflow with metrics.
+#   multifile: false
+#   pipeline_options: --output output.txt
+#   categories:
+#     - IO

Review comment:
       ```suggestion
   #     - Combiners
   ```

##########
File path: examples/java/src/main/java/org/apache/beam/examples/DebuggingWordCount.java
##########
@@ -17,6 +17,16 @@
  */
 package org.apache.beam.examples;
 
+// beam-playground:
+//   name: DebuggingWordCount
+//   description: An example that counts words in Shakespeare/kinglear.txt includes regex
+//     filter("Flourish|stomach").
+//   multifile: false
+//   pipeline_options: --output output.txt
+//   categories:
+//     - IO
+//     - Options

Review comment:
       @pavel-avilov could we add debugging to categories? To categorize examples with debug logs 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org