You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2026/09/20 11:09:18 UTC
[PR] Tests: Hamcrest matchers for string contains/empty checks [poi]
pjfanning opened a new pull request, #1315:
URL: https://github.com/apache/poi/pull/1315
Follow-up to the recent test PRs: the three remaining `assertTrue`/`assertFalse` calls that wrap a `String.contains(...)` or `isEmpty()` now use Hamcrest matchers, so a failure shows the string that was inspected instead of just `expected: <true> but was: <false>`.
- `TestXWPFRun.addChartEscapesRelationshipId`: `assertThat(xml, not(containsString("<evil>")))` and `assertThat(..., containsString("rId42"))`
- `XSSFSharedFormulaFixture.assertSharedFormulas`: `assertThat(f.getStringValue(), not(emptyString()))`
Test-only change; `TestXWPFRun` (46) and `TestXSSFFormulaEvaluatorCacheNotificationSharedFormulas` (18) pass locally.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [PR] Tests: Hamcrest matchers for string contains/empty checks [poi]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #1315:
URL: https://github.com/apache/poi/pull/1315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org