[GitHub] asdf2014 commented on a change in pull request #7035: Improve error message for revoked locks

[GitBox <gi...@apache.org>]

asdf2014 commented on a change in pull request #7035: Improve error message for revoked locks
URL: https://github.com/apache/incubator-druid/pull/7035#discussion_r255387360
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/indexing/overlord/SegmentPublishResult.java
 ##########
 @@ -100,6 +118,7 @@ public String toString()
     return "SegmentPublishResult{" +
            "segments=" + segments +
            ", success=" + success +
+           ", exception=" + errorMsg +
 
 Review comment:
   Maybe we should keep the original name of the member variable and enclose the string `errorMsg` with single quotes.
   
   ```java
   @Override
   public String toString()
   {
     return "SegmentPublishResult{" +
            "segments=" + segments +
            ", success=" + success +
            ", errorMsg='" + errorMsg + '\'' +
            '}';
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org