You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2026/07/08 15:49:47 UTC
(superset) branch chore/upgrade-ag-grid-36 created (now 35ad8dd6171)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a change to branch chore/upgrade-ag-grid-36
in repository https://gitbox.apache.org/repos/asf/superset.git
at 35ad8dd6171 chore(deps): upgrade ag-grid to 36.0.0 across frontend + superset-ui-core
This branch includes the following new commits:
new 35ad8dd6171 chore(deps): upgrade ag-grid to 36.0.0 across frontend + superset-ui-core
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(superset) 01/01: chore(deps): upgrade ag-grid to 36.0.0 across frontend + superset-ui-core
Posted by ru...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch chore/upgrade-ag-grid-36
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 35ad8dd6171ebf1cd3f2bf0125d85d30da7306f3
Author: Evan Rusackas <ev...@rusackas.com>
AuthorDate: Wed Jul 8 08:49:25 2026 -0700
chore(deps): upgrade ag-grid to 36.0.0 across frontend + superset-ui-core
Bumps ag-grid-community and ag-grid-react from 35.3.1 to 36.0.0 in both
places they are declared (superset-frontend and packages/superset-ui-core),
in a single change against the shared root lockfile, instead of the four
separate per-package Dependabot bumps which each left a community/react
version mismatch and failed CI.
v36 findings:
- Compiles cleanly under our TypeScript 5.4.5 (no type-def breakage), though
v36 docs recommend >=5.8.3.
- All modules we register (incl. ClientSideRowModelModule, ValidationModule),
re-exported types, and theming API params still exist in v36 — no source
changes needed.
- v36 renames some DOM container classes; updated three stale selectors in
the ag-grid-table test (.ag-floating-bottom -> .ag-grid-pinned-bottom-rows,
.ag-body-viewport / .ag-center-cols-container -> .ag-grid-viewport). Two of
those had been passing only because the stale selector matched nothing.
- Pulls two new transitive deps from the v36 module split: ag-stack@36.0.0
and ag-charts-types@14.0.0.
Closes #41676
Closes #41674
Closes #41668
Closes #41667
Co-Authored-By: Claude Opus 4.8 <no...@anthropic.com>
---
superset-frontend/package-lock.json | 37 +++++++++++++---------
superset-frontend/package.json | 4 +--
.../packages/superset-ui-core/package.json | 4 +--
.../test/AgGridTableChart.test.tsx | 18 +++++++----
4 files changed, 37 insertions(+), 26 deletions(-)
diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json
index 03c570b527d..93254f5adb0 100644
--- a/superset-frontend/package-lock.json
+++ b/superset-frontend/package-lock.json
@@ -81,8 +81,8 @@
"@visx/scale": "^4.0.0",
"@visx/tooltip": "^4.0.0",
"@visx/xychart": "^4.0.0",
- "ag-grid-community": "35.3.1",
- "ag-grid-react": "35.3.1",
+ "ag-grid-community": "36.0.0",
+ "ag-grid-react": "36.0.0",
"antd": "^5.26.0",
"chrono-node": "^2.9.1",
"classnames": "^2.2.5",
@@ -13663,27 +13663,28 @@
"license": "MIT"
},
"node_modules/ag-charts-types": {
- "version": "13.3.1",
- "resolved": "https://registry.npmjs.org/ag-charts-types/-/ag-charts-types-13.3.1.tgz",
- "integrity": "sha512-m37eUe4g//swvGh8PWMlYQH3gknjSsPeW4sQwBhM3/auGAHmN0wvxEWlrdAn98pBPg4HoKbtOy+yf7gPCYsnvQ==",
+ "version": "14.0.0",
+ "resolved": "https://registry.npmjs.org/ag-charts-types/-/ag-charts-types-14.0.0.tgz",
+ "integrity": "sha512-89X4J/OeOTzTp505126JayGEn3k6QUKz3UHSR0/ggoVZYzVqtMN13k/B136S1+YBwgnzyJ/NARnnIRTPWsWG9g==",
"license": "MIT"
},
"node_modules/ag-grid-community": {
- "version": "35.3.1",
- "resolved": "https://registry.npmjs.org/ag-grid-community/-/ag-grid-community-35.3.1.tgz",
- "integrity": "sha512-Wmkd/xYTCbAApcZZO74nBggZCnd/oX753NY3MJ4zYARVpfBHRWWhIBJ2sFTFKbDWwHZOWsx3YT9+kkyeuyLKlw==",
+ "version": "36.0.0",
+ "resolved": "https://registry.npmjs.org/ag-grid-community/-/ag-grid-community-36.0.0.tgz",
+ "integrity": "sha512-73PeuoG1Pofi6o1o2dYd092m5AdCt0uq/iCaVTCxLw9eRJGLZu0I+HICReolUmUH7A5X+CnYDXiE+P9S8dUqCQ==",
"license": "MIT",
"dependencies": {
- "ag-charts-types": "13.3.1"
+ "ag-charts-types": "14.0.0",
+ "ag-stack": "36.0.0"
}
},
"node_modules/ag-grid-react": {
- "version": "35.3.1",
- "resolved": "https://registry.npmjs.org/ag-grid-react/-/ag-grid-react-35.3.1.tgz",
- "integrity": "sha512-M3ljCQyGL+qzoyPN0BYrn4eAlgZr6Ailcjd8+a7OcneSiVsMNSJb/gTkIMUwmYivkPLIA8EEJ4hTxxKSaya6mQ==",
+ "version": "36.0.0",
+ "resolved": "https://registry.npmjs.org/ag-grid-react/-/ag-grid-react-36.0.0.tgz",
+ "integrity": "sha512-ShmynyRQDoxuXBso+kPliZJnivQKwBG/EGclCBV3dg98ou2kq7yxdgf8DhrW4uM5SekNDaqor4Gn9OAGtH2o3g==",
"license": "MIT",
"dependencies": {
- "ag-grid-community": "35.3.1",
+ "ag-grid-community": "36.0.0",
"prop-types": "^15.8.1"
},
"peerDependencies": {
@@ -13691,6 +13692,12 @@
"react-dom": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0"
}
},
+ "node_modules/ag-stack": {
+ "version": "36.0.0",
+ "resolved": "https://registry.npmjs.org/ag-stack/-/ag-stack-36.0.0.tgz",
+ "integrity": "sha512-ciXqjZygVLk3tnZWOAQyOxP48Ju2ZmaSAtIebekXJwHqA7vB+NJ8ZME/O4XTRpInTSHn2KSu/KTxgWJO8dduiw==",
+ "license": "MIT"
+ },
"node_modules/agent-base": {
"version": "7.1.4",
"resolved": "https://registry.npmjs.org/agent-base/-/agent-base-7.1.4.tgz",
@@ -41861,8 +41868,8 @@
"@types/json-bigint": "^1.0.4",
"@visx/responsive": "^4.0.0",
"ace-builds": "^1.44.0",
- "ag-grid-community": "35.3.1",
- "ag-grid-react": "35.3.1",
+ "ag-grid-community": "36.0.0",
+ "ag-grid-react": "36.0.0",
"brace": "^0.11.1",
"classnames": "^2.5.1",
"core-js": "^3.49.0",
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
index 67ebc104d57..104c14f60e3 100644
--- a/superset-frontend/package.json
+++ b/superset-frontend/package.json
@@ -164,8 +164,8 @@
"@visx/scale": "^4.0.0",
"@visx/tooltip": "^4.0.0",
"@visx/xychart": "^4.0.0",
- "ag-grid-community": "35.3.1",
- "ag-grid-react": "35.3.1",
+ "ag-grid-community": "36.0.0",
+ "ag-grid-react": "36.0.0",
"antd": "^5.26.0",
"chrono-node": "^2.9.1",
"classnames": "^2.2.5",
diff --git a/superset-frontend/packages/superset-ui-core/package.json b/superset-frontend/packages/superset-ui-core/package.json
index 29c9e1d1914..a2ac965fa37 100644
--- a/superset-frontend/packages/superset-ui-core/package.json
+++ b/superset-frontend/packages/superset-ui-core/package.json
@@ -31,8 +31,8 @@
"@types/json-bigint": "^1.0.4",
"@visx/responsive": "^4.0.0",
"ace-builds": "^1.44.0",
- "ag-grid-community": "35.3.1",
- "ag-grid-react": "35.3.1",
+ "ag-grid-community": "36.0.0",
+ "ag-grid-react": "36.0.0",
"brace": "^0.11.1",
"classnames": "^2.5.1",
"core-js": "^3.49.0",
diff --git a/superset-frontend/plugins/plugin-chart-ag-grid-table/test/AgGridTableChart.test.tsx b/superset-frontend/plugins/plugin-chart-ag-grid-table/test/AgGridTableChart.test.tsx
index 9e233e53543..f09e9cb2bf8 100644
--- a/superset-frontend/plugins/plugin-chart-ag-grid-table/test/AgGridTableChart.test.tsx
+++ b/superset-frontend/plugins/plugin-chart-ag-grid-table/test/AgGridTableChart.test.tsx
@@ -223,11 +223,13 @@ test('AgGridTableChart renders with totals', async () => {
expect(grid).toBeInTheDocument();
});
- const pinnedRows = document.querySelectorAll('.ag-floating-bottom .ag-row');
+ const pinnedRows = document.querySelectorAll(
+ '.ag-grid-pinned-bottom-rows .ag-row',
+ );
expect(pinnedRows.length).toBeGreaterThan(0);
const dataRows = document.querySelectorAll(
- '.ag-body-viewport .ag-row:not(.ag-row-pinned)',
+ '.ag-grid-viewport .ag-row:not(.ag-row-pinned)',
);
expect(dataRows.length).toBe(3);
});
@@ -252,9 +254,7 @@ test('AgGridTableChart handles empty data', async () => {
expect(grid).toBeInTheDocument();
});
- const dataRows = document.querySelectorAll(
- '.ag-center-cols-container .ag-row',
- );
+ const dataRows = document.querySelectorAll('.ag-grid-viewport .ag-row');
expect(dataRows.length).toBe(0);
const headerCells = document.querySelectorAll('.ag-header-cell');
@@ -696,7 +696,9 @@ test('AgGridTableChart pins no summary row when totals come back empty', async (
expect(document.querySelector('.ag-container')).toBeInTheDocument();
});
- const pinnedRows = document.querySelectorAll('.ag-floating-bottom .ag-row');
+ const pinnedRows = document.querySelectorAll(
+ '.ag-grid-pinned-bottom-rows .ag-row',
+ );
expect(pinnedRows.length).toBe(0);
});
@@ -726,7 +728,9 @@ test('AgGridTableChart pins no summary row when totals are absent', async () =>
expect(document.querySelector('.ag-container')).toBeInTheDocument();
});
- const pinnedRows = document.querySelectorAll('.ag-floating-bottom .ag-row');
+ const pinnedRows = document.querySelectorAll(
+ '.ag-grid-pinned-bottom-rows .ag-row',
+ );
expect(pinnedRows.length).toBe(0);
});