[GitHub] [incubator-uniffle] leixm commented on pull request #1171: [#1163] improvement(netty): return the direct byte buffer when getting localfile data by using netty

["leixm (via GitHub)" <gi...@apache.org>]

leixm commented on PR #1171:
URL: https://github.com/apache/incubator-uniffle/pull/1171#issuecomment-1702166208

   @pegasas  In fact, this line of code in getShuffleData#transferTo method `channel.write(buffer.convertToNetty())` will use zero-copy api, we should keep using `FileSegmentManagedBuffer` instead of `NettyManagedBuffer`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org