You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/07/18 03:22:33 UTC

[GitHub] [phoenix] ChinmaySKulkarni opened a new pull request #834: PHOENIX-6026: Fix BackwardCompatibilityIT so it can run locally

ChinmaySKulkarni opened a new pull request #834:
URL: https://github.com/apache/phoenix/pull/834


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #834: PHOENIX-6026: Fix BackwardCompatibilityIT so it can run locally

Posted by GitBox <gi...@apache.org>.
ChinmaySKulkarni commented on a change in pull request #834:
URL: https://github.com/apache/phoenix/pull/834#discussion_r457780454



##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/BackwardCompatibilityIT.java
##########
@@ -118,6 +125,7 @@ public synchronized void doSetup() throws Exception {
         zkQuorum = "localhost:" + hbaseTestUtil.getZkCluster().getClientPort();
         url = PhoenixRuntime.JDBC_PROTOCOL + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + zkQuorum;
         DriverManager.registerDriver(PhoenixDriver.INSTANCE);
+        checkForPreConditions();

Review comment:
       Yes that's what is happening. This is now called in `doSetup()` which will be invoked before each test i.e. it is marked as `@Before`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix] sguggilam commented on a change in pull request #834: PHOENIX-6026: Fix BackwardCompatibilityIT so it can run locally

Posted by GitBox <gi...@apache.org>.
sguggilam commented on a change in pull request #834:
URL: https://github.com/apache/phoenix/pull/834#discussion_r457775327



##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/BackwardCompatibilityIT.java
##########
@@ -118,6 +125,7 @@ public synchronized void doSetup() throws Exception {
         zkQuorum = "localhost:" + hbaseTestUtil.getZkCluster().getClientPort();
         url = PhoenixRuntime.JDBC_PROTOCOL + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + zkQuorum;
         DriverManager.registerDriver(PhoenixDriver.INSTANCE);
+        checkForPreConditions();

Review comment:
       We need to have this before each test as it checks for the non existence of any SYSTEM tables before each test run to make sure that there is no existing metadata




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix] sguggilam commented on a change in pull request #834: PHOENIX-6026: Fix BackwardCompatibilityIT so it can run locally

Posted by GitBox <gi...@apache.org>.
sguggilam commented on a change in pull request #834:
URL: https://github.com/apache/phoenix/pull/834#discussion_r457781379



##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/BackwardCompatibilityIT.java
##########
@@ -118,6 +125,7 @@ public synchronized void doSetup() throws Exception {
         zkQuorum = "localhost:" + hbaseTestUtil.getZkCluster().getClientPort();
         url = PhoenixRuntime.JDBC_PROTOCOL + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + zkQuorum;
         DriverManager.registerDriver(PhoenixDriver.INSTANCE);
+        checkForPreConditions();

Review comment:
       Makes sense, thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix] sguggilam commented on pull request #834: PHOENIX-6026: Fix BackwardCompatibilityIT so it can run locally

Posted by GitBox <gi...@apache.org>.
sguggilam commented on pull request #834:
URL: https://github.com/apache/phoenix/pull/834#issuecomment-661528276


   Just one comment, else looks good to me


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix] ChinmaySKulkarni closed pull request #834: PHOENIX-6026: Fix BackwardCompatibilityIT so it can run locally

Posted by GitBox <gi...@apache.org>.
ChinmaySKulkarni closed pull request #834:
URL: https://github.com/apache/phoenix/pull/834


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org