[jira] [Commented] (AIRFLOW-3819) k8s executor - Allow the configuration of a global default for pod resource request/limits

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114144#comment-17114144 ] 

ASF GitHub Bot commented on AIRFLOW-3819:
-----------------------------------------

tylux commented on pull request #4660:
URL: https://github.com/apache/airflow/pull/4660#issuecomment-632749722


   Can this get revisited? This goes against Kubernetes best practices to rely on a different mechanism i.e dag code to set the resource limits instead of standard pod limits. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> k8s executor - Allow the configuration of a global default for pod resource request/limits 
> -------------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-3819
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3819
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: executors
>    Affects Versions: 1.10.2
>            Reporter: afusr
>            Priority: Minor
>              Labels: kubernetes
>
> Currently the kubernetes executor allows you to specify pod resources requests and limits (cpu and memory). For example:
> {noformat}
> # Limit resources on this operator/task with node affinity & tolerations
> three_task = PythonOperator(
>     task_id="three_task", python_callable=print_stuff, dag=dag,
>     executor_config={
>         "KubernetesExecutor": {"request_memory": "128Mi",
>                                "limit_memory": "128Mi",
>                                "tolerations": tolerations,
>                                "affinity": affinity}}
> )
> {noformat}
> These values are used by kubernetes when making scaling decisions. It would be nice to be able to specify a global default for these values, to ensure that each pod airflow creates has a value specified for these properties. 
> There is still the requirement to override these values on a dag by dag basis. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)