You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2017/12/01 04:24:45 UTC

[GitHub] spark pull request #19854: SPARK-22660:Use position() and limit() to fix amb...

Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19854#discussion_r154265720
  
    --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala ---
    @@ -296,7 +296,8 @@ class KafkaTestUtils(withBrokerProps: Map[String, Object] = Map.empty) extends L
         props.put("replica.socket.timeout.ms", "1500")
         props.put("delete.topic.enable", "true")
         props.put("offsets.topic.num.partitions", "1")
    -    props.putAll(withBrokerProps.asJava)
    +    // props.putAll(withBrokerProps.asJava)
    +    withBrokerProps.foreach{ case (k, v) => props.put(k, v) }
    --- End diff --
    
    Is this related?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org