[GitHub] [orc] guiyanakuang commented on a diff in pull request #1574: ORC-1473: Fix zero copy read bugs

["guiyanakuang (via GitHub)" <gi...@apache.org>]

guiyanakuang commented on code in PR #1574:
URL: https://github.com/apache/orc/pull/1574#discussion_r1319297862


##########
java/core/src/java/org/apache/orc/impl/RecordReaderUtils.java:
##########
@@ -131,11 +131,21 @@ public boolean isTrackingDiskRanges() {
       return zcr != null;
     }
 
+    /**
+     * @deprecated Use {@link #releaseAllBuffers()} instead. This method was
+     * incorrectly added and shouldn't be used anymore.
+     */
+    @Deprecated
     @Override
     public void releaseBuffer(ByteBuffer buffer) {

Review Comment:
   External systems may use this interface, e.g. hive llap, could you reconfirm that this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org