[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6131: Unify the service name rule in `metadata-service-mapping.yml` of `mx-…

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #6131:
URL: https://github.com/apache/skywalking/pull/6131#discussion_r551758970



##########
File path: .github/workflows/e2e.istio.yaml
##########
@@ -71,13 +71,15 @@ jobs:
           cd skywalking-kubernetes
           git reset --hard dd749f25913830c47a97430618cefc4167612e75
           cd chart
+          mkdir -p skywalking/files/conf.d/oap/ && echo 'serviceName: e2e::${LABELS.app}\nserviceInstanceName: ${NAME}' > skywalking/files/conf.d/oap/metadata-service-mapping.yaml
           helm dep up skywalking
           helm -n istio-system install skywalking skywalking \
                --set fullnameOverride=skywalking \
                --set elasticsearch.replicas=1 \
                --set elasticsearch.minimumMasterNodes=1 \
                --set elasticsearch.imageTag=7.5.1 \
                --set oap.env.SW_ENVOY_METRIC_ALS_HTTP_ANALYSIS=${{ matrix.analyzer }} \
+               --set oap.env.K8S_SERVICE_NAME_RULE='e2e::${service.metadata.name}' \

Review comment:
       This config only takes effect in the `k8s-mesh` case, because we share the same `expected.data.yaml` between `k8s-mesh` and `mx-mesh`, so I just add the group to `k8s-mesh` case




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org