You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/07/06 08:57:37 UTC
[GitHub] [kafka] dajac opened a new pull request #8985: MINOR; alterReplicaLogDirs should not fail all the futures when only one call fails
dajac opened a new pull request #8985:
URL: https://github.com/apache/kafka/pull/8985
I have noticed that `alterReplicaLogDirs` fails all the unrealised futures when one of the call sent out fails (e.g. timeout). So if two calls A and B are sent out, if A fails before B comes back, all the futures are failed even if B is successful. I think that each call should realised their related futures only.
This PR adds a unit test to reproduce the issue and fix it.
It seems that other calls may suffer from the same issue. I will review them and open other PRs.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #8985: MINOR; KafkaAdminClient#alterReplicaLogDirs should not fail all the futures when only one call fails
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #8985:
URL: https://github.com/apache/kafka/pull/8985#issuecomment-655567477
Jenkins looks good. There were one unrelated failed test during the JDK 14 and Scala 2.13 run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8985: MINOR; KafkaAdminClient#alterReplicaLogDirs should not fail all the futures when only one call fails
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8985:
URL: https://github.com/apache/kafka/pull/8985#issuecomment-654484579
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe merged pull request #8985: MINOR; KafkaAdminClient#alterReplicaLogDirs should not fail all the futures when only one call fails
Posted by GitBox <gi...@apache.org>.
cmccabe merged pull request #8985:
URL: https://github.com/apache/kafka/pull/8985
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #8985: MINOR; KafkaAdminClient#alterReplicaLogDirs should not fail all the futures when only one call fails
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #8985:
URL: https://github.com/apache/kafka/pull/8985#issuecomment-654912275
good find, @dajac! LGTM pending Jenkins
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org