You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/01 13:12:06 UTC
[GitHub] [spark] MaxGekk commented on a change in pull request #28091:
[WIP][SQL] Optimize fromJavaDate() and toJavaDate()
MaxGekk commented on a change in pull request #28091: [WIP][SQL] Optimize fromJavaDate() and toJavaDate()
URL: https://github.com/apache/spark/pull/28091#discussion_r401603109
##########
File path: sql/core/benchmarks/DateTimeRebaseBenchmark-jdk11-results.txt
##########
@@ -59,36 +59,36 @@ OpenJDK 64-Bit Server VM 11.0.6+10-post-Ubuntu-1ubuntu118.04.1 on Linux 4.15.0-1
Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
Save dates to ORC: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-after 1582, noop 9295 9295 0 10.8 93.0 1.0X
-before 1582, noop 9352 9352 0 10.7 93.5 1.0X
-after 1582 17112 17112 0 5.8 171.1 0.5X
-before 1582 17979 17979 0 5.6 179.8 0.5X
+after 1582, noop 9250 9250 0 10.8 92.5 1.0X
+before 1582, noop 9522 9522 0 10.5 95.2 1.0X
+after 1582 16377 16377 0 6.1 163.8 0.6X
+before 1582 17274 17274 0 5.8 172.7 0.5X
OpenJDK 64-Bit Server VM 11.0.6+10-post-Ubuntu-1ubuntu118.04.1 on Linux 4.15.0-1063-aws
Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
Load dates from ORC: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-after 1582, vec off 20874 20905 38 4.8 208.7 1.0X
-after 1582, vec on 3813 3844 28 26.2 38.1 5.5X
-before 1582, vec off 25912 25949 38 3.9 259.1 0.8X
-before 1582, vec on 4322 4343 19 23.1 43.2 4.8X
+after 1582, vec off 14060 14251 193 7.1 140.6 1.0X
Review comment:
@cloud-fan Read results look good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org