Re: [PR] [Improvement][Helm] Refactor configmap control in master [dolphinscheduler]

["pegasas (via GitHub)" <gi...@apache.org>]

pegasas commented on code in PR #15935:
URL: https://github.com/apache/dolphinscheduler/pull/15935#discussion_r1584089676


##########
deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-master.yaml:
##########
@@ -109,11 +109,9 @@ spec:
           volumeMounts:
             - mountPath: "/opt/dolphinscheduler/logs"
               name: {{ include "dolphinscheduler.fullname" . }}-master
-            {{- include "dolphinscheduler.sharedStorage.volumeMount" . | nindent 12 }}
             - name: config-volume
               mountPath: /opt/dolphinscheduler/conf/common.properties
               subPath: common.properties
-            {{- include "dolphinscheduler.etcd.ssl.volumeMount" . | nindent 12 }}

Review Comment:
   it seems this is also needed in `api`, 
   so I kept this and adjust the order to make it clear to read. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org