[GitHub] [arrow-adbc] zeroshade commented on a diff in pull request #700: feat(go/adbc/driver/flightsql): add StatementExecuteSchema

["zeroshade (via GitHub)" <gi...@apache.org>]

zeroshade commented on code in PR #700:
URL: https://github.com/apache/arrow-adbc/pull/700#discussion_r1245495875


##########
go/adbc/driver/flightsql/flightsql_adbc.go:
##########
@@ -369,14 +370,63 @@ func (d *database) SetOptions(cnOptions map[string]string) error {
 			continue
 		}
 		return adbc.Error{
-			Msg:  fmt.Sprintf("Unknown database option '%s'", key),
+			Msg:  fmt.Sprintf("[Flight SQL] Unknown database option '%s'", key),
 			Code: adbc.StatusInvalidArgument,
 		}
 	}
 
 	return nil
 }
 
+func (d *database) GetOption(key string) (string, error) {

Review Comment:
   Do we want to default implement this with all the options that are accepted in `SetOptions`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org