You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mxm <gi...@git.apache.org> on 2016/06/29 18:30:25 UTC

[GitHub] flink pull request #2187: [FLINK-3675][yarn] improvements to library shippin...

GitHub user mxm opened a pull request:

    https://github.com/apache/flink/pull/2187

    [FLINK-3675][yarn] improvements to library shipping

    - always ship the lib folder
    - properly setup the classpath from the supplied ship files
    - cleanup deploy() method of YarnClusterDescriptor
    - add test case

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mxm/flink FLINK-3675

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2187.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2187
    
----
commit 1dbaa5a91ae8ae3f50ed26d4a51ec57bb28bc77e
Author: Maximilian Michels <mx...@apache.org>
Date:   2016-06-27T13:13:56Z

    [FLINK-3675][yarn] improvements to library shipping
    
    - always ship the lib folder
    - properly setup the classpath from the supplied ship files
    - cleanup deploy() method of YarnClusterDescriptor
    - add test case

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2187: [FLINK-3675][yarn] improvements to library shipping

Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the issue:

    https://github.com/apache/flink/pull/2187
  
    I moved one existing environment variable `FLINK_CONF_DIR` to `ConfigConstants`. I added the `FLINK_LIB_DIR` environment variable to load a library folder (optional). I'm not sure whether we should add them to the documentation since they are set by the bash scripts and shouldn't be exposed to the user.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2187: [FLINK-3675][yarn] improvements to library shipping

Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:

    https://github.com/apache/flink/pull/2187
  
    Change looks good! +1 to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2187: [FLINK-3675][yarn] improvements to library shippin...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/2187


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2187: [FLINK-3675][yarn] improvements to library shipping

Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the issue:

    https://github.com/apache/flink/pull/2187
  
    All builds are passing in my branch: https://travis-ci.org/mxm/flink/builds/141155293
    
    CC @rmetzger 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2187: [FLINK-3675][yarn] improvements to library shipping

Posted by stefanobaghino <gi...@git.apache.org>.
Github user stefanobaghino commented on the issue:

    https://github.com/apache/flink/pull/2187
  
    Awesome, thanks for addressing the issue�@mxm! I noticed you added a couple of environment variables, could it make sense to document them?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---