You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (JIRA)" <ji...@apache.org> on 2014/12/05 07:10:13 UTC

[jira] [Commented] (BOOKKEEPER-794) BookkeeperProtocol.Response.status is completely ignored

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235144#comment-14235144 ] 

Sijie Guo commented on BOOKKEEPER-794:
--------------------------------------

I don't understand this ticket. for old client, it doesn't support auth, why new client would send auth failed status code? the auth stuff should only exists in new client, right? since it is the new feature introduce in the new version.

or do you mind generate a patch or github branch? that I could take a look at what is exactly the issue?

> BookkeeperProtocol.Response.status is completely ignored
> --------------------------------------------------------
>
>                 Key: BOOKKEEPER-794
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-794
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>             Fix For: 4.4.0
>
>
> As the summary says, if you set the status to anything but ok, it will be ignored by PerChannelBookieClient. If you try to handle it, a whole load of tests fail due to different mapping for read and write requests.
> I'm running this while rebasing our auth stuff, which i'll push up when it's been validated. I means the auth stuff needs to be aware of all message types, as I can't just send a EUA error in the packet level status.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)