[GitHub] [iceberg] openinx commented on a change in pull request #2875: Core: added includeColumnStats option in FindFiles API

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #2875:
URL: https://github.com/apache/iceberg/pull/2875#discussion_r678030557



##########
File path: core/src/main/java/org/apache/iceberg/FindFiles.java
##########
@@ -206,7 +212,8 @@ public Builder inPartitions(PartitionSpec spec, List<StructLike> partitions) {
           .caseSensitive(caseSensitive)
           .entries();
 
-      return CloseableIterable.transform(entries, entry -> entry.file().copyWithoutStats());
+      return CloseableIterable.transform(entries,
+          entry -> includeColumnStats ? entry.file().copy() : entry.file().copyWithoutStats());

Review comment:
       Thanks @Flyangz for contributing,  but I don't think adding an option without any test case verification is the correct practice.  I think you can read this [PR](https://github.com/apache/iceberg/pull/206/files) to add the `includeColumnStats` in FindFiles API.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org