You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by sa...@apache.org on 2013/11/06 19:04:57 UTC
git commit: updated refs/heads/master to 40a7839
Updated Branches:
refs/heads/master 0ec6b9ac9 -> 40a783932
CLOUDSTACK-5061 - Cloudstack doesn't consider storage overprovisioning factor when using thin Provisioning over VMWare VMFS datastores
Fix is use the storage overprovisioning factor (global configuration parameter "storage.overprovisioning.factor") to calculate total provisioning capacity for storage space allocation over VMFS based storage pools as well.
There are two level of thin provisioning provided in VMware, storage level and file-level (VMDK) thin provisioning. in CloudStack, all volumes are provisioned with thin VMDK format, so at hypervisor level, we ALWAYS do thin provisioning. If storage vendor has the ability to provide storage level thin provisioning in addition to VMDK thin provisioning, it is also allowed since it is transparent to Cloudstack.
Signed-off-by: Sateesh Chodapuneedi <sa...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/40a78393
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/40a78393
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/40a78393
Branch: refs/heads/master
Commit: 40a78393235f44bb0f96b8055fc11139c8866915
Parents: 0ec6b9a
Author: Sateesh Chodapuneedi <sa...@apache.org>
Authored: Wed Nov 6 17:37:22 2013 +0530
Committer: Sateesh Chodapuneedi <sa...@apache.org>
Committed: Wed Nov 6 17:47:40 2013 +0530
----------------------------------------------------------------------
.../src/com/cloud/storage/StorageManagerImpl.java | 17 ++++-------------
1 file changed, 4 insertions(+), 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/40a78393/server/src/com/cloud/storage/StorageManagerImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/storage/StorageManagerImpl.java b/server/src/com/cloud/storage/StorageManagerImpl.java
index a301639..e42d871 100755
--- a/server/src/com/cloud/storage/StorageManagerImpl.java
+++ b/server/src/com/cloud/storage/StorageManagerImpl.java
@@ -875,19 +875,10 @@ public class StorageManagerImpl extends ManagerBase implements StorageManager, C
List<CapacityVO> capacities = _capacityDao.search(capacitySC, null);
long totalOverProvCapacity;
- if (storagePool.getPoolType() == StoragePoolType.NetworkFilesystem) {
+ if (storagePool.getPoolType() == StoragePoolType.NetworkFilesystem || storagePool.getPoolType() == StoragePoolType.VMFS) {
BigDecimal overProvFactor = getStorageOverProvisioningFactor(storagePool.getDataCenterId());
- totalOverProvCapacity = overProvFactor.multiply(new BigDecimal(storagePool.getCapacityBytes())).longValue();// All
- // this
- // for
- // the
- // inaccuracy
- // of
- // floats
- // for
- // big
- // number
- // multiplication.
+ totalOverProvCapacity = overProvFactor.multiply(new BigDecimal(storagePool.getCapacityBytes())).longValue();
+ // All this is for the inaccuracy of floats for big number multiplication.
} else {
totalOverProvCapacity = storagePool.getCapacityBytes();
}
@@ -1596,7 +1587,7 @@ public class StorageManagerImpl extends ManagerBase implements StorageManager, C
}
long totalOverProvCapacity;
- if (pool.getPoolType() == StoragePoolType.NetworkFilesystem) {
+ if (pool.getPoolType() == StoragePoolType.NetworkFilesystem || pool.getPoolType() == StoragePoolType.VMFS) {
totalOverProvCapacity = getStorageOverProvisioningFactor(pool.getDataCenterId()).multiply(new BigDecimal(pool.getCapacityBytes()))
.longValue();
} else {