You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/09/24 11:22:00 UTC

[GitHub] [incubator-iotdb] nlosilva1 commented on a change in pull request #416: [IOTDB-188] Delete storage group

nlosilva1 commented on a change in pull request #416: [IOTDB-188] Delete storage group
URL: https://github.com/apache/incubator-iotdb/pull/416#discussion_r327559124
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
 ##########
 @@ -1152,7 +1152,21 @@ public TSStatus setStorageGroup(String storageGroup) throws TException {
   }
 
   @Override
-  public TSStatus createTimeseries(TSCreateTimeseriesReq req) {
+  public TSStatus deleteStorageGroup(TSDeleteDataReq req) {
+    if (!checkLogin()) {
+      logger.info(INFO_NOT_LOGIN, IoTDBConstant.GLOBAL_DB_NAME);
+      return new TSStatus(getStatus(TSStatusCode.NOT_LOGIN_ERROR));
+    }
+    MetadataPlan plan = new MetadataPlan(MetadataOperator.NamespaceType.DELETE_STORAGE_GROUP,new Path(req.getPaths().get(0)));
 
 Review comment:
   As the issue defined in IOTDB-188, I just need to delete a single storage group at the same time, and Qiaojialin said to me that before we complete the batch deletion of storage groups, we should change some of the structure of the Metadata, so he suggested me to submit this version first.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services