[GitHub] [spark] srowen commented on a diff in pull request #40808: [SPARK-43138][CORE]: Fix ClassNotFoundException during migration

["srowen (via GitHub)" <gi...@apache.org>]

srowen commented on code in PR #40808:
URL: https://github.com/apache/spark/pull/40808#discussion_r1188658492


##########
core/src/main/scala/org/apache/spark/network/netty/NettyBlockTransferService.scala:
##########
@@ -51,6 +51,7 @@ import org.apache.spark.util.Utils
 private[spark] class NettyBlockTransferService(
     conf: SparkConf,
     securityManager: SecurityManager,
+    serializerManager: SerializerManager,

Review Comment:
   Can the class just instantiate a Java serializer internally rather than have the caller pass it all the time? or I'm missing that it's not always the same serializer, or has to be from the caller.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org