You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/07/17 16:11:00 UTC

[GitHub] [geode] kirklund opened a new pull request #5382: GEODE-8368: Upgrade ClassGraph from 4.8.52 to 4.8.87

kirklund opened a new pull request #5382:
URL: https://github.com/apache/geode/pull/5382


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] kirklund commented on pull request #5382: GEODE-8368: Upgrade ClassGraph from 4.8.52 to 4.8.87

Posted by GitBox <gi...@apache.org>.
kirklund commented on pull request #5382:
URL: https://github.com/apache/geode/pull/5382#issuecomment-673128651


   I don't have time for this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] kirklund commented on pull request #5382: GEODE-8368: Upgrade ClassGraph from 4.8.52 to 4.8.87

Posted by GitBox <gi...@apache.org>.
kirklund commented on pull request #5382:
URL: https://github.com/apache/geode/pull/5382#issuecomment-662112663


   @onichols-pivotal ClassGraph has nothing to do with Log4j. I analyzed a test run in which a thread hung in ClassGraph#scan. ClassGraph has had many bugs identified and fixed between 4.8.52 and 4.8.87. I believe that a dependency like this should be kept up to date especially when important bugs have been fixed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] kirklund closed pull request #5382: GEODE-8368: Upgrade ClassGraph from 4.8.52 to 4.8.87

Posted by GitBox <gi...@apache.org>.
kirklund closed pull request #5382:
URL: https://github.com/apache/geode/pull/5382


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] onichols-pivotal commented on pull request #5382: GEODE-8368: Upgrade ClassGraph from 4.8.52 to 4.8.87

Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on pull request #5382:
URL: https://github.com/apache/geode/pull/5382#issuecomment-661500736


   Out of curiosity what are we changing this?  Was there a specific issue with 4.8.52 you are trying to solve?  I would much rather go back to 4.0.6 and fix the log4j issue with an exclusion, than mess around with any of these newfangled versions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org