You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/06/13 06:05:54 UTC

[GitHub] [airflow] Fokko commented on a change in pull request #5410: [AIRFLOW-4781] Add the ability to specify ports in kubernetesOperator

Fokko commented on a change in pull request #5410: [AIRFLOW-4781] Add the ability to specify ports in kubernetesOperator
URL: https://github.com/apache/airflow/pull/5410#discussion_r293217221
 
 

 ##########
 File path: airflow/kubernetes/pod_generator.py
 ##########
 @@ -62,6 +63,13 @@ def add_init_container(self,
     def _get_init_containers(self):
         return self.init_containers
 
+    def add_port(self, port):
 
 Review comment:
   We're introducing typehints into the Airflow codebase.
   ```suggestion
       def add_port(self, port: int):
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services