You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficcontrol.apache.org by Rawlin Peters <ra...@apache.org> on 2021/04/09 22:35:07 UTC
Deprecate TO API endpoint vault/bucket/:bucket/key/:key/values
Hey Traffic Controllers,
I'd like to propose that we deprecate the following route:
GET api/<version>/vault/bucket/:bucket/key/:key/values
This route is just a passthrough to the Riak API, allowing an admin to
get anything stored in Riak by bucket and key. We already have
specific routes to get everything stored in Riak, so I'm not sure what
value this route provides. Riak is being replaced with PostgreSQL, and
this route doesn't make sense for a PostgreSQL Traffic Vault backend
either. Additionally, my team hasn't used this route in at least the
last 30 days (and probably much longer than that).
I'd like to remove this from the 4.x API which is currently in
development, so I'll give this a few business days to respond w/ any
votes (silence is consent).
- Rawlin
Re: [EXTERNAL] Re: Deprecate TO API endpoint vault/bucket/:bucket/key/:key/values
Posted by Rawlin Peters <ra...@apache.org>.
Alright, since the consensus is to remove this route from the API, I
will open a PR to do so next week. Thank you all for the feedback.
- Rawlin
On Mon, Apr 12, 2021 at 9:25 AM Zach Hoffman <zr...@apache.org> wrote:
>
> +1, let's remove this. Besides being redundant, it could be used to fetch
> objects from the Riak instance that are not necessarily related to Traffic
> Control.
>
> -Zach
>
>
> On Mon, Apr 12, 2021 at 8:46 AM Chatterjee, Srijeet
> <SR...@comcast.com.invalid> wrote:
>
> > +1
> >
> > On 4/12/21, 7:58 AM, "Frey, Taylor" <Ta...@comcast.com.INVALID>
> > wrote:
> >
> > Agreed.
> >
> > From: Jeremy Mitchell <mi...@gmail.com>
> > Date: Saturday, April 10, 2021 at 9:41 AM
> > To: dev@trafficcontrol.apache.org <de...@trafficcontrol.apache.org>
> > Subject: [EXTERNAL] Re: Deprecate TO API endpoint
> > vault/bucket/:bucket/key/:key/values
> > +1
> >
> > On Fri, Apr 9, 2021 at 5:13 PM ocket 8888 <oc...@gmail.com> wrote:
> >
> > > +1000
> > >
> > > On Fri, Apr 9, 2021 at 4:35 PM Rawlin Peters <ra...@apache.org>
> > wrote:
> > >
> > > > Hey Traffic Controllers,
> > > >
> > > > I'd like to propose that we deprecate the following route:
> > > >
> > > > GET api/<version>/vault/bucket/:bucket/key/:key/values
> > > >
> > > > This route is just a passthrough to the Riak API, allowing an
> > admin to
> > > > get anything stored in Riak by bucket and key. We already have
> > > > specific routes to get everything stored in Riak, so I'm not sure
> > what
> > > > value this route provides. Riak is being replaced with PostgreSQL,
> > and
> > > > this route doesn't make sense for a PostgreSQL Traffic Vault
> > backend
> > > > either. Additionally, my team hasn't used this route in at least
> > the
> > > > last 30 days (and probably much longer than that).
> > > >
> > > > I'd like to remove this from the 4.x API which is currently in
> > > > development, so I'll give this a few business days to respond w/
> > any
> > > > votes (silence is consent).
> > > >
> > > > - Rawlin
> > > >
> > >
> >
> >
Re: [EXTERNAL] Re: Deprecate TO API endpoint vault/bucket/:bucket/key/:key/values
Posted by Zach Hoffman <zr...@apache.org>.
+1, let's remove this. Besides being redundant, it could be used to fetch
objects from the Riak instance that are not necessarily related to Traffic
Control.
-Zach
On Mon, Apr 12, 2021 at 8:46 AM Chatterjee, Srijeet
<SR...@comcast.com.invalid> wrote:
> +1
>
> On 4/12/21, 7:58 AM, "Frey, Taylor" <Ta...@comcast.com.INVALID>
> wrote:
>
> Agreed.
>
> From: Jeremy Mitchell <mi...@gmail.com>
> Date: Saturday, April 10, 2021 at 9:41 AM
> To: dev@trafficcontrol.apache.org <de...@trafficcontrol.apache.org>
> Subject: [EXTERNAL] Re: Deprecate TO API endpoint
> vault/bucket/:bucket/key/:key/values
> +1
>
> On Fri, Apr 9, 2021 at 5:13 PM ocket 8888 <oc...@gmail.com> wrote:
>
> > +1000
> >
> > On Fri, Apr 9, 2021 at 4:35 PM Rawlin Peters <ra...@apache.org>
> wrote:
> >
> > > Hey Traffic Controllers,
> > >
> > > I'd like to propose that we deprecate the following route:
> > >
> > > GET api/<version>/vault/bucket/:bucket/key/:key/values
> > >
> > > This route is just a passthrough to the Riak API, allowing an
> admin to
> > > get anything stored in Riak by bucket and key. We already have
> > > specific routes to get everything stored in Riak, so I'm not sure
> what
> > > value this route provides. Riak is being replaced with PostgreSQL,
> and
> > > this route doesn't make sense for a PostgreSQL Traffic Vault
> backend
> > > either. Additionally, my team hasn't used this route in at least
> the
> > > last 30 days (and probably much longer than that).
> > >
> > > I'd like to remove this from the 4.x API which is currently in
> > > development, so I'll give this a few business days to respond w/
> any
> > > votes (silence is consent).
> > >
> > > - Rawlin
> > >
> >
>
>
Re: [EXTERNAL] Re: Deprecate TO API endpoint
vault/bucket/:bucket/key/:key/values
Posted by "Chatterjee, Srijeet" <SR...@comcast.com.INVALID>.
+1
On 4/12/21, 7:58 AM, "Frey, Taylor" <Ta...@comcast.com.INVALID> wrote:
Agreed.
From: Jeremy Mitchell <mi...@gmail.com>
Date: Saturday, April 10, 2021 at 9:41 AM
To: dev@trafficcontrol.apache.org <de...@trafficcontrol.apache.org>
Subject: [EXTERNAL] Re: Deprecate TO API endpoint vault/bucket/:bucket/key/:key/values
+1
On Fri, Apr 9, 2021 at 5:13 PM ocket 8888 <oc...@gmail.com> wrote:
> +1000
>
> On Fri, Apr 9, 2021 at 4:35 PM Rawlin Peters <ra...@apache.org> wrote:
>
> > Hey Traffic Controllers,
> >
> > I'd like to propose that we deprecate the following route:
> >
> > GET api/<version>/vault/bucket/:bucket/key/:key/values
> >
> > This route is just a passthrough to the Riak API, allowing an admin to
> > get anything stored in Riak by bucket and key. We already have
> > specific routes to get everything stored in Riak, so I'm not sure what
> > value this route provides. Riak is being replaced with PostgreSQL, and
> > this route doesn't make sense for a PostgreSQL Traffic Vault backend
> > either. Additionally, my team hasn't used this route in at least the
> > last 30 days (and probably much longer than that).
> >
> > I'd like to remove this from the 4.x API which is currently in
> > development, so I'll give this a few business days to respond w/ any
> > votes (silence is consent).
> >
> > - Rawlin
> >
>
Re: [EXTERNAL] Re: Deprecate TO API endpoint
vault/bucket/:bucket/key/:key/values
Posted by "Frey, Taylor" <Ta...@comcast.com.INVALID>.
Agreed.
From: Jeremy Mitchell <mi...@gmail.com>
Date: Saturday, April 10, 2021 at 9:41 AM
To: dev@trafficcontrol.apache.org <de...@trafficcontrol.apache.org>
Subject: [EXTERNAL] Re: Deprecate TO API endpoint vault/bucket/:bucket/key/:key/values
+1
On Fri, Apr 9, 2021 at 5:13 PM ocket 8888 <oc...@gmail.com> wrote:
> +1000
>
> On Fri, Apr 9, 2021 at 4:35 PM Rawlin Peters <ra...@apache.org> wrote:
>
> > Hey Traffic Controllers,
> >
> > I'd like to propose that we deprecate the following route:
> >
> > GET api/<version>/vault/bucket/:bucket/key/:key/values
> >
> > This route is just a passthrough to the Riak API, allowing an admin to
> > get anything stored in Riak by bucket and key. We already have
> > specific routes to get everything stored in Riak, so I'm not sure what
> > value this route provides. Riak is being replaced with PostgreSQL, and
> > this route doesn't make sense for a PostgreSQL Traffic Vault backend
> > either. Additionally, my team hasn't used this route in at least the
> > last 30 days (and probably much longer than that).
> >
> > I'd like to remove this from the 4.x API which is currently in
> > development, so I'll give this a few business days to respond w/ any
> > votes (silence is consent).
> >
> > - Rawlin
> >
>
Re: Deprecate TO API endpoint vault/bucket/:bucket/key/:key/values
Posted by Jeremy Mitchell <mi...@gmail.com>.
+1
On Fri, Apr 9, 2021 at 5:13 PM ocket 8888 <oc...@gmail.com> wrote:
> +1000
>
> On Fri, Apr 9, 2021 at 4:35 PM Rawlin Peters <ra...@apache.org> wrote:
>
> > Hey Traffic Controllers,
> >
> > I'd like to propose that we deprecate the following route:
> >
> > GET api/<version>/vault/bucket/:bucket/key/:key/values
> >
> > This route is just a passthrough to the Riak API, allowing an admin to
> > get anything stored in Riak by bucket and key. We already have
> > specific routes to get everything stored in Riak, so I'm not sure what
> > value this route provides. Riak is being replaced with PostgreSQL, and
> > this route doesn't make sense for a PostgreSQL Traffic Vault backend
> > either. Additionally, my team hasn't used this route in at least the
> > last 30 days (and probably much longer than that).
> >
> > I'd like to remove this from the 4.x API which is currently in
> > development, so I'll give this a few business days to respond w/ any
> > votes (silence is consent).
> >
> > - Rawlin
> >
>
Re: Deprecate TO API endpoint vault/bucket/:bucket/key/:key/values
Posted by ocket 8888 <oc...@gmail.com>.
+1000
On Fri, Apr 9, 2021 at 4:35 PM Rawlin Peters <ra...@apache.org> wrote:
> Hey Traffic Controllers,
>
> I'd like to propose that we deprecate the following route:
>
> GET api/<version>/vault/bucket/:bucket/key/:key/values
>
> This route is just a passthrough to the Riak API, allowing an admin to
> get anything stored in Riak by bucket and key. We already have
> specific routes to get everything stored in Riak, so I'm not sure what
> value this route provides. Riak is being replaced with PostgreSQL, and
> this route doesn't make sense for a PostgreSQL Traffic Vault backend
> either. Additionally, my team hasn't used this route in at least the
> last 30 days (and probably much longer than that).
>
> I'd like to remove this from the 4.x API which is currently in
> development, so I'll give this a few business days to respond w/ any
> votes (silence is consent).
>
> - Rawlin
>