You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "ex172000 (via GitHub)" <gi...@apache.org> on 2026/01/27 07:40:20 UTC
[PR] ci(coverage): add JaCoCo code coverage with Codecov integration [iggy]
ex172000 opened a new pull request, #2623:
URL: https://github.com/apache/iggy/pull/2623
Add code coverage reporting for Java modules using JaCoCo and integrate with Codecov for PR coverage reports.
Changes:
- Add JaCoCo plugin (v0.8.14) to common conventions for all modules
- Create aggregated coverage report task combining all module coverage
- Update GitHub Actions to generate coverage reports and upload to Codecov
- Add .codecov.yml configuration with 70% threshold for new code
- Configure XML reports for Codecov and HTML for local viewing
Coverage reports will automatically appear as PR comments showing:
- Overall coverage percentage and trends
- Coverage diff for changed files
- File-by-file coverage breakdown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "ex172000 (via GitHub)" <gi...@apache.org>.
ex172000 commented on code in PR #2623:
URL: https://github.com/apache/iggy/pull/2623#discussion_r2777791824
##########
foreign/java/build.gradle.kts:
##########
@@ -21,6 +21,11 @@ import com.diffplug.gradle.spotless.SpotlessExtension
plugins {
alias(libs.plugins.spotless) apply false
+ jacoco
Review Comment:
Unfortunately
```
Plugin 'jacoco' is a core Gradle plugin, which cannot be specified with a version number. Such plugins are versioned as part of Gradle. Please remove the version number from the declaration.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "ex172000 (via GitHub)" <gi...@apache.org>.
ex172000 commented on PR #2623:
URL: https://github.com/apache/iggy/pull/2623#issuecomment-3866081720
> Hey @ex172000, please have a look at the few suggestions I've added.
Thanks for the review, please take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on code in PR #2623:
URL: https://github.com/apache/iggy/pull/2623#discussion_r2742930520
##########
.github/actions/java-gradle/pre-merge/action.yml:
##########
@@ -81,6 +81,37 @@ runs:
run: |
foreign/java/dev-support/checks/build.sh test
+ - name: Generate coverage report
+ if: inputs.task == 'test'
+ shell: bash
+ run: |
+ foreign/java/dev-support/checks/build.sh jacocoAggregatedReport
Review Comment:
@spetz can you comment on this? I think plenty of apache projects are using codecov so there shouldn't be any problems. the question is how will it play between Rust and java, because in future we want to see coverage for both. (2 langs, single repo)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "ex172000 (via GitHub)" <gi...@apache.org>.
ex172000 commented on code in PR #2623:
URL: https://github.com/apache/iggy/pull/2623#discussion_r2742666139
##########
.github/actions/java-gradle/pre-merge/action.yml:
##########
@@ -81,6 +81,37 @@ runs:
run: |
foreign/java/dev-support/checks/build.sh test
+ - name: Generate coverage report
+ if: inputs.task == 'test'
+ shell: bash
+ run: |
+ foreign/java/dev-support/checks/build.sh jacocoAggregatedReport
Review Comment:
Thanks for the note and will take a look at the existing code. In the meanwhile, I was wondering what's the policy for installing another tool to the repo and who will be managing it? We will have to link it to codecov so it can send the report as a comment.
In where I work we have a hover annotating each line for coverage, I don't know if this is a feature of Github Enterprise or not, looks very intuitive and want to have it here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "ex172000 (via GitHub)" <gi...@apache.org>.
ex172000 commented on code in PR #2623:
URL: https://github.com/apache/iggy/pull/2623#discussion_r2742666139
##########
.github/actions/java-gradle/pre-merge/action.yml:
##########
@@ -81,6 +81,37 @@ runs:
run: |
foreign/java/dev-support/checks/build.sh test
+ - name: Generate coverage report
+ if: inputs.task == 'test'
+ shell: bash
+ run: |
+ foreign/java/dev-support/checks/build.sh jacocoAggregatedReport
Review Comment:
Thanks for the note and will take a look at the existing code. In the meanwhile, I was wondering what's the policy for installing another tool to the repo and who will be managing it? We will have to link it to codecov so it can send the report as a comment.
In where I work we have a hover annotating each line for coverage, I don't know if this is a feature of Github Enterprise, looks very intuitive and want to have it here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "ex172000 (via GitHub)" <gi...@apache.org>.
ex172000 commented on code in PR #2623:
URL: https://github.com/apache/iggy/pull/2623#discussion_r2777231890
##########
.codecov.yml:
##########
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+codecov:
+ require_ci_to_pass: yes
+ notify:
+ wait_for_ci: yes
+
+coverage:
+ precision: 2
+ round: down
+ range: "60...90"
+
+ status:
+ project:
+ default:
+ target: auto
+ threshold: 6%
Review Comment:
This is high due to lack of Java coverage. This diff will cause a > 5% drop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "ex172000 (via GitHub)" <gi...@apache.org>.
ex172000 commented on PR #2623:
URL: https://github.com/apache/iggy/pull/2623#issuecomment-3856106843
> Hey @ex172000, we now have the codecov integration setup for the rust code (done by @hubcio), so adding the java part should be much easier now :) Let us know if you want to continue with this PR.
Hi @mmodzelewski @hubcio , sorry it took a while. Something came up from work. I will return to fix the Java part tomorrow afternoon Pacific time. Will update to OPEN state as soon as it's ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski commented on PR #2623:
URL: https://github.com/apache/iggy/pull/2623#issuecomment-3854027997
Hey @ex172000, we now have the codecov integration setup for the rust code (done by @hubcio), so adding the java part should be much easier now :) Let us know if you want to continue with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski merged PR #2623:
URL: https://github.com/apache/iggy/pull/2623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski commented on code in PR #2623:
URL: https://github.com/apache/iggy/pull/2623#discussion_r2743375161
##########
.github/actions/java-gradle/pre-merge/action.yml:
##########
@@ -81,6 +81,37 @@ runs:
run: |
foreign/java/dev-support/checks/build.sh test
+ - name: Generate coverage report
+ if: inputs.task == 'test'
+ shell: bash
+ run: |
+ foreign/java/dev-support/checks/build.sh jacocoAggregatedReport
Review Comment:
@hubcio codecov supports monorepos, you can split the coverages by components or labels, from what I've seen.
https://app.codecov.io/gh/apache/iggy Iggy is already in codecov, but the repo is marked as deactivated, but I guess once we do the first upload it should be activated.
@ex172000 I see that we've already got a `CODECOV_TOKEN` in the secrets so we can try to push some results. If that does not work, I can update the token (the current one might be already inactive)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on code in PR #2623:
URL: https://github.com/apache/iggy/pull/2623#discussion_r2745734996
##########
.github/actions/java-gradle/pre-merge/action.yml:
##########
@@ -81,6 +81,37 @@ runs:
run: |
foreign/java/dev-support/checks/build.sh test
+ - name: Generate coverage report
+ if: inputs.task == 'test'
+ shell: bash
+ run: |
+ foreign/java/dev-support/checks/build.sh jacocoAggregatedReport
Review Comment:
maybe you might want to unmark this PR as draft? not sure if codecov somehow checks it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2623:
URL: https://github.com/apache/iggy/pull/2623#issuecomment-3863725039
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/2623?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 56.98%. Comparing base ([`30f4568`](https://app.codecov.io/gh/apache/iggy/commit/30f456832f447a356cae31fb1d655f0622faadbf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`690574d`](https://app.codecov.io/gh/apache/iggy/commit/690574d458166fd15471d79d5e3d38c30559f97b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (30f4568) and HEAD (690574d). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (30f4568) | HEAD (690574d) |
>|------|------|------|
>|rust|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/iggy/pull/2623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2623 +/- ##
=============================================
- Coverage 69.51% 56.98% -12.54%
- Complexity 0 637 +637
=============================================
Files 568 153 -415
Lines 55238 3473 -51765
Branches 55238 216 -55022
=============================================
- Hits 38399 1979 -36420
+ Misses 14961 1409 -13552
+ Partials 1878 85 -1793
```
| [Flag](https://app.codecov.io/gh/apache/iggy/pull/2623/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [java](https://app.codecov.io/gh/apache/iggy/pull/2623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.98% <100.00%> (?)` | |
| [rust](https://app.codecov.io/gh/apache/iggy/pull/2623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/2623?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...in/java/org/apache/iggy/serde/BytesSerializer.java](https://app.codecov.io/gh/apache/iggy/pull/2623?src=pr&el=tree&filepath=foreign%2Fjava%2Fjava-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Figgy%2Fserde%2FBytesSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9qYXZhL2phdmEtc2RrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pZ2d5L3NlcmRlL0J5dGVzU2VyaWFsaXplci5qYXZh) | `97.03% <100.00%> (ø)` | |
... and [720 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/2623/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski commented on code in PR #2623:
URL: https://github.com/apache/iggy/pull/2623#discussion_r2779718039
##########
codecov.yml:
##########
@@ -41,6 +41,17 @@ comment:
require_base: true
require_head: true
+flags:
Review Comment:
I am not sure if we need to add this in the config, the flags are already passed with the upload. Also, it seems that carryforward is not needed in our case, unless I misunderstood how this work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on PR #2623:
URL: https://github.com/apache/iggy/pull/2623#issuecomment-3807140147
@ex172000 can you modify single file java file under this PR so we can see how does the codecov comment looks like?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on code in PR #2623:
URL: https://github.com/apache/iggy/pull/2623#discussion_r2741640669
##########
.github/actions/java-gradle/pre-merge/action.yml:
##########
@@ -81,6 +81,37 @@ runs:
run: |
foreign/java/dev-support/checks/build.sh test
+ - name: Generate coverage report
+ if: inputs.task == 'test'
+ shell: bash
+ run: |
+ foreign/java/dev-support/checks/build.sh jacocoAggregatedReport
Review Comment:
our CI is written in way so that if e.g. rust `iggy-server` code is changed (because in fact it is a non-explicit dependency), it'll also run java tests. with current approach here it'll post a comment under a PR which does not touch java files
suggestion: before generating coverage report (or making the bot comment in general) check if there are any `*.java` modified files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski commented on code in PR #2623:
URL: https://github.com/apache/iggy/pull/2623#discussion_r2777498821
##########
foreign/java/build.gradle.kts:
##########
@@ -103,3 +108,37 @@ subprojects {
}
}
}
+
+tasks.register<JacocoReport>("jacocoAggregatedReport") {
+ description = "Generates aggregated code coverage report for all modules"
+ group = "verification"
+
+ dependsOn(subprojects.map { it.tasks.named("test") })
+
+ // Aggregate execution data from all subprojects
+ executionData.setFrom(files(subprojects.mapNotNull {
+ val testTask = it.tasks.findByName("test") as? Test
Review Comment:
instead of casting you could use something like `it.tasks.withType<Test>()` which is available in gradle kts
##########
.codecov.yml:
##########
Review Comment:
This seems to be duplicating the `codecov.yml` that is already in the repository. Please update the other file and remove this one.
##########
foreign/java/build.gradle.kts:
##########
@@ -21,6 +21,11 @@ import com.diffplug.gradle.spotless.SpotlessExtension
plugins {
alias(libs.plugins.spotless) apply false
+ jacoco
Review Comment:
Can you add jacoco like spotless with specific version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "ex172000 (via GitHub)" <gi...@apache.org>.
ex172000 commented on PR #2623:
URL: https://github.com/apache/iggy/pull/2623#issuecomment-3807155488
> @ex172000 can you modify single file java file under this PR so we can see how does the codecov comment looks like?
Yes definitely. Was trying to fix issues first. Will add it in the next commit(s).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski commented on PR #2623:
URL: https://github.com/apache/iggy/pull/2623#issuecomment-3868047804
@hubcio, would you mind checking it as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski commented on code in PR #2623:
URL: https://github.com/apache/iggy/pull/2623#discussion_r2743375161
##########
.github/actions/java-gradle/pre-merge/action.yml:
##########
@@ -81,6 +81,37 @@ runs:
run: |
foreign/java/dev-support/checks/build.sh test
+ - name: Generate coverage report
+ if: inputs.task == 'test'
+ shell: bash
+ run: |
+ foreign/java/dev-support/checks/build.sh jacocoAggregatedReport
Review Comment:
@hubcio codecov supports monorepos, you can split the coverages by components or labels, from what I've seen.
https://app.codecov.io/gh/apache/iggy Iggy is already in codecov, but the repo is marked as deactivated, but I guess once we do the first upload it should be activated.
@ex172000 I see that we've already got a `CODECOV_TOKEN` in the secrets so we can try to push some results. If that does not work, I can update the token (the current one might be already inactive)
Edit: I've now marked the repo as active in codecov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "ex172000 (via GitHub)" <gi...@apache.org>.
ex172000 commented on code in PR #2623:
URL: https://github.com/apache/iggy/pull/2623#discussion_r2743398654
##########
.github/actions/java-gradle/pre-merge/action.yml:
##########
@@ -81,6 +81,37 @@ runs:
run: |
foreign/java/dev-support/checks/build.sh test
+ - name: Generate coverage report
+ if: inputs.task == 'test'
+ shell: bash
+ run: |
+ foreign/java/dev-support/checks/build.sh jacocoAggregatedReport
Review Comment:
@mmodzelewski thanks for the context! Let me try to push another commit to test out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add JaCoCo code coverage with Codecov integration [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on code in PR #2623:
URL: https://github.com/apache/iggy/pull/2623#discussion_r2741640669
##########
.github/actions/java-gradle/pre-merge/action.yml:
##########
@@ -81,6 +81,37 @@ runs:
run: |
foreign/java/dev-support/checks/build.sh test
+ - name: Generate coverage report
+ if: inputs.task == 'test'
+ shell: bash
+ run: |
+ foreign/java/dev-support/checks/build.sh jacocoAggregatedReport
Review Comment:
our CI is written in way so that if e.g. rust `iggy-server` code is changed (because in fact it is a non-explicit dependency), it'll also run java sdk tests. with current approach here it'll post a comment under a PR which does not touch java files
suggestion: before generating coverage report (or making the bot comment in general) check if there are any `*.java` modified files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org