You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/16 06:08:32 UTC

[GitHub] [incubator-nuttx] jlaitine opened a new pull request, #6450: arch/riscv/mpfs: Add a config flag to select SD mux state

jlaitine opened a new pull request, #6450:
URL: https://github.com/apache/incubator-nuttx/pull/6450

   This has been previously hard-coded to SD-card. Make it build time configurable.
   
   Signed-off-by: Jukka Laitinen <ju...@ssrc.tii.ae>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] acassis merged pull request #6450: arch/riscv/mpfs: Add a config flag to select SD mux state

Posted by GitBox <gi...@apache.org>.
acassis merged PR #6450:
URL: https://github.com/apache/incubator-nuttx/pull/6450


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6450: arch/riscv/mpfs: Add a config flag to select SD mux state

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6450:
URL: https://github.com/apache/incubator-nuttx/pull/6450#discussion_r898746060


##########
arch/risc-v/src/mpfs/mpfs_emmcsd.c:
##########
@@ -442,7 +442,11 @@ struct mpfs_dev_s g_emmcsd_dev =
   },
   .hw_base           = MPFS_EMMC_SD_BASE,
   .plic_irq          = MPFS_IRQ_MMC_MAIN,
-  .emmc              = false,               /* Set true for emmc operation */
+#ifdef CONFIG_MPFS_EMMCSD_MUX_EMMC
+  .emmc = true,

Review Comment:
   should we align = with others



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org