You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jacob Janco <jj...@gmail.com> on 2017/01/25 23:25:45 UTC
Re: Review Request 54410: Made the style of the cluster name
consistent with others.
> On Dec. 9, 2016, 7:51 p.m., Benjamin Mahler wrote:
> > If it looks the same as the other navbar tabs, it seems clickable? At least when it is greyed out I wouldn't think I can click it.
>
> haosdent huang wrote:
> Got it, use `btn disabled` to make it grey now.
Hey, responding to your review req ->
I checked the current styling and it looks consistent for me with no change, alignment/text size and font is the same.
- Jacob
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54410/#review158716
-----------------------------------------------------------
On Dec. 13, 2016, 7:58 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54410/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2016, 7:58 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Vinod Kone.
>
>
> Bugs: MESOS-6725
> https://issues.apache.org/jira/browse/MESOS-6725
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the style of the cluster name consistent with other texts in the
> navbar.
>
>
> Diffs
> -----
>
> src/webui/master/static/index.html a4eda3034906d100a20dcd0a2473112c1edd6b42
>
> Diff: https://reviews.apache.org/r/54410/diff/
>
>
> Testing
> -------
>
> # Before:
>
> 
>
> # After:
>
> 
>
>
> Thanks,
>
> haosdent huang
>
>