You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2017/08/30 17:38:03 UTC
Review Request 61995: wip
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61995/
-----------------------------------------------------------
Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
Repository: geode
Description
-------
GEODE-3539: add test for invalid command
* also rework GfshCommandIntegrationTest in assembly module
Diffs
-----
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/GfshCommandIntegrationTest.java 263b12cbdee2bc5637e64fdad0e34262ab5f25e7
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GfshCommandIntegrationTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/StartMemberUtilsTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/61995/diff/1/
Testing
-------
precheckin running
Thanks,
Jinmei Liao
Re: Review Request 61995: wip
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61995/#review184174
-----------------------------------------------------------
Ship it!
Ship It!
- Jared Stewart
On Aug. 30, 2017, 5:38 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61995/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2017, 5:38 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-3539: add test for invalid command
>
> * also rework GfshCommandIntegrationTest in assembly module
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/GfshCommandIntegrationTest.java 263b12cbdee2bc5637e64fdad0e34262ab5f25e7
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GfshCommandIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/StartMemberUtilsTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61995/diff/1/
>
>
> Testing
> -------
>
> precheckin running
>
>
> Thanks,
>
> Jinmei Liao
>
>